[SRU] Integer parsing failure on armhf blocks autopkgtests on focal
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
php-parser (Ubuntu) |
Fix Released
|
High
|
Bryce Harrington | ||
Focal |
Fix Released
|
High
|
Bryce Harrington | ||
Groovy |
Fix Released
|
High
|
Bryce Harrington |
Bug Description
[Impact]
Other PHP SRUs are being blocked due to test failures in php-parser. The test case failures appear to be due to irregularities with integer parsing particular to the test framework rather than identifying actual bugs.
[Test Case]
1. Create lxc container for ubuntu-focal
2. Install php-parser
3. Run autopkgtest php-parser -- null
The testsuite should pass but it does not, and fails with several invalid token lexer cases starting with and similar to this one:
1) PhpParser\
RangeException: The lexer returned an invalid token (id=320, value=)
/usr/share/
/usr/share/
/tmp/autopkgtes
/tmp/autopkgtes
The build system also runs the test suite, so an alternative way to reproduce the failure is to do a package build of php-parser in lxc.
[Regression Potential]
Since this is a testsuite fix for integer parsing, the two things to watch for would be a) issues relating to the testsuite, or b) issues particular to integer parsing behavior. However, in the first case, the testsuite's behavior would crop up only during building / migrating in the archive and would not produce user-visible effects. In the second case, integer parsing issues already exist in released code so would not be a true regression, the test case only exposes them - by preventing other php packages from migrating.
[Discussion]
php-parser's autopkgtest has been failing in focal on armhf for some time:
http://
The test failure is due to an integer format mismatch. We spotted this issue on groovy and flagged it for upstream:
https:/
There doesn't appear to be a fix identified yet. We addressed it in groovy by disabling the faulty tests (the one listed in this bug, and the one in LP: #1878102), and that may be a low-risk way to address it for focal, too.
https:/
Related branches
- Bryce Harrington (community): Approve
- Christian Ehrhardt (community): Needs Fixing
- Canonical Server MOTU reviewers: Pending requested
-
Diff: 252 lines (+206/-0)7 files modifieddebian/changelog (+18/-0)
debian/patches/disable-CodeParsingTest-due-to-integer-syntax.patch (+65/-0)
debian/patches/disable-broken-test-case-in-EmulativeTest.patch (+38/-0)
debian/patches/series (+7/-0)
debian/patches/skip-EmulativeTest-testErrorAfterEmulation.patch (+26/-0)
debian/patches/skip-LexerTest-testError.patch (+26/-0)
debian/patches/skip-PrettyPrinterTest.patch (+26/-0)
Changed in php-parser (Ubuntu): | |
importance: | Undecided → High |
status: | New → Triaged |
assignee: | nobody → Bryce Harrington (bryce) |
tags: | added: server-next |
summary: |
- Integer parsing failure on armhf blocks autopkgtests on focal + [SRU] Integer parsing failure on armhf blocks autopkgtests on focal |
description: | updated |
description: | updated |
description: | updated |
Changed in php-parser (Ubuntu Focal): | |
assignee: | nobody → Bryce Harrington (bryce) |
importance: | Undecided → High |
status: | New → Triaged |
Changed in php-parser (Ubuntu Groovy): | |
status: | Triaged → Fix Released |
description: | updated |
description: | updated |
Marking block-proposed- focal as this is an autopkgtest fix only, should be sufficient to just be in proposed, and there's no need to make users download this update.