Merge php-defaults from Debian unstable for mantic

[Bryce Harrington]

Upstream: tbd
Debian: 93
Ubuntu: 92ubuntu1

Debian does new releases regularly, so it's likely there will be newer versions available before FF that we can pick up if this merge is done later in the cycle.

If it turns out this needs a sync rather than a merge, please change the tag 'needs-merge' to 'needs-sync', and (optionally) update the title as desired.

### New Debian Changes ###

php-defaults (93) unstable; urgency=medium

  * Bump the default and supported version to PHP 8.2

 -- Ondřej Surý <email address hidden> Wed, 13 Jul 2022 10:19:37 +0200

php-defaults (92) unstable; urgency=medium

  * Update the list of the broken PECL modules with the PHP 8.1 upgrade

 -- Ondřej Surý <email address hidden> Tue, 11 Jan 2022 21:51:17 +0100

php-defaults (91) unstable; urgency=medium

  * Start the PHP 8.1 transition

 -- Ondřej Surý <email address hidden> Fri, 31 Dec 2021 12:16:23 +0100

php-defaults (90) experimental; urgency=medium

  * Actually regenerate d/control with the new default PHP version

 -- Ondřej Surý <email address hidden> Wed, 24 Nov 2021 17:18:11 +0100

php-defaults (89) experimental; urgency=medium

  * Bump the Debian version to PHP 8.1

 -- Ondřej Surý <email address hidden> Tue, 23 Nov 2021 11:54:47 +0100

php-defaults (88) unstable; urgency=medium

  [David Prévot]
  * Ensure binary packages get a higher version for the revert
  * Don’t depend on PHP 8.0 packages

 -- Ondřej Surý <email address hidden> Tue, 23 Nov 2021 11:48:13 +0100

php-defaults (87) unstable; urgency=medium

  * Revert 'Start the transition to PHP 8.0'

 -- Ondřej Surý <email address hidden> Sat, 20 Nov 2021 08:20:12 +0100

php-defaults (86) unstable; urgency=medium

  * Revert 'Bump the Debian version to PHP 8.1'

 -- Ondřej Surý <email address hidden> Fri, 19 Nov 2021 21:34:10 +0100

php-defaults (85) unstable; urgency=medium

  * Drop gettext from the list of the modules
  * Fix the d/rules script break on empty PHP_BREAKS_PACKAGES
  * Bump the Debian version to PHP 8.1

 -- Ondřej Surý <email address hidden> Thu, 04 Nov 2021 14:57:36 +0100

php-defaults (84) unstable; urgency=medium

  * No change version bump.

 -- Ondřej Surý <email address hidden> Mon, 21 Jun 2021 07:29:15 +0200

php-defaults (83) unstable; urgency=medium

  * Don't try to execute uninstalled php cli binaries to prevent session
    files pile up

 -- Ondřej Surý <email address hidden> Mon, 21 Jun 2021 07:29:15 +0200

php-defaults (82) unstable; urgency=medium

  * No change version bump.

 -- Ondřej Surý <email address hidden> Sat, 13 Mar 2021 13:53:51 +0100

php-defaults (81) unstable; urgency=medium

  * php8.0: XMLRPC has been moved from base to PECL
  * Add phpX.Y-mbstring to php-all-dev dependencies
  * Add virtual php-gettext package

 -- Ondřej Surý <email address hidden> Mon, 22 Feb 2021 11:45:43 +0100

php-defaults (80) unstable; urgency=medium

  * Upload to unstable

 -- Ondřej Surý <email address hidden> Sat, 20 Feb 2021 07:44:19 +0100

php-defaults (80~exp3) experimental; urgency=medium

  * Add phpX.Y-mbstring to php-all-dev dependencies

 -- Ondřej Surý <email address hidden> Fri, 19 Feb 2021 21:13:06 +0100

php-defaults (80~exp2) experimental; urgency=medium

  * Remove dummy dependency packages for XMLRPC

### Old Ubuntu Delta ###

php-defaults (92ubuntu1) jammy; urgency=medium

  * Adjust Breaks to account for Ubuntu-side fixes.
    - Ubuntu enabled php8.1 support in earlier versions of php-facedetect,
      php-libvirt-php, php-tideways, and php-xmlrpc than Debian so can
      adjust Breaks to those earlier versions for now.

 -- Bryce Harrington <email address hidden> Fri, 28 Jan 2022 01:45:15 +0000

[Athos Ribeiro (athos-ribeiro)]

The current Ubuntu delta reduced the Breaks minimal version for some PECL extensions to account for the state of the Ubuntu archive back during the PHP 8.1 transition. They were

- Debian
+ Ubuntu

- php-facedetect (<< 1.1.0-19-g135c72a-10~),
+ php-facedetect (<< 1.1.0-19-g135c72a-2build3~),

- php-libvirt-php (<< 0.5.5-16~),
+ php-libvirt-php (<< 0.5.5-3ubuntu2~),

- php-tideways (<< 5.0.4-13~),
+ php-tideways (<< 5.0.4-2build3~),

- php-xmlrpc (<< 3:1.0.0~rc3-4~),
+ php-xmlrpc (<< 3:1.0.0~rc3-2~),

with exception of php-facedetect, all the other PECL extensions in mantic are in versions greater than the Debian Breaks targets, which makes it safe for us to sync the package (except for php-facedetect).

However, php-facedetect has been broken for a while (see LP: #1951812, #1995628). The current mantic package is installable, but does not contain the shared object it was supposed to ship, resulting in a broken package.

1.1.0-19-g135c72a-10 is supposed to fix the issues, but the package hasn't been uploaded in Debian for a while now (https://salsa.debian.org/php-team/pecl/php-facedetect/-/blob/debian/main/debian/changelog#L43).

Therefore, we can either:

1) merge php-defaults, keeping the "php-facedetect (<< 1.1.0-19-g135c72a-2build3~)" Breaks entry. This way php-facedetect will still be installable and we can work on fixing it after the 8.2 transition is complete;

2) sync php-defaults with php-facedetect as is. This will make php-facedetect uninstallable. We can then either fix it or get it removed from the archive for mantic (so far, it is not making it into the next Debian release either).

3) Remove php-facedetect from the archive and only then sync php-defaults.

4) Fix php-facedetect and only then sync (or merge, depending on the facedetect fixed version) php-defaults.

For now, I am inclined to go with (2). (1) would leave lots of space for allowing php-facedetect to fall behind and remain broken. (3) can just be deferred if we go with (2). (4) could add extra work since there is a chance we may need to fix the package twice (for php8.1 and then for php8.2).

Thoughts?

[Sergio Durigan Junior (sergiodj)]

Hey Athos,

Without spending time to actually look into the situation with my own eyes, I believe (2) is the best course of action here. If php-facedetect is unusable as is, it doesn't really hurt to make it uninstallable as well. As you said, we can then decide to either fix it or remove from the archive. Something to keep in mind here is that the transition might get blocked if php-facedetect becomes uninstallable (britney doesn't like this), so you would have to sort its situation out before php-defaults can actually migrate, but I'm assuming there would be a lot of other things to do before we reach the point where php-facedetect is the only thing blocking progress.

[Bryce Harrington (bryce)]

IMHO there is not much advantage to having php-defaults syncable, and indeed there is a side-effect to having it in a sync state: At the start of a new Ubuntu cycle when the archive opens up, php-defaults will automatically sync in whatever version's current in Debian, resulting us starting a PHP transition immediately, whether we plan to or not.

For this reason, I see little harm in keeping whatever miscellaneous delta we want on php-defaults, and just do merges (your option #1).

As to what to do with php-facedetect, of course it could be fixed, dropped temporarily, or dropped permanently and blacklisted. Offhand the two bugs linked don't look fundamentally unfixable, so I'd lean towards just fixing it if possible. Presumably the package is useful to our users given that a couple bothered to file bug reports about it. ;-)

[Athos Ribeiro (athos-ribeiro)]

As it was done for the other php transitions in the past, I am keeping track of this transition at https://wiki.ubuntu.com/ServerTeam/Transition/Php8.2

[Launchpad Janitor (janitor)]

This bug was fixed in the package php-defaults - 93ubuntu1

---------------
php-defaults (93ubuntu1) mantic; urgency=medium

  * Merge with Debian unstable (LP: #2018100). Remaining changes:
    - Adjust Breaks to account for Ubuntu-side fixes.
      + Ubuntu enabled php8.1 support in an earlier version of php-facedetect
        than Debian. Hence, we adjust Breaks to that earlier version for now
  * Dropped changes:
    - Bogus source package re-injection
      [ This was a leftover from a previous package merge ]
    - Adjust Breaks to account for Ubuntu-side fixes.
      + Ubuntu enabled php8.1 support in earlier versions of php-libvirt-php,
        php-tideways, and php-xmlrpc than Debian. Hence, we adjust Breaks to
        those earlier versions for now
      [ mantic has greater versions than the Debian Breaks targets ]

 -- Athos Ribeiro <email address hidden> Thu, 18 May 2023 16:41:14 -0300