Activity log for bug #1699659

Date Who What changed Old value New value Message
2017-06-22 04:36:06 Jason Short bug added bug
2017-06-22 15:14:09 Nish Aravamudan bug watch added http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834189
2017-06-22 15:14:09 Nish Aravamudan bug task added php-defaults (Debian)
2017-06-22 15:15:23 Nish Aravamudan nominated for series Ubuntu Yakkety
2017-06-22 15:15:23 Nish Aravamudan bug task added php-defaults (Ubuntu Yakkety)
2017-06-22 15:15:23 Nish Aravamudan nominated for series Ubuntu Artful
2017-06-22 15:15:23 Nish Aravamudan bug task added php-defaults (Ubuntu Artful)
2017-06-22 15:15:23 Nish Aravamudan nominated for series Ubuntu Zesty
2017-06-22 15:15:23 Nish Aravamudan bug task added php-defaults (Ubuntu Zesty)
2017-06-22 15:15:31 Nish Aravamudan nominated for series Ubuntu Xenial
2017-06-22 15:15:31 Nish Aravamudan bug task added php-defaults (Ubuntu Xenial)
2017-06-22 15:15:54 Nish Aravamudan php-defaults (Ubuntu Yakkety): status New Fix Released
2017-06-22 15:16:06 Nish Aravamudan php-defaults (Ubuntu Zesty): status New Fix Released
2017-06-22 15:16:08 Nish Aravamudan php-defaults (Ubuntu Artful): status New Fix Released
2017-06-22 15:23:03 Nish Aravamudan php-defaults (Ubuntu Xenial): status New Triaged
2017-06-22 15:23:05 Nish Aravamudan php-defaults (Ubuntu Xenial): assignee Nish Aravamudan (nacc)
2017-06-22 15:45:16 Bug Watch Updater php-defaults (Debian): status Unknown Fix Released
2017-06-22 15:49:10 Nish Aravamudan php-defaults (Ubuntu Xenial): status Triaged In Progress
2017-06-22 20:27:21 Nish Aravamudan description In the course of diagnosing an issue with a PHP module (xdebug in this case) kept re-enabling itself during upgrades of libapache2-mod-php7.0, I found the following: 1. libapache2-mod-php7.0 postscript sources /usr/lib/php/php-maintscript-helper from php-common to re-enable modules that have not been administratively disabled. 2. php-maintscript-helper calls phpenmod based on the output and return codes of phpquery 3. phpquery calls its own action() function, which initializes the $ret variable to 0 4. phpquery action() calls into various other functions in the script, and sets the $ret variable based on their returns 5. phpquery action() returns 0 6. php-maintscript-helper correspondingly calls phpenmod on all available php modules for the apache2 SAPI Source link for xenial: https://git.launchpad.net/~usd-import-team/ubuntu/+source/php-defaults/tree/phpquery?h=ubuntu/xenial#n162 the following addition to action() after the esac is necessary to bubble up the internal functions' returns: return $ret [Impact] * various PHP postinst uses php-defaults' scripts for determing what actions to perform. * The phpquery script has an error that does not propogate state correctly. [Test Case] [Regression Potential] * This is pure bug-fix backport from version 44 (in yakkety and on) to xenial. The regression potential is very low; most likely people were seeing the issue as reported in this bug and manually, e.g., disabling modules again on every upgrade. This will actually avoid having to do that. --- In the course of diagnosing an issue with a PHP module (xdebug in this case) kept re-enabling itself during upgrades of libapache2-mod-php7.0, I found the following: 1. libapache2-mod-php7.0 postscript sources /usr/lib/php/php-maintscript-helper from php-common to re-enable modules that have not been administratively disabled. 2. php-maintscript-helper calls phpenmod based on the output and return codes of phpquery 3. phpquery calls its own action() function, which initializes the $ret variable to 0 4. phpquery action() calls into various other functions in the script, and sets the $ret variable based on their returns 5. phpquery action() returns 0 6. php-maintscript-helper correspondingly calls phpenmod on all available php modules for the apache2 SAPI Source link for xenial: https://git.launchpad.net/~usd-import-team/ubuntu/+source/php-defaults/tree/phpquery?h=ubuntu/xenial#n162 the following addition to action() after the esac is necessary to bubble up the internal functions' returns: return $ret
2017-07-12 14:47:36 Robie Basak php-defaults (Ubuntu Xenial): status In Progress Fix Committed
2017-07-12 14:47:39 Robie Basak bug added subscriber Ubuntu Stable Release Updates Team
2017-07-12 14:47:41 Robie Basak bug added subscriber SRU Verification
2017-07-12 14:47:45 Robie Basak tags verification-needed verification-needed-xenial
2017-07-25 15:24:58 Jason Short tags verification-needed verification-needed-xenial verification-done-xenial
2018-02-15 08:43:34 Launchpad Janitor php-defaults (Ubuntu Xenial): status Fix Committed Fix Released
2018-02-15 08:43:41 Ɓukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team