Update d/rules UPSTREAM regex

Bug #1563098 reported by Nish Aravamudan on 2016-03-28
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
phing (Debian)
Fix Released
Unknown
phing (Ubuntu)
Undecided
Unassigned
php-apigen (Ubuntu)
Undecided
Unassigned

Bug Description

The UPSTREAM regex in d/rules does not work for longer suffixes.

Steve Langasek (vorlon) wrote :

+UPSTREAM := $(shell head -1 debian/changelog | sed 's/.*(//;s/-.*?*).*//')

That works, but isn't a great fix. The '.?*' from the original, AFAICS, never should have been there, and .*?* is differently buggy... there shouldn't be a literal '?' in the string.

A better fix would be:

+UPSTREAM := $(shell head -1 debian/changelog | sed 's/.*(//;s/-[^)-]\+).*//')

Steve Langasek (vorlon) on 2016-03-29
Changed in php-apigen (Ubuntu):
status: New → Fix Committed
Changed in phing (Ubuntu):
status: New → Fix Committed
Nish Aravamudan (nacc) on 2016-03-29
Changed in phing (Ubuntu):
status: Fix Committed → New
Changed in php-apigen (Ubuntu):
status: Fix Committed → New
Nish Aravamudan (nacc) wrote :
Nish Aravamudan (nacc) wrote :
Nish Aravamudan (nacc) wrote :

Thanks for the help on IRC, Steve, I believe these regex are correct, and match what some other packages do.

Steve Langasek (vorlon) on 2016-03-29
Changed in phing (Ubuntu):
status: New → Fix Committed
Changed in php-apigen (Ubuntu):
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package phing - 2.13.0-2ubuntu2

---------------
phing (2.13.0-2ubuntu2) xenial; urgency=medium

  * Correctly update regex (LP: #1563098).

 -- Nishanth Aravamudan <email address hidden> Tue, 29 Mar 2016 13:20:00 -0700

Changed in phing (Ubuntu):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package php-apigen - 4.1.2-1ubuntu2

---------------
php-apigen (4.1.2-1ubuntu2) xenial; urgency=medium

  * Correctly update regex (LP: #1563098).

 -- Nishanth Aravamudan <email address hidden> Tue, 29 Mar 2016 13:20:40 -0700

Changed in php-apigen (Ubuntu):
status: Fix Committed → Fix Released
Changed in phing (Debian):
status: Unknown → New
Changed in phing (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.