Crash on startup (Python3.8) - TypeError: 'bool' object is not iterable

[fcole90]

[Impact]

Crashes at startup.

[Test Plan]

* Install photofilmstrip from focal-proposed.

* Find that it starts without crashing.

[Where problems could occur]

* Cherry picked upstream one liner.
* No reverse dependencies.
* Can't be worse. ;)

[Original description]

Upon startup it crashes. A fix is already available.

Upstream GH bug: https://github.com/PhotoFilmStrip/PFS/issues/68

Upstream debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955295

Fixed version: https://github.com/PhotoFilmStrip/PFS/releases/tag/v3.7.3

What happens:
```
$ photofilmstrip
Traceback (most recent call last):
  File "/usr/bin/photofilmstrip", line 8, in <module>
    main()
  File "/usr/lib/python3/dist-packages/photofilmstrip/GUI.py", line 46, in main
    guiApp.Start()
  File "/usr/lib/python3/dist-packages/photofilmstrip/AppMixin.py", line 41, in Start
    self.InitI18N()
  File "/usr/lib/python3/dist-packages/photofilmstrip/AppMixin.py", line 31, in InitI18N
    ActionI18N().Execute()
  File "/usr/lib/python3/dist-packages/photofilmstrip/action/ActionI18N.py", line 43, in Execute
    lang.install(True)
  File "/usr/lib/python3.8/gettext.py", line 352, in install
    for name in allowed & set(names):
TypeError: 'bool' object is not iterable
```

What should happen:
The program loads without crashing

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: photofilmstrip 3.7.2-1
ProcVersionSignature: Ubuntu 5.4.0-21.25-generic 5.4.27
Uname: Linux 5.4.0-21-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.11-0ubuntu22
Architecture: amd64
CurrentDesktop: GNOME
Date: Tue Apr 7 17:16:17 2020
InstallationDate: Installed on 2020-04-03 (3 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Beta amd64 (20200401)
PackageArchitecture: all
SourcePackage: photofilmstrip
UpgradeStatus: No upgrade log present (probably fresh install)

[fcole90 (fcole90)]

The fix is a oneliner:
https://github.com/PhotoFilmStrip/PFS/pull/64/commits/42ad75a604f4075a0797f78962f7a9b9ff2b5e87

[Gunnar Hjalmarsson (gunnarhj)]

I uploaded the fix to the focal SRU queue. To fix it for yourself in the meantime:

cd /usr/lib/python3/dist-packages/photofilmstrip/action
sudo sed -r -i 's/(lang\.install\()True/\1/' ActionI18N.py

[Brian Murray (brian-murray)]

Hello fcole90, or anyone else affected,

Accepted photofilmstrip into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/photofilmstrip/3.7.2-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Gunnar Hjalmarsson (gunnarhj)]

Successfully carried out the steps in the test plan using photofilmstrip 3.7.2-1ubuntu0.1 from focal-proposed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package photofilmstrip - 3.7.2-1ubuntu0.1

---------------
photofilmstrip (3.7.2-1ubuntu0.1) focal; urgency=medium

  * d/p/lang.install-does-not-need-unicode-flag-anymore.patch:
    - Fixes crash at startup (LP: #1871402)

 -- Gunnar Hjalmarsson <email address hidden> Fri, 03 Sep 2021 18:22:47 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for photofilmstrip has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.