Test suite integration with system package manager is broken

[aidanjt]

Automatic installation of system dependancies doesn't work. I'm prompted for a password and the installation silently fails. As seen here:

aidan@ubibox ~ $ phoronix-test-suite benchmark pts/dbench

The following dependencies are needed and will be installed:

- autoconf
- libpopt-dev

This process may take several minutes.
[sudo] password for aidan:
sudo: aptitude -y install autoconf libpopt-dev: command not found

There are dependencies still missing from the system:
- Autoconf
- Popt

1: Ignore missing dependencies and proceed with installation.
2: Skip installing the tests with missing dependencies.
3: Re-attempt to install the missing dependencies.
4: Quit the current Phoronix Test Suite process.

Missing dependencies action: 4

-------------

The problem is in /usr/share/phoronix-test-suite/pts-core/external-test-dependencies/scripts/install-ubuntu-packages.sh, superfluous syntax.. so I just went ahead and stripped it out, removed a pointless else in the first if, too:

--- install-ubuntu-packages.sh.old 2012-03-31 08:40:43.299549961 +0100
+++ install-ubuntu-packages.sh 2012-03-31 08:45:09.699564796 +0100
@@ -1,4 +1,5 @@
 #!/bin/sh
+
 if [ `whoami` != "root" ]; then
        if [ -x /usr/bin/gksudo ] && [ ! -z "$DISPLAY" ]; then
                ROOT="/usr/bin/gksudo"
@@ -7,15 +8,13 @@
        elif [ -x /usr/bin/sudo ]; then
                ROOT="/usr/bin/sudo"
        fi
-else
- su -c "apt-get -y install $*"
- exit
 fi

 if [ -x /usr/bin/aptitude ]; then
        # aptitude is nice since it doesn't fail if a non-existant package is hit
        # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
- $ROOT -- "aptitude -y install $*"
+ $ROOT aptitude -y install $*
 else
- $ROOT -- "apt-get -y --ignore-missing install $*"
+ $ROOT apt-get -y --ignore-missing install $*
 fi
+

---------

Tested, works fine.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: phoronix-test-suite 3.6.1-1
ProcVersionSignature: Ubuntu 3.2.0-20.33-generic 3.2.12
Uname: Linux 3.2.0-20-generic x86_64
ApportVersion: 1.95-0ubuntu1
Architecture: amd64
Date: Sat Mar 31 08:03:25 2012
InstallationMedia: Ubuntu-Server 12.04 LTS "Precise Pangolin" - Beta amd64 (20120327)
PackageArchitecture: all
ProcEnviron:
 TERM=xterm
 SHELL=/bin/bash
 LANG=en_IE.UTF-8
 LANGUAGE=en_IE:en
SourcePackage: phoronix-test-suite
UpgradeStatus: No upgrade log present (probably fresh install)

[michaellarabel (michael-michaellarabel)]

aidanjt: Running without any X Server I imagine? There was a known bug with it due to gksudo vs. sudo differences. IIRC, your patch now allows the installer to work when not using X, but then if gksudo is used it will break. It was being pesky, I think I changed it around in the released Phoronix Test Suite 3.8 from March.

[aidanjt (aidanjt)]

michaellarabel: Yup. It was a headless box. I'll take a look at the
gksudo case later, unless you want to tackle it yourself.

On 10 April 2012 00:22, michaellarabel <email address hidden> wrote:
> aidanjt: Running without any X Server I imagine? There was a known bug
> with it due to gksudo vs. sudo differences. IIRC, your patch now allows
> the installer to work when not using X, but then if gksudo is used it
> will break. It was being pesky, I think I changed it around in the
> released Phoronix Test Suite 3.8 from March.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/969846
>
> Title:
>  Test suite integration with system package manager is broken
>
> Status in “phoronix-test-suite” package in Ubuntu:
>  New
>
> Bug description:
>  Automatic installation of system dependancies doesn't work.  I'm
>  prompted for a password and the installation silently fails.  As seen
>  here:
>
>  aidan@ubibox ~ $ phoronix-test-suite benchmark pts/dbench
>
>  The following dependencies are needed and will be installed:
>
>  - autoconf
>  - libpopt-dev
>
>  This process may take several minutes.
>  [sudo] password for aidan:
>  sudo: aptitude -y install autoconf libpopt-dev: command not found
>
>  There are dependencies still missing from the system:
>  - Autoconf
>  - Popt
>
>  1: Ignore missing dependencies and proceed with installation.
>  2: Skip installing the tests with missing dependencies.
>  3: Re-attempt to install the missing dependencies.
>  4: Quit the current Phoronix Test Suite process.
>
>  Missing dependencies action: 4
>
>  -------------
>
>  The problem is in /usr/share/phoronix-test-suite/pts-core/external-
>  test-dependencies/scripts/install-ubuntu-packages.sh, superfluous
>  syntax.. so I just went ahead and stripped it out, removed a pointless
>  else in the first if, too:
>
>  --- install-ubuntu-packages.sh.old      2012-03-31 08:40:43.299549961 +0100
>  +++ install-ubuntu-packages.sh  2012-03-31 08:45:09.699564796 +0100
>  @@ -1,4 +1,5 @@
>   #!/bin/sh
>  +
>   if [ `whoami` != "root" ]; then
>          if [ -x /usr/bin/gksudo ] && [ ! -z "$DISPLAY" ]; then
>                  ROOT="/usr/bin/gksudo"
>  @@ -7,15 +8,13 @@
>          elif [ -x /usr/bin/sudo ]; then
>                  ROOT="/usr/bin/sudo"
>          fi
>  -else
>  -       su -c "apt-get -y install $*"
>  -       exit
>   fi
>
>   if [ -x /usr/bin/aptitude ]; then
>          # aptitude is nice since it doesn't fail if a non-existant package is hit
>          # See: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503215
>  -       $ROOT -- "aptitude -y install $*"
>  +       $ROOT aptitude -y install $*
>   else
>  -       $ROOT -- "apt-get -y --ignore-missing install $*"
>  +       $ROOT apt-get -y --ignore-missing install $*
>   fi
>  +
>
>  ---------
>
>  Tested, works fine.
>
>  ProblemType: Bug
>  DistroRelease: Ubuntu 12.04
>  Package: phoronix-test-suite 3.6.1-1
>  ProcVersionSignature: Ubuntu 3.2.0-20.33-generic 3.2.12
>  Uname: Linux 3.2.0-20-generic x86_64
>  ApportVersion: 1.95-0ubuntu1
>  Architecture: amd64
>  Date: Sat Mar 31 08:03:25 2012
>  InstallationMedia: Ubuntu-Se...

[michaellarabel (michael-michaellarabel)]

If you can try the last patch in this thread it would be good: phoronix.com/forums/showthread.php?56881-BUG-Phoronix-fails-to-install-dependencies-on-Ubuntu-11-04 Thanks.