Phatch is unusable for specific themes

[Stani]

When the system menu highlight colour has the same value for red, green and blue, Phatch will fail to display the list of possible actions. As such no actions can be added and Phatch is unusable.

As reported by a user:
$ phatch
Traceback (most recent call last):
  File "/home/archie/bin/aur/phatch/pkg/usr/lib/python2.5/site-packages/phatch/pyWx/gui.py", line 401, in on_menu_edit_add
    title="%(name)s "%ct.INFO+_("actions"), )
  File "/home/archie/bin/aur/phatch/pkg/usr/lib/python2.5/site-packages/phatch/pyWx/dialogs.py", line 391, in __init__
    super(ActionDialog,self).__init__(parent,tags,*args,**keyw)
  File "/home/archie/bin/aur/phatch/pkg/usr/lib/python2.5/site-packages/phatch/pyWx/lib/vlistTag.py", line 62, in __init__
    self._create_controls(tags)
  File "/home/archie/bin/aur/phatch/pkg/usr/lib/python2.5/site-packages/phatch/pyWx/lib/vlistTag.py", line 67, in _create_controls
    self.browser= self.ContentBrowser(self, tags, {},style=wx.SUNKEN_BORDER)
  File "/home/archie/bin/aur/phatch/pkg/usr/lib/python2.5/site-packages/phatch/pyWx/lib/tag.py", line 66, in __init__
    self._create_controls(tags,content_ctrl_keyw)
  File "/home/archie/bin/aur/phatch/pkg/usr/lib/python2.5/site-packages/phatch/pyWx/lib/tag.py", line 86, in _create_controls
    self.content = self.ContentCtrl(self,**content_ctrl_keyw)
  File "/home/archie/bin/aur/phatch/pkg/usr/lib/python2.5/site-packages/phatch/pyWx/lib/vlist.py", line 28, in __init__
    self.SetTheme('default')
  File "/home/archie/bin/aur/phatch/pkg/usr/lib/python2.5/site-packages/phatch/pyWx/lib/vlist.py", line 65, in SetTheme
    self._color_from = self.GradientColour(hilight)
  File "/home/archie/bin/aur/phatch/pkg/usr/lib/python2.5/site-packages/phatch/pyWx/lib/vlist.py", line 41, in GradientColour
    n = max([x for x in rgb if x!=m])
ValueError: max() arg is an empty sequence

[Stani (stani)]

This patch fixes the bug.

[Stani (stani)]

Can someone upload the patch attached to this bug report?

[Launchpad Janitor (janitor)]

This bug was fixed in the package phatch - 0.1.3-1ubuntu1

---------------
phatch (0.1.3-1ubuntu1) hardy; urgency=low

  * debian/patches/from_upstream_fix_themes.patch:
    - Fix phatch when using some themes. LP: #214539.
  * debian/rules:
    - Include simple-patchsys
  * Modify Maintainer value to match the DebianMaintainerField
    specification.

 -- Emilio Pozuelo Monfort <email address hidden> Wed, 09 Apr 2008 13:49:55 +0200

[Arthur Archnix (arthur-archnix)]

Hi... came across the problem while on Gutsy, using phatch 0.1.3 downloaded from the website. Bug still exists, but thanks to tips here I just upped the value on red in my selected items colour and all was well.

[Stani (stani)]

@Arthur
You are right on this, as the downloads from the website were built before this bugfix. I plan to release Phatch 0.1.4 but the rosetta translations have introduced some new bugs which I want to fix for that release as well.