pgadmin3 has ugly icon

[Morten Kjeldgaard]

Pgadmin3's icon sticks out as flat and ugly when installed in KDE's taskbar. The attached patch improves it a tiny bit by removing the black lines, but the icon still appears as a blob of blue and white.

[Jan Nekvasil (jan-nekvasil)]

pgadmin3 1.8.4-3, Jaunty, still the same ugly icon. I think we can use official PostgreSQL svg logo (http://upload.wikimedia.org/wikipedia/commons/2/29/Postgresql_elephant.svg) - it looks surprisingly well even in small sizes, no modifications needed.

[David Siegel (djsiegel-deactivatedaccount)]

This does not affect the default Ubuntu experience, so it is not a paper cut.

[Greg Rundlett (greg.rundlett)]

note: to use the svg from Wikipedia, right-click the link and choose "File->save as". Then you will have the svg file. For display purposes, Wikipedia renders the svg into a png file.

[Jan Nekvasil (jan-nekvasil)]

pgadmin3 1.10.0-1, Karmic Beta here. Why it seems like nobody cares about poor little pgadmin3 icon? Everything what is actually needed is to put that .svg file from Wikipedia to /usr/share/pixmaps/pgadmin3.svg. It's just THAT simple.

Oh, dear heavens. If only every bug was that easy to fix and no bug was suffered that lack of interest like this one. This really makes me a sad blue elephant.

[Jan Nekvasil (jan-nekvasil)]

Lucid alpha 2 here, still the same old ugly icon. See attached image for the amazing default old-school user experience vs. dull svg smoothness in GNOME Do.

[Antoine Leclair (antoineleclair)]

I used the SVG icon from Wikipedia.

[Fabrice Coutadeur (fabricesp)]

Hi,

The copyright owner of this file should be mentioned in the debian/copyright file, as it's not under the general postgresql license.

Thanks,
Fabrice

[Antoine Leclair (antoineleclair)]

I hope I got this right this time ;).

[Fabrice Coutadeur (fabricesp)]

Hi,

It's almost there :-D

You should add you copyright info to the existing pgadmin3-data.copyright and not create a new one.

In you changelog entry, you should clearly mention the file you're changing. For example:
- debian/pgadmin3.svg: added
- debian/pgadmin3.install: changed to install pgadmin3.svg instead of pgadmin3.xpm
...

Also, I don't think it's necessary to delete the old icon: please keep it. This will make the diff with Debian will be maller.

Thanks!

Fabrice

[Antoine Leclair (antoineleclair)]

I'll be a pro someday ;) Thank you for your help Fabrice.

[Fabrice Coutadeur (fabricesp)]

Uploaded. Thanks for your work!

Before uploading your change, I updated debian/control maintainer field (you can do it by running the update-maintainer script) and changed a bit the entry in copyright file to make clearer the copyrighted file.

Could you also report the change we made to Debian, with submittodebian for example, so that we don't have to manually update the package each time it got updated there?

Thanks again,
Fabrice

[Launchpad Janitor (janitor)]

This bug was fixed in the package pgadmin3 - 1.10.1-1ubuntu1

---------------
pgadmin3 (1.10.1-1ubuntu1) lucid; urgency=low

  * Changed icon for a better one (LP: #347256):
    - debian/pgadmin3.svg: added.
    - debian/pgadmin3.install: changed to install pgadmin3.svg instead of
      pgadmin3.xpm.
    - debian/pgadmin3-data.copyright: appended the copyright info of the icon.
 -- Antoine Leclair <email address hidden> Thu, 11 Feb 2010 09:39:53 -0500

[Antoine Leclair (antoineleclair)]

Nice, thanks Fabrice.

I fetched your updated version of the .debdiff and sent it to debian with submittodebian.

[Jan Nekvasil (jan-nekvasil)]

Thank you guys, you are awesome.

[Rhonda D'Vine (rhonda)]

   Hi!

 First of all - thanks for working on the issue. Though, there are some things that are itching me:

a.) Thanks for not forwarding the issue to the Debian maintainers of the package - the issue could have been resolved since almost a year now.

b.) I hope you are aware that you have broken the debian menu system with that patch by not installing the menu xpm file which is referenced in the debian/menu file.

 It would be really helpful if changes like these could get discussed with the actual maintainers for the package to find a solution that fits and doesn't break stuff.

 Thanks,
Rhonda

[Fabrice Coutadeur (fabricesp)]

Hi,

Please open a new bug report to report the broken menu file

Closing again this one

Fabrice