Extra slash added to URL for staging
Bug #1346396 reported by
dobey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pay-service (Ubuntu) |
Fix Released
|
Critical
|
dobey | ||
Bug Description
When setting PAY_BASE_URL in the environment to point pay-service at the staging server, an extra slash is added to the URL path, which causes the server to treat the OAuth signature as invalid, leading to purchased apps appearing as not purchased. The currently implementation also requires the root API endpoint path, which is not consistent with the variable name.
Related branches
lp:~dobey/pay-service/base-url-is-base
- PS Jenkins bot (community): Approve (continuous-integration)
- Ted Gould (community): Approve
-
Diff: 113 lines (+42/-10)4 files modifiedservice/verification-curl.cpp (+13/-9)
service/verification-curl.h (+9/-0)
tests/setup-staging.sh (+1/-1)
tests/verification-curl-tests.cpp (+19/-0)
lp:~dobey/pay-ui/base-url-is-base
- PS Jenkins bot (community): Approve (continuous-integration)
- Diego Sarmentero (community): Approve
-
Diff: 156 lines (+22/-16)3 files modifiedbackend/modules/payui/network.cpp (+7/-5)
backend/modules/payui/network.h (+4/-0)
backend/tests/test_network.cpp (+11/-11)
Revision history for this message
| dobey (dobey) wrote | #1 |
| Changed in pay-ui: | |
| status: | New → In Progress |
| importance: | Undecided → Critical |
| assignee: | nobody → Rodney Dawes (dobey) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in pay-service (Ubuntu): | |
| status: | In Progress → Fix Released |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in pay-ui: | |
| status: | In Progress → Fix Committed |
| Changed in pay-ui: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've added pay-ui to this bug, as it and pay-service are inconsistent with how they parse the same environment variable.