Misleading error-message if not enough diskspace for the choosen expert-recipe

[Rorschach]

Binary package hint: partman-auto

There is a misleading error-message in partman-auto. When you choose an expert-recipe and the available diskspace is smaller than what you have configured in the recipe you get such an error-message:

"Expert recipe too large (24012 > 21000); skipping"

Well the first thing I thought after reading this message was that my recipe is too large. The recipe can be provided in one logical line and I thought that line and thus my recipe would be too large... Just because I couldn't fix this error from happening after shortening my recipe and taking a look at the sourcecode I realized what this message is really trying to tell me.

What this error-message really wants to tell someone is that your available diskspace is too small to satisfy the choosen recipe.

I think such a message would be better:

Available diskspace (21000) is too small for the planned partitioning (24012); skipping"

Patch is attached.

Update:
Oh because I forgot to mention. This was noticed on ubuntu jaunty 9.04.

[Colin Watson (cjwatson)]

Thanks; I've committed a similar change upstream for partman-auto 90.

[Launchpad Janitor (janitor)]

This bug was fixed in the package partman-auto - 91ubuntu1

---------------
partman-auto (91ubuntu1) maverick; urgency=low

  * Resynchronise with Debian. Remaining changes:
    - Adjust default partition sizes for Ubuntu.
    - Accept autopartitioning automatically rather than showing
      choose_partition.
    - Drop priority of partman-auto/choose_recipe question to medium.
    - Offer resize_use_free autopartitioning method, except on armel.
    - Add support for partman-auto/method=loop via partman-auto-loop.
    - Drop the bootable flag from i386/amd64 recipes; it can break existing
      Windows installations when autopartitioning only free space rather
      than a whole disk.
    - Make biggest_free respect the selection made in partman-auto/disk.
    - Exclude devices containing the installation medium from automatic
      partitioning.
    - Add armel/dove recipes.
    - Use new get_real_resize_range function from partman-partitioning
      72ubuntu3, which caches calls to tune2fs and ntfsresize.

partman-auto (91) unstable; urgency=low

  * Fix $iflabel{ } logic to avoid including the partition anyway if the
    current directory is not a subdirectory of /var/lib/partman/devices.
    This caused automatic LVM partitioning to be calculated with a biosgrub
    partition regardless of the disk label type, although as it happened
    this cancelled out with another bug so that partition would never
    actually be written to disk (LP: #538536).
  * Run clean_method before starting autopartitioning instead of in the
    middle of performing a recipe, and call autopartition just once for
    multi-disk partitioning. This means that methods applied to partitions
    of physical disks in RAID recipes are applied to all disks rather than
    just the last one (LP: #566965).

  [ Updated translations ]
  * Asturian (ast.po) by astur
  * Danish (da.po) by Jacob Sparre Andersen
  * German (de.po) by Holger Wansing
  * French (fr.po) by Christian Perrier
  * Hebrew (he.po) by Omer Zak
  * Korean (ko.po) by Changwoo Ryu
  * Lithuanian (lt.po) by Kęstutis Biliūnas
  * Norwegian Nynorsk (nn.po) by Eirik U. Birkeland
  * Slovenian (sl.po) by Vanja Cvelbar
  * Tamil (ta.po) by Dr,T,Vasudevan

partman-auto (90) unstable; urgency=low

  [ Colin Watson ]
  * Merge from Ubuntu:
    - Remove explicit $primary{ } specifiers from standard recipes. We only
      need them to be primary if no other primary partitions exist already.
  * Change expert recipe error message to focus on the available disk space
    being too small, not the recipe being too large (idea from "Rorschach",
    LP: #415488).

  [ Frans Pop ]
  * Remove no longer needed Lintian override for missing Standards-Version
    field.
  * After choosing "biggest free" option followed by backing up from the recipe
    dialog, don't exit to main menu but return to initial partman-auto dialog.

  [ Updated translations ]
  * Belarusian (be.po) by Pavel Piatruk
  * German (de.po) by Holger Wansing
  * Galician (gl.po) by Marce Villarino
  * Italian (it.po) by Milo Casagrande
  * Slovenian (sl.po) by Vanja Cvelbar
  * Thai (th.po) by Theppitak Karoonboonyanan
  * Simplified Chinese (zh_CN.po) b...