Fix crash when clicking cancel button, which may cause data loss

Bug #1715576 reported by Rik Mills on 2017-09-07
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
partitionmanager (Ubuntu)
Critical
Simon Quigley
Xenial
Critical
Simon Quigley
Zesty
Critical
Unassigned

Bug Description

[Impact]
Without these fixes, partitionmanager can cause severe data loss (in the KDE bug linked, someone lost an 890 GB LUKS partition.

[Test Case]
Try moving a partition and then pressing Cancel while it is running. It should display a dialog box asking if that is, in fact, what you would like to do, but instead it will crash, corrupting data.

[Regression Potential]
While extremely unlikely, a regression could occur when another framework (that this depends on) is updated, and that could cause the dialog box to not function as intended, possibly circumventing this. Like I wrote earlier, this is extremely unlikely, but it is still a possibility.

[Original Description]
Upstream bug: https://bugs.kde.org/show_bug.cgi?id=384348

Severity High or Critical, as can cause data loss.

Fixed in version 3.1.2 with commit:

https://cgit.kde.org/partitionmanager.git/commit/?id=feb2e374e496c65011e036f2a611fa7cc5b4e940

Affected versions and releases:

3.0.0-1 in Zesty 17.04
1.2.1-0ubuntu1 in Xenial 16.04

Cause is as error in the porting to Qt5/KF5, so the commit should be backportable as indicated by the upstream maintainer.

However, contrary to commit bf38d67e1bef0e8901b6fff75a1f968f6985c4ae which states the post version 3.0.0 version bump is for intended for implementing new features, again upstream confirmed that these did not actually happen and changes 3.0.0 -> 3.1.2 are just bugfixes.

Rik Mills (rikmills) on 2017-09-07
Changed in partitionmanager (Ubuntu Xenial):
importance: Undecided → Critical
Changed in partitionmanager (Ubuntu Zesty):
importance: Undecided → Critical
Rik Mills (rikmills) on 2017-09-07
Changed in partitionmanager (Ubuntu):
assignee: nobody → Simon Quigley (tsimonq2)
Changed in partitionmanager (Ubuntu Xenial):
assignee: nobody → Simon Quigley (tsimonq2)
Changed in partitionmanager (Ubuntu Zesty):
assignee: nobody → Simon Quigley (tsimonq2)
Changed in partitionmanager (Ubuntu):
status: New → Fix Committed
Simon Quigley (tsimonq2) on 2017-09-16
Changed in partitionmanager (Ubuntu Zesty):
status: New → Confirmed
Simon Quigley (tsimonq2) wrote :

Uploaded to Xenial.

Changed in partitionmanager (Ubuntu Xenial):
status: New → Confirmed
status: Confirmed → Fix Committed
Simon Quigley (tsimonq2) wrote :

Uploaded to Zesty.

Changed in partitionmanager (Ubuntu Zesty):
status: Confirmed → Fix Committed
description: updated
Simon Quigley (tsimonq2) wrote :

This is fixed in Artful already.

Changed in partitionmanager (Ubuntu):
status: Fix Committed → Fix Released
importance: Undecided → Critical

Hello Rik, or anyone else affected,

Accepted partitionmanager into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/partitionmanager/3.0.0-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed verification-needed-zesty
Brian Murray (brian-murray) wrote :

Hello Rik, or anyone else affected,

Accepted partitionmanager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/partitionmanager/1.2.1-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed-xenial

The fix for this bug has been awaiting testing feedback in the -proposed repository for zesty for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
Steve Langasek (vorlon) wrote :

Ubuntu 17.04 has reached end of life. No further bugfixes will be applied to this version.

Changed in partitionmanager (Ubuntu Zesty):
status: Fix Committed → Won't Fix
Simon Quigley (tsimonq2) wrote :

Many apologies for not getting to this until now, I thought others had tested this at this point.

I tested this in a fresh Lubuntu 16.04 install. I installed 1.2.1-0ubuntu1 from xenial and I was able to reproduce the crash. But, after updating partitionmanager to 1.2.1-0ubuntu1.1 in xenial-proposed, I was unable to reproduce it, and instead of closing out the window and crashing, it waited for the operation to finish before closing the window.

Thanks.

tags: added: verification-done verification-done-xenial
removed: removal-candidate verification-needed verification-needed-xenial verification-needed-zesty
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package partitionmanager - 1.2.1-0ubuntu1.1

---------------
partitionmanager (1.2.1-0ubuntu1.1) xenial; urgency=critical

  * Fix crash when clicking cancel button, which may cause data loss
    (LP: #1715576)
    - fix-crash-when-cancelling.patch

 -- Simon Quigley <email address hidden> Sat, 16 Sep 2017 15:04:39 -0500

Changed in partitionmanager (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for partitionmanager has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Simon Quigley (tsimonq2) on 2018-02-09
Changed in partitionmanager (Ubuntu Zesty):
assignee: Simon Quigley (tsimonq2) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers