Partition Manager fails to see MMC/SD cards

[Matteo Croce]

Partition Manager fails to add SD cards /dev/mmcblk0 to the list of available devices

seems that the bug lies in scanDevices() in src/core/libparted.cpp:

 QFile partitions("/proc/partitions");
 if (partitions.open(QIODevice::ReadOnly))
 {
  QRegExp rxLine("\\s*(\\d+)\\s+(\\d+)\\s+(\\d+)\\s([^0-9]+)\\s+");

that regular expression gets the list of the partitions and remove the trailing numbers, so /dev/mmcblk0 becames /dev/mmcblk which isn't a valid device name

[quantumphaze (quantumphazor)]

Version: 1.0.3 (using KDE 4.5.3)
OS: Linux

Partition Manager fails to add SD cards /dev/mmcblk0 to the list of available devices

Reproducible: Always

Steps to Reproduce:
Insert SD card into a card reader.
Confirm that it's mapped to /dev/mmcblk0
Open Partition Manager and try to find it

Actual Results:
/dev/mmcblk0 is not presented in the list. Only /dev/sda and any other disks or USB drives connected at the time are visible.

Expected Results:
An entry for the /dev/mmcblk0 device allowing the user to modify the card's partitions

OS: Linux 2.6.35-ARCH x86_64

Lenovo ThinkPad SL500 using the built in card reader (not a USB one that presents cards as /dev/sdc, ect.)

lspci:
SD Host controller: Ricoh Co Ltd R5C822 SD/SDIO/MMC/MS/MSPro Host Adapter (rev 22)

/dev/mmcblk0 and /dev/mmcblk0p1 are still editable in command line tools

[AaronPeterson (alpeterson)]

Also in Kubuntu 11.04, very tough for me to create a dos boot disk to flash my firmware.

[Fathi Boudra (fboudra)]

bug is confirmed.

[Matteo Croce (teknoraver)]

Confirmed

seems that the bug lies in scanDevices() in src/core/libparted.cpp:

 QFile partitions("/proc/partitions");
 if (partitions.open(QIODevice::ReadOnly))
 {
  QRegExp rxLine("\\s*(\\d+)\\s+(\\d+)\\s+(\\d+)\\s([^0-9]+)\\s+");

that regular expression gets the list of the partitions and remove the trailing numbers, so /dev/mmcblk0 becames /dev/mmcblk which isn't a valid device name

[adaptee (adaptee)]

*** Bug 291008 has been marked as a duplicate of this bug. ***

[Matteo Croce (teknoraver)]

here is the fix

[Matteo Croce (teknoraver)]

Created attachment 73712
add mmcblk devices to the devices list

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "mmcblk.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Volker Lanz (vl-fidra)]

I just got up and maybe I'm not yet at the top of my code-reading-abilities, but would this regex cover devices with two-digit-numbers, e.g. mmcblk23?

[Matteo Croce (teknoraver)]

Sure, do you have more than 10 MMC card reader?
(In reply to comment #6)
> I just got up and maybe I'm not yet at the top of my code-reading-abilities,
> but would this regex cover devices with two-digit-numbers, e.g. mmcblk23?

[Volker Lanz (vl-fidra)]

Is that some kind of "640kb ought to be enough" trick question? ;-)

What's wrong with fixing the regex?

[Matteo Croce (teknoraver)]

Created attachment 73722
add mmcblk devices to the devices list

[Matteo Croce (teknoraver)]

add mmcblk devices to the devices list (this patch supports more than 10 MMC devices)

[Matteo Croce (teknoraver)]

Anyone can please include this patch?

[Andrius Štikonas (stikonas)]

*** Bug 311194 has been marked as a duplicate of this bug. ***

[Andrius Štikonas (stikonas)]

SVN commit 1327786 by stikonas:

Fix detection of memory cards.

 M +4 -2 plugins/libparted/libpartedbackend.cpp
 M +1 -1 util/helpers.cpp

WebSVN link: http://websvn.kde.org/?view=rev&revision=1327786

[Andrius Štikonas (stikonas)]

Partition Manager does not number partitions on memory card correctly.
Devices are numbered /dev/mmcblk0 but partitions are numbered /dev/mmcblk0p1.
Partitionmanager fails to add 'p' before partition number.

[Andrius Štikonas (stikonas)]

SVN commit 1337488 by stikonas:

Fix detection of partitions' paths.

Previously, partition number was added to device path.
However, there are devices with more complicated numbering scheme,
e.g. memory cards may have /dev/mmcblk0p1.
It seems that the easiest way to handle this is to use partition
path instead of device path + partition number .

 M +1 -1 backend/corebackendpartitiontable.h
 M +23 -10 core/partition.cpp
 M +6 -2 core/partition.h
 M +1 -1 core/partitiontable.cpp
 M +1 -1 gui/infopane.cpp
 M +1 -1 gui/mainwindow.cpp
 M +3 -3 jobs/createpartitionjob.cpp
 M +2 -2 ops/copyoperation.cpp
 M +1 -1 ops/newoperation.cpp
 M +2 -2 ops/restoreoperation.cpp
 M +2 -2 plugins/dummy/dummypartitiontable.cpp
 M +1 -1 plugins/dummy/dummypartitiontable.h
 M +2 -2 plugins/libparted/libpartedbackend.cpp
 M +6 -6 plugins/libparted/libpartedpartitiontable.cpp
 M +1 -1 plugins/libparted/libpartedpartitiontable.h

WebSVN link: http://websvn.kde.org/?view=rev&revision=1337488

[Volker Lanz (vl-fidra)]

*** Bug 316056 has been marked as a duplicate of this bug. ***