partimaged refuse clients connections (socket CLOSE_WAIT nerver ends)

[NVieville]

Binary package hint: partimage

Hello,

After constating this symptom: http://groups.google.com/group/linux.debian.bugs.dist/browse_thread/thread/c6ff02ec8fa54778 (bug#491081 in linux.debian.bugs.dist) on last partimage-server-0.6.7-1 package on Ubuntu Hardy 8.04.1 LTS (description file is partimage_0.6.7-1.dsc), disabling the ability of partimaged to respond on client's requests once the MAX_CLIENT was reached, I've search for a workaround.

I can propose the patch joined. This one seems to work correctly on one of the server I'm on charge under Fedora. This patch was also proposed to the maintainer of this software for Fedora. I also use ubuntu machines to store disks images via partimage-server. So, I would be glad if this package should be updated.
I'm not a specialist in packaging, nor in developing software, so the best I can do is to submit a patch.

To help to generated a new package (I hope that it will be back-ported to Hardy), I can provide this little description written in trying to respect changelog files rules :

  * Partimaged - added patch to fix bug #491081 in linux.debian.bugs.dist
    - Fix/workaround CLOSE_WAIT bug on socket since patch that introduced
      fork in main loop.
    - Added -n commutator to specify the number of MAX_CLIENT desired on
      command line.
    - modified files:
      - /src/server/netserver.cpp
      - /src/server/netserver.h
      - /src/server/partimaged-client.cpp
      - /src/server/partimaged-client.h
      - /src/server/partimaged.cpp
      - /src/server/partimaged-gui_newt.cpp
      - /src/server/partimaged-gui_newt.h
      - /src/server/partimaged.h
      - /src/server/partimaged-main.cpp
      - /src/shared/structures.h
     All these modifications are propositions and should not be considered
     as strong fixes/additions before Guru's validations.

 -- Nicolas Viéville <email address hidden> Tue, 16 Dec 2008 18:10:07 +0100

I hope this could help and be useful.

Regards,

--
Nicolas Viéville

[NVieville (nicolas-vieville)]

Hello,

Sorry, but the patch supplied in my first post introduced a new bug (infinite loop in catch_sigchild function in partimaged-main.cpp). This new one fix it and add more Debug messages to the server side of partimage.
This new patch replace the first one which mustn't be used anymore.

Apologies for the first buggy patch.

--
Nicolas Viéville

[NVieville (nicolas-vieville)]

Hello,

I wonder if it would be possible to build partimage and partimage-server packages for last actives Ubuntu distributions from the last sources of this software (0.6.9 of 2010-07-25 here http://www.partimage.org/Download) which includes all the patches needed to make the server really useful.

Thanks in advance.

Cordially,

--
NVieville

[NVieville (nicolas-vieville)]

Fedora upgraded to partimage 0.6.9 on Sun Dec 05 2010.