parted crashes with invalid pointer on resizepart

[Marcus Furlong]

[Impact]

Parted is crashing (core dumping) during resize operation, while changing the end position of a partition.

[Test Case]

root@ubuntu-focal:~# parted /dev/sda resizepart 1 100%
Warning: Partition /dev/sda1 is being used. Are you sure you want to continue?
Yes/No? yes
End? [42.9GB]?
free(): invalid pointer
Aborted (core dumped)

[Where problems could occur]

As per resize documentation:
"Note that this does not modify any filesystem present in the partition."
"When growing a partition you will want to grow the filesystem afterwards"

FS-wise the resize operation won't try to take action on the FS itself. It would need to be done by the admin as a separate step.

If any problem arise, it will be limited to the resize functionality of parted. In this case, the impact would be ~ similar to the actual parted state (before this SRU), and one won't be able to resize as requested.

[Other Info]

https://git.savannah.gnu.org/cgit/parted.git/commit/?id=ca845aeeddb17343c9289816833ca352f7c0d87b

# Upstream repo:

git describe --tags ca845ae
v3.3-5-gca845ae

# Ubuntu
$ rmadison parted

 parted | 3.2-15ubuntu0.1 | xenial-updates
 parted | 3.2-20ubuntu0.2 | bionic-updates
 parted | 3.3-4 | focal
 parted | 3.3-4 | groovy
 parted | 3.3-4 | hirsute

[Original Description]
parted crashes with invalid pointer on resizepart on focal

root@ubuntu-focal:~# parted /dev/sda resizepart 1 100%
Warning: Partition /dev/sda1 is being used. Are you sure you want to continue?
Yes/No? yes
End? [42.9GB]?
free(): invalid pointer
Aborted (core dumped)

Discussion: https://<email address hidden>/msg04962.html

Fix: https://github.com/bcl/parted/commit/883813c365482d06d05a1998e066792c48156f23

[Eric Desrochers (slashd)]

[sts-sponsors]

Uploaded in active development release (hirsute).
I'll go ahead with the SRU once the package is foundin hirsute-releases.

- Eric

[Launchpad Janitor (janitor)]

This bug was fixed in the package parted - 3.3-4ubuntu1

---------------
parted (3.3-4ubuntu1) hirsute; urgency=medium

  * d/p/fix-end-input-usage-in-do-resizepart.patch:
    - Fix end_input usage in do_resizepart (LP: #1905579)

 -- Eric Desrochers <email address hidden> Mon, 30 Nov 2020 12:44:29 -0500

[Eric Desrochers (slashd)]

Xenial and Bionic doesn't have such end_input pointer in do_resizepart().

[Eric Desrochers (slashd)]

[sts-sponsors]

Uplaoded in Groovy and Focal. It is now waiting for the SRU team to approve the upload for the package to start building in -proposed to officially start the testing phase.

- Eric

[Brian Murray (brian-murray)]

Hello Marcus, or anyone else affected,

Accepted parted into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/parted/3.3-4ubuntu0.20.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Marcus, or anyone else affected,

Accepted parted into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/parted/3.3-4ubuntu0.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Eric Desrochers (slashd)]

[VERIFICATION GROOVY]

I have tested with the package currently found in groovy-proposed, and I confirmed the package '3.3-4ubuntu0.20.10.1' fixes the free() invalid pointer problem during a resize partition operation.

[Eric Desrochers (slashd)]

[VERIFICATION FOCAL]

I have tested with the package currently found in focal-proposed, and I confirmed the package '3.3-4ubuntu0.20.04.1' fixes the free() invalid pointer problem during a resize partition operation.

[Marcus Furlong (furlongm)]

Confirmed that it fixed the issue on focal for me.

[Eric Desrochers (slashd)]

Thanks, Marcus, for your time testing the 'parted' proposed package in focal.

- Eric

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for parted has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package parted - 3.3-4ubuntu0.20.10.1

---------------
parted (3.3-4ubuntu0.20.10.1) groovy; urgency=medium

  * d/p/fix-end-input-usage-in-do-resizepart.patch:
    - Fix end_input usage in do_resizepart (LP: #1905579)

 -- Eric Desrochers <email address hidden> Tue, 01 Dec 2020 10:27:07 -0500

[Launchpad Janitor (janitor)]

This bug was fixed in the package parted - 3.3-4ubuntu0.20.04.1

---------------
parted (3.3-4ubuntu0.20.04.1) focal; urgency=medium

  * d/p/fix-end-input-usage-in-do-resizepart.patch:
    - Fix end_input usage in do_resizepart (LP: #1905579)

 -- Eric Desrochers <email address hidden> Tue, 01 Dec 2020 10:18:05 -0500