installer does not display NVMe model strings

Bug #1798675 reported by dann frazier on 2018-10-18
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
parted (Debian)
Fix Released
Unknown
parted (Ubuntu)
Undecided
dann frazier
Bionic
Undecided
dann frazier
Cosmic
Undecided
dann frazier
Disco
Undecided
Unassigned

Bug Description

[Impact]
parted currently exposes the same generic model name for all NVMe devices. That can make it difficult to distinguish devices in your system, especially at install-time.

[Test Case]
When unfixed:
  # parted /dev/nvme0n1 -s print | grep Model
  Model: NVMe Device (nvme)
When fixed, you'll see the NVMe device model.

[Fix]
This is fixed upstream in the following commit, which applies to Debian's
package with only minor offset adjustments:

  279bd554 Read NVMe model names from sysfs

[Regression Risk]
The fix is coded to fallback to the generic name if no model string is found. If something is buggy with this patch, it could lead to installer crashes.

dann frazier (dannf) on 2018-10-18
Changed in parted (Ubuntu Bionic):
status: New → In Progress
assignee: nobody → dann frazier (dannf)

Hello dann, or anyone else affected,

Accepted parted into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/parted/3.2-21ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in parted (Ubuntu Cosmic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-cosmic
Brian Murray (brian-murray) wrote :

Hello dann, or anyone else affected,

Accepted parted into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/parted/3.2-20ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in parted (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
dann frazier (dannf) wrote :

cosmic verification:

ubuntu@d05-4:~$ sudo parted -s /dev/nvme0n1 -- print | grep Model
Model: Force MP300 (nvme)

tags: added: verification-done-cosmic
removed: verification-needed-cosmic
dann frazier (dannf) wrote :

bionic verification:

ubuntu@d05-4:~$ sudo parted -s /dev/nvme0n1 -- print | grep Model
Model: Force MP300 (nvme)

tags: added: verification-done-bionic
removed: verification-needed-bionic
tags: added: verification-done
removed: verification-needed

The verification of the Stable Release Update for parted has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package parted - 3.2-21ubuntu2

---------------
parted (3.2-21ubuntu2) cosmic; urgency=medium

  * debian/patches/Read-NVMe-model-names-from-sysfs.patch: Expose NVMe
    model names when available instead of the generic "NVMe Device"
    string. LP: #1798675.

 -- dann frazier <email address hidden> Thu, 18 Oct 2018 15:16:14 -0600

Changed in parted (Ubuntu Cosmic):
status: Fix Committed → Fix Released
Changed in parted (Ubuntu Disco):
status: New → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package parted - 3.2-20ubuntu0.1

---------------
parted (3.2-20ubuntu0.1) bionic; urgency=medium

  * debian/patches/Read-NVMe-model-names-from-sysfs.patch: Expose NVMe
    model names when available instead of the generic "NVMe Device"
    string. LP: #1798675.

 -- dann frazier <email address hidden> Thu, 18 Oct 2018 16:00:56 -0600

Changed in parted (Ubuntu Bionic):
status: Fix Committed → Fix Released
Changed in parted (Debian):
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.