[FFe, MIR] support $XDG_RUNTIME_DIR

Bug #894391 reported by Martin Pitt
52
This bug affects 13 people
Affects Status Importance Assigned to Milestone
mountall (Ubuntu)
Fix Released
High
Steve Langasek
Quantal
Fix Released
High
Steve Langasek
pam-xdg-support (Ubuntu)
Fix Released
Medium
Steve Langasek
Quantal
Fix Released
Undecided
Steve Langasek
Tags: ffe
Martin Pitt (pitti)
Changed in consolekit (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Canonical Desktop Team (canonical-desktop-team)
Martin Pitt (pitti)
Changed in consolekit (Ubuntu):
assignee: Canonical Desktop Team (canonical-desktop-team) → Martin Pitt (pitti)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Revision history for this message
Martin Pitt (pitti) wrote :

Unassigning while https://blueprints.launchpad.net/ubuntu/+spec/foundations-q-xdg-runtime-dir is being discussed (this might not even end up in CK)

Changed in consolekit (Ubuntu):
assignee: Martin Pitt (pitti) → nobody
Revision history for this message
Fred (eldmannen+launchpad) wrote :

XDG_RUNTIME_DIR not being set affects Weston.
See bug #1029223

Revision history for this message
Steve Langasek (vorlon) wrote :

step 1 is to get /run/user mounted by default.

Changed in mountall (Ubuntu Quantal):
status: New → Triaged
status: Triaged → In Progress
importance: Undecided → High
assignee: nobody → Steve Langasek (vorlon)
Steve Langasek (vorlon)
Changed in mountall (Ubuntu Quantal):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mountall - 2.40

---------------
mountall (2.40) unstable; urgency=low

  * Add /run/user as a default mountpoint, in support of $XDG_RUNTIME_DIR.
    LP: #894391.

mountall (2.39) unstable; urgency=low

  * Adjust parsing of device names so that network mounts pointing to the
    server's root don't have the path mis-normalized to the empty string.
    Thanks to Damien Churchill <email address hidden> for the initial
    implementation. LP: #809221.
  * Add compatibility jobs with names to match the historic sysvinit init
    scripts, so that startpar can DTRT.
 -- Steve Langasek <email address hidden> Fri, 31 Aug 2012 19:55:01 -0700

Changed in mountall (Ubuntu Quantal):
status: Fix Committed → Fix Released
Steve Langasek (vorlon)
affects: consolekit (Ubuntu Quantal) → Ubuntu Quantal
summary: - support $XDG_RUNTIME_DIR
+ [FFe] support $XDG_RUNTIME_DIR
Revision history for this message
Steve Langasek (vorlon) wrote : Re: [FFe] support $XDG_RUNTIME_DIR

I've just uploaded a new package, pam-xdg-support, to quantal and am seeking a FFe for it. This is a small module which handles the setup and teardown of the XDG_RUNTIME_DIR, addressing a long-standing bug report from the desktop team. It should be suitable for inclusion in the default PAM stack on the desktop.

The other options where this could have been implemented were pam_ck_connector and pam_systemd, but neither was suitable, hence the new package.

 - pam_ck_connector and pam_systemd are both designed to be used for login sessions only. That's insufficient for XDG_RUNTIME_DIR, which needs to be updated each time there's a user context change (e.g., sudo/su) because the pointed-to directory is, by definition, only writable by the owning user.
 - pam_systemd depends on systemd logind for the directory management, and logind is deeply intertwined with the systemd-specific cgroups layout which we do not want to adopt at this time.

The pam module is short (320 loc) and I hope sufficiently auditable that it can be included in quantal.

Revision history for this message
Fred (eldmannen+launchpad) wrote :

FFe apparently means FeatureFreeze Exception, I didn't know that.
Just in case anyone is wondering.

I hope we can get a FFe for this package.

Until then, is the package available in any PPA or anywhere?

Revision history for this message
Sebastien Bacher (seb128) wrote :

The desktop team would like to see that FFe considered for quantal, without it libdconf (our default library to handle desktop settings) is sometimes hitting a SIGBUS for ecryptfs,nfs users (the most reported issue on nautilus during the precise cycle was due to that).

tags: added: ffe
Revision history for this message
Adam Conrad (adconrad) wrote :

Approving the FFe itself, pending the usual NEW review and audit process.

Matthias Klose (doko)
affects: Ubuntu Quantal → pam-xdg-support (Ubuntu Quantal)
Changed in pam-xdg-support (Ubuntu Quantal):
status: In Progress → Fix Released
Revision history for this message
Fred (eldmannen+launchpad) wrote :

$ sudo apt-get install libpam-xdg-support

Revision history for this message
Fred (eldmannen+launchpad) wrote :

Just tried it and it works.
Weston now runs without any complaints.

Maybe this could be marked as a supported package?
Maybe this could be installed by default?

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

ACK from the security team, code looks good.

Steve Langasek (vorlon)
summary: - [FFe] support $XDG_RUNTIME_DIR
+ [FFe, MIR] support $XDG_RUNTIME_DIR
Revision history for this message
Michael Terry (mterry) wrote :

I'll give this a MIR lookover.

Revision history for this message
Michael Terry (mterry) wrote :

Nevermind, doko did that already. Whoops. :)

Revision history for this message
Matthias Klose (doko) wrote :

and promoted ...

Override component to main
pam-xdg-support 0.1-0ubuntu1 in quantal: universe/admin -> main
libpam-xdg-support 0.1-0ubuntu1 in quantal amd64: universe/admin/optional -> main
libpam-xdg-support 0.1-0ubuntu1 in quantal armel: universe/admin/optional -> main
libpam-xdg-support 0.1-0ubuntu1 in quantal armhf: universe/admin/optional -> main
libpam-xdg-support 0.1-0ubuntu1 in quantal i386: universe/admin/optional -> main
libpam-xdg-support 0.1-0ubuntu1 in quantal powerpc: universe/admin/optional -> main
6 publications overridden.

Revision history for this message
Darxus (darxus) wrote :

Is this going to be installed by default?

Revision history for this message
Darxus (darxus) wrote :

According to comments in bug 1058211, this will be installed by default as a dependency of ubuntu-desktop.

Revision history for this message
Darxus (darxus) wrote :

The ubuntu-desktop package in quantal now has a dependency on libpam-xdg-support, so everyone will get this by default.

Revision history for this message
Fred (eldmannen+launchpad) wrote :

XDG_CONFIG_HOME is not set tho.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers