CMake can't find QPackageKit by default

[Sveinung Kvilhaugsvik]

libpackagekit-qt-dev installs FindQPackageKit.cmake to /usr/share/cmake/Modules/FindQPackageKit.cmake where CMake (as it comes with Ubuntu) can't find it. The bug has been addressed in the branch ~kvilhaugsvik/packagekit/ubuntu-packagekit by moving it to /usr/share/cmake-2.6/Modules/.

To reproduce the bug try to build KPackageKit after removing its local copy of FindQPackageKit.cmake:
apt-get source kpackagekit
cd kpackagekit-0.4
rm cmake/modules/FindQPackageKit.cmake
dpkg-buildpackage

The regression potential from this fix: programs buildt that are searching for QPackageKit using CMake will now find it. This can cause different behavior from the resulting program than before. If the program being built contains bugs in features that only will get activated if QPackageKit can be found those would surface together with the feature.

[Sveinung Kvilhaugsvik (kvilhaugsvik)]

In case the correct solution to this simply is to install to /usr/share/cmake-2.6/Modules/ instead of /usr/share/cmake/Modules/ the fix is in the branch ~kvilhaugsvik/packagekit/ubuntu-packagekit

[Sebastian Heinlein (glatzor)]

Could some of the KDE developers comment on this? I am not familiar with cmake and its policies.

[Jonathan Thomas (echidnaman)]

This would be a correct fix.

[Sveinung Kvilhaugsvik (kvilhaugsvik)]

Sebastian: Does this mean that I now have an ack and can subscribe ubuntu-main-sponsors or should I do something else?

[Sveinung Kvilhaugsvik (kvilhaugsvik)]

Updated my bazaar branch containing the fix since another packagekit 0.3.14-0ubuntu5 was released and Jaunty already is out

[James Westby (james-w)]

Hi,

You don't need an ACK to subscribe the sponsors, as they will do
a review. I've subscribed them now.

I assume this is targeted at Jaunty? If so then it will now have
to follow the stable update procedures. You can find details on
this at

  https://wiki.ubuntu.com/StableReleaseUpdates

Thanks,

James

[Sveinung Kvilhaugsvik (kvilhaugsvik)]

James: Thank you for the clarification. I had actually retargeted it for karmic, but if you think this is serious enough to try to get a SRU I could give it a try.

[Sveinung Kvilhaugsvik (kvilhaugsvik)]

I think I'll try to get a SRU anyway since a project I want to add some patches that depends on QPackageKit too say having working versions in the distros increases my chances of getting it accepted. According to https://wiki.ubuntu.com/StableReleaseUpdates the fix must first be in the current development release. I'll continue when it's in.

[Sveinung Kvilhaugsvik (kvilhaugsvik)]

I was told on #ubuntu-devel that a SRU for this is unlikely, so I won't try a sru unless it gets more likely.

[Sveinung Kvilhaugsvik (kvilhaugsvik)]

Updated fix in branch lp:~kvilhaugsvik/packagekit/packagekit-karmic that also contains a fix for bug 378419

[Launchpad Janitor (janitor)]

This bug was fixed in the package packagekit - 0.4.9+20090825-0ubuntu1

---------------
packagekit (0.4.9+20090825-0ubuntu1) karmic; urgency=low

  * New upstream snapshot provding a lot of APT backend improvements:
    - Allow to install updates which require the installation of additional
      packages. Updates depending on the removal of a package are still
      blocked (LP: #342671, LP: #374011, LP: #374011)
    - Warn about the installation of untrusted package (LP: #256245)
    - Don't crash in APT post update hook if system D-Bus daemon isn't
      running (LP: #388623)
    - Don't try to estimate a download progress during cache updating, since
      APT reports only a forth- and backwards running progress. (LP: #348053)
    - Support for python-apt 0.7.12 (LP: #415993)
    - Translated package descriptions
  * debian/patches:
    - Remove ignore_packages_in_conffile (Merged upstream)
    - Remove fix_typo (Merged upstream)
    - Add fix_unicode: Handle the encoding messages via stdin/stdout correctly
      (LP: #396513)
    - Add fix_unicode_debfile: Convert the path of the local file which
      should be installed to the correct encoding (LP: #347327)
  * debian/libpackagekit-qt-dev.install: Fix install location of CMake module.
    Thanks to Sveinung Kvilhaugsvik (LP: #345706)
  * debian/control: Fix spelling of Qt. Thanks to Sveinung Kvilhaugsvik
    (LP: #378419)

 -- Sebastian Heinlein <email address hidden> Tue, 25 Aug 2009 13:03:26 +0200