[SRU] New upstream release ostree 2018.8

[Andrew Hayzen]

This is a request to SRU the latest release of ostree into bionic.

[Impact]

New upstream release of ostree, which brings fixes and improvements to the stable series.

Bionic is currently at 2018.4-2, whereas 2018.8 is available upstream.

Note this is a requirement for enabling the stable release of flatpak 1.0.

[Test Case]

The bugs being resolved are not simple to reproduce, see the test plan below for testing of ostree.

[Regression Potential]

OSTree has a test suite, which is run on build across all architectures and passes.

I am using the flatpak manual test plan, as this is the main "user" of libostree https://wiki.ubuntu.com/Process/Merges/TestPlan/flatpak. I have confirmed that 2018.8 passes with this test plan. I have also done exploratory testing of the ostree CLI.

OSTree has autopkgtests enabled http://autopkgtest.ubuntu.com/packages/o/ostree which is passing on bionic (except for armhf).

Regression potential is low, and upstream is responsive to any issues raised.

[Other Info]

The risk is low as the only "users" (rdepends of libostree-1-1 and ostree) are flatpak and debos.

Flatpak 1.0 SRU requires this change and therefore this should be submitted together with bug 1787917.

[Robie Basak (racb)]

Thank you for working on this.

Is there any reason you aren't landing a flatpak update at the same time, if that's the purpose of this SRU? I'm reluctant to review/accept one without the other, as that could lead to having to go through the SRU process multiple times if there happens to be a problem and we have to go round again because we didn't get -proposed with flatpak and ostree at once.

I suggest you test an update of both ostree and flatpak in a PPA somewhere before driving through half of this work.

If I'm missing something, please do bring it up. This isn't a final decision or anything; I'd just like to understand the reason for doing half first and have that documented here if that's how it's going to be.

[Andrew Hayzen (ahayzen)]

@Robie, thanks for looking at this.

So Flatpak 1.0 is currently under pre-release/release candidate, and should hopefully be released in the next few weeks (at some point after GUADEC). As you have pointed out it might be a good idea to submit them together - so that they can be tested together. I am happy to wait until flatpak 1.0 is ready and submit them both to -proposed at the same time if this is your preferred route.

Please advise if there is anything I need to do while we wait ? Can we just simply leave ostree in the queue ? (I suspect it'll only be a few weeks until flatpak 1.0 is ready).

Also I have a personal PPA with the pre-release of flatpak 1.0 and ostree 2018.6 which I have been testing with :-)

There is no particular reason for doing it either way, I was just submitting this in preparation of the future release - so if it makes testing/verification easier and reduces risk, lets do them together.

[Steve Langasek (vorlon)]

 307 files changed, 54628 insertions(+), 5795 deletions(-)

I'm taking "microrelease" out of the bug description. Some of this delta is to autogenerated files, but there are a lot of actual code changes here. Nothing "micro" about this in my view, it needs to be assessed in the context of a full upstream update.

The new version also adds a build-dependency on avahi, whose only explanation in the changelog is:

+ - Build-depend on Avahi libraries

This needs a more explicit rationale in the changelog and in this SRU bug.

[Andrew Hayzen (ahayzen)]

I've spoken with upstream, for bionic we should be able to use --without-avahi. This shouldn't have any adverse affect to flatpak or ostree other than disabling p2p networking and removes the additional build-depends. (I will test a build over the next few days in a PPA).

So the package in the queue should be rejected, as I will be creating a new diff - which I will submit together with the flatpak release as discussed.

[Steve Langasek (vorlon)]

An upload of ostree to bionic-proposed has been rejected from the upload queue for the following reason: "rejected per https://bugs.launchpad.net/ubuntu/+source/ostree/+bug/1778782/comments/4; package to be reuploaded with new diff".

[Andrew Hayzen (ahayzen)]

The 2018.6 release in Debian included new rust bindings, these were then removed in the next release - which has resulted in a smaller debdiff than before. I have also disabled avahi so there isn't a new build-depends.

I'm going to provisionally update the bug description to match the changes which will likely be submitted in a future upload.

[Łukasz Zemczak (sil2100)]

Hello Andrew, or anyone else affected,

Accepted ostree into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ostree/2018.8-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andrew Hayzen (ahayzen)]

I have run the (flatpak) test plan on a Bionic VM, which passed all relevant tests successfully - I have noted the version of ostree used below. I have done exploratory testing of the ostree CLI and all autopkgtests are passing. Therefore I am marking this as verification-done-bionic.

$ apt-cache policy ostree
ostree:
  Installed: 2018.8-0ubuntu0.1
  Candidate: 2018.8-0ubuntu0.1
  Version table:
 *** 2018.8-0ubuntu0.1 500
        500 http://gb.archive.ubuntu.com/ubuntu bionic-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     2018.4-2 500
        500 http://gb.archive.ubuntu.com/ubuntu bionic/universe amd64 Packages

[Launchpad Janitor (janitor)]

This bug was fixed in the package ostree - 2018.8-0ubuntu0.1

---------------
ostree (2018.8-0ubuntu0.1) bionic; urgency=medium

  * Update to 2018.8 (LP: #1778782)
  * New upstream release with support for peer-to-peer software
    collections, required by Flatpak's peer-to-peer app sharing feature
    - debian/copyright: Upstream clarified that only doc/ is CC-BY-SA-3.0 or
      GFDL-1.3-or-later, and doc/ isn't included in dist tarballs, so
      remove those licenses and update
    - debian/libostree-1-1.symbols: Update (and sort)
    - debian/ostree-boot.install: Add new systemd service
      lib/systemd/system/ostree-finalize-staged.service
    - debian/rules: Remove lib/systemd/system/ostree-finalize-staged.service
      until we build ostree-boot
    - debian/patches/Don-t-write-to-parent-repo.patch: Drop, applied upstream
  * debian/patches/debian/Skip-test-pull-repeated-during-CI.patch:
    Skip a test that is non-deterministic and can spuriously fail,
    which is not suitable for build-time testing or gating migration in
    autopkgtest.
  * debian/rules: Explicitly enable various desired libraries
  * debian/tests/gnome-desktop-testing: Skip libostree/test-concurrency.py.test
    during autopkgtest. It does not appear to be completely reliable.
    (See #901170)
  * ostree-tests: Add Lintian override for library-not-linked-against-libc.
    libreaddir-rand.so genuinely doesn't use any libc ABIs directly, only
    via GLib.

 -- Andrew Hayzen <email address hidden> Sun, 02 Sep 2018 01:35:01 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for ostree has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.