oss4/4.2-build2010-5ubuntu6~20.04.2 ADT test failure with linux-hwe-5.11/5.11.0-20.21~20.04.1

[Kleber Sacilotto de Souza]

[Impact]
oss4 dkms will fail to build on 5.11 kernels on focal, preventing users from using those modules on more recent kernels.

[Test case]
Install the package and make sure it builds.

[Fix]
Conditionally define a function that is not used on the Linux port when LICENSED_VERSION is undefined.

[Fix risk]
Licensed versions will fail to build, but we don't do those. Other ports should not fail as we only patch the Linux port.

[Potential regression]
The dkms package may still fail to build, install or load. Or sound might not work on systems that depend on oss4.

---------------------------------------------------------------
This is a scripted bug report about ADT failures while running oss4 tests for linux-hwe-5.11/5.11.0-20.21~20.04.1 on focal. Whether this is caused by the dep8 tests of the tested source or the kernel has yet to be determined.

Testing failed on:
    amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/o/oss4/20210611_210018_1dcc5@/log.gz

[Other]

NB! dkms ftbfs fixes must be built in security, such that after SRU process in -proposed & -updates it can be copied into -security pocket too.

[Thadeu Lima de Souza Cascardo (cascardo)]

get_seconds() is gone, as it returns a 32-bit, which will wrap either around 2038 or 2106. It is only used on Linux port of oss4 to determine whether a "license" is good. Just conditioning the definition of that to the macro LICENSED_VERSION should be good enough to let it build again. If anyone cares enough, one could use ktime_get_real_seconds(), or fix oss_license_handle_time(), which is not even present in the code we have.

Cascardo.

[Dimitri John Ledkov (xnox)]

Building in security only bileto ppa

$ dput ppa:ci-train-ppa-service/4601 oss4_4.2-build2010-5ubuntu6~20.04.3_source.changes
D: Splitting host argument out of ppa:ci-train-ppa-service/4601.
D: Setting host argument.
Checking signature on .changes
gpg: /tmp/oss4_4.2-build2010-5ubuntu6~20.04.3_source.changes: Valid signature from 9B8EC849D5EF70ED
Checking signature on .dsc
gpg: /tmp/oss4_4.2-build2010-5ubuntu6~20.04.3.dsc: Valid signature from 9B8EC849D5EF70ED
Uploading to ppa (via sftp to ppa.launchpad.net):
  Uploading oss4_4.2-build2010-5ubuntu6~20.04.3.dsc: done.
  Uploading oss4_4.2-build2010-5ubuntu6~20.04.3.debian.tar.xz: done.
  Uploading oss4_4.2-build2010-5ubuntu6~20.04.3_source.buildinfo: done.
  Uploading oss4_4.2-build2010-5ubuntu6~20.04.3_source.changes: done.
Successfully uploaded packages.

[Timo Aaltonen (tjaalton)]

Hello Kleber, or anyone else affected,

Accepted oss4 into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/oss4/4.2-build2010-5ubuntu6~20.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

Confirmed that oss4 4.2-build2010-5ubuntu6~20.04.3 autopkgtest is successful with focal/linux-hwe-5.11 5.11.0-24-generic:

https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/o/oss4/20210705_154753_c0c2e@/log.gz

While also still building successfully with focal/linux 5.4.0-79-generic:

https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/o/oss4/20210705_154758_18e1c@/log.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package oss4 - 4.2-build2010-5ubuntu6~20.04.3

---------------
oss4 (4.2-build2010-5ubuntu6~20.04.3) focal; urgency=medium

  * Fix build for Linux >= 5.11 (LP: #1932168):
    - do not define oss_get_time unless LICENSED_VERSION is defined.

 -- Thadeu Lima de Souza Cascardo <email address hidden> Wed, 23 Jun 2021 12:10:36 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for oss4 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.