Windows 10 is detected as Windows 8

[Amedee Van Gasse]

[Impact]

Windows 10 not detected corrected during or after installation]

[Test Case]

One possibility below. Another is to have Windows 10 already on eg pre-installed machine and installing Ubuntu on it.

[Regression Potential]

None, the patch is trivial if no typos slip through..

---

Steps to reproduce:
* Clean pc
* Install Windows 8.1, let it use the entire disk
* Dual boot installation Ubuntu 15.04.
* Verify that that Grub shows Windows 8 when booting up
* Verify that you can boot into Windows from the grub menu
* Verify that you can boot into Ubuntu from the grub menu
* Verify that os-prober detects "Windows 8 (loader)" on sda1
* Upgrade Windows 8.1 to Windows 10
* (Additional steps may be required to restore grub after Windows upgrade)
* Verify that you can boot into Windows 10 from the grub menu
* Verify that you can boot into Ubuntu from the grub menu
* Run os-prober

Expected result:
/dev/sda1:Windows 10 (loader):Windows:chain

Actual result:
/dev/sda1:Windows 8 (loader):Windows:chain

Ubuntu 15.04
os-prober 1.63ubuntu1

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[David Martin (dmartina)]

It is mostly cosmetic as everything seems to work fine, at least for me. This patch helped me with both Ubuntu 12.04 and 14.04.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "20microsoft-w10.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[psyray (psyray)]

Hi,

Patch is working fine.

thanks

[Mathieu Trudel-Lapierre (cyphermox)]

Sponsored earlier today; this is still in proposed waiting for autopkgtests to run/complete.

[Launchpad Janitor (janitor)]

This bug was fixed in the package os-prober - 1.63ubuntu2

---------------
os-prober (1.63ubuntu2) wily; urgency=medium

  * os-probes/mounted/x86/20microsoft:
    - add Windows 10 to the list (thanks for David Martin for the patch!)
      (LP: #1482851)
    - cherry-pick a change from Debian: use -a with grep in case the file
      isn't considered a text file.

 -- Mathieu Trudel-Lapierre <email address hidden> Mon, 21 Sep 2015 14:52:53 -0400

[Amedee Van Gasse (amedee)]

Would it also be possible to differentiate between Windows 8 and Windows 8.1? I know it's just cosmetic.

[Mathieu Trudel-Lapierre (cyphermox)]

It depends whether there is that differenciation in the bcd. I have neither, so it's a little hard for me to test this :)

[Silviu C. (silviucc)]

Could we please get this in Trusty as well?

[jokrebel (jokrebel)]

I had Ubuntu 14.04 LTS with Windows 7 in Dualboot.
After upgrade the Windows up to Windows 10 ist's the same here.
update-grub2 does no korrekt the (now) wrong "Windows 7"

[Timo Jyrinki (timo-jyrinki)]

I think this would be useful for Ubuntu 14.04.4 LTS point release.

[Mathieu Trudel-Lapierre (cyphermox)]

Reviewed this, I'll sponsor the SRU in a moment.

[Adam Conrad (adconrad)]

Hello Amedee, or anyone else affected,

Accepted os-prober into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/os-prober/1.63ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[jokrebel (jokrebel)]

Hi to all!

Great job! I enabled "proposed" at my Ubuntu 14.04.3 LTS with kernel 3.16.0-57.

Then I did "sudo apt get-update && sudo apt-get dist-upgrade && sudo update-grub" an well! - since that there now is a

Windows 10 (loader) (auf /dev/sda1)

in the grub boot menu

Thanks a lot
jokrebel

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for os-prober has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package os-prober - 1.63ubuntu1.1

---------------
os-prober (1.63ubuntu1.1) trusty; urgency=medium

  * os-probes/mounted/x86/20microsoft:
    - add Windows 10 to the list (thanks for David Martin for the patch!)
      (LP: #1482851)

 -- Timo Jyrinki <email address hidden> Sun, 20 Dec 2015 21:49:21 +0200