Comment 2 for bug 69455

Revision history for this message
Daniel T Chen (crimsun) wrote : SRU proposal for 6.10's oprofile 0.9.2-1

Hi all,

Recently I was made aware of bashisms[0] in the opcontrol script in
Edgy's oprofile 0.9.2-1 that were fixed in Debian's upload of 0.9.2-2.
All arches in Edgy are affected, and only Edgy is affected. For this
reason I've generated a debdiff that changes the invoked shell to
/bin/bash instead of /bin/sh, which is the least invasive and obviously
correct fix.

Attached please find an SRU debdiff for 6.10's oprofile 0.9.2-1.

% debdiff oprofile_0.9.2-1.dsc oprofile_0.9.2-1ubuntu0.1.dsc |diffstat
 oprofile-0.9.2/debian/changelog | 9 +++++++++
 utils/opcontrol | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

[0] https://launchpad.net/distros/ubuntu/+source/oprofile/+bug/69455

Thanks,
--
Daniel T. Chen <email address hidden>
GPG key: 0xC88ABDA3

diff -u oprofile-0.9.2/debian/changelog oprofile-0.9.2/debian/changelog
--- oprofile-0.9.2/debian/changelog
+++ oprofile-0.9.2/debian/changelog
@@ -1,3 +1,12 @@
+oprofile (0.9.2-1ubuntu0.1) edgy-proposed; urgency=low
+
+ * utils/opcontrol: Use /bin/bash instead of /bin/sh (Closes
+ Ubuntu: #69455), allowing opcontrol to function correctly. (Note:
+ This change is the least invasive one for -updates and so preferable
+ to the fixes in Debian #395014).
+
+ -- Daniel T Chen <email address hidden> Sun, 5 Nov 2006 03:44:52 -0500
+
 oprofile (0.9.2-1) unstable; urgency=low

   * Updated to latest upstream source.
only in patch2:
unchanged:
--- oprofile-0.9.2.orig/utils/opcontrol
+++ oprofile-0.9.2/utils/opcontrol
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 #
 # opcontrol is a script to control OProfile
 # opcontrol --help and opcontrol --list-events have info