ovs-vswitchd should consider lack of DPDK support when enabled fatal

[James Troup]

If ovs-vswitchd without DPDK support is run on a system which requires it, the following error is logged:

2021-01-14T06:01:54.608Z|00007|dpdk|ERR|DPDK not supported in this copy of Open vSwitch.

Unfortunately this is not a fatal error and ovs-vswitchd continues on. It would be much easier from a monitoring and operator ease-of-diagnosis perspective, if ovs-vswitchd exited after this error message.

(ovs-vswitchd was running without DPDK support due to LP #1836713)

[Drew Freiberger (afreiberger)]

Here's a reproducer:

juju deploy ubuntu # onto a vm or metal, can't repro with lxd
juju ssh ubuntu/0 sudo apt-get install openvswitch-switch -y
juju ssh ubuntu/0 'sudo ovs-vsctl add-br br0; sudo ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk options:dpdk-devargs=0000:01:00.0'

Error output from the add-port command is:

ovs-vsctl: Error detected while setting up 'dpdk-p0': could not open network device dpdk-p0 (Address family not supported by protocol). See ovs-vswitchd log for details.
ovs-vsctl: The default log directory is "/var/log/openvswitch".

You can then query 'ovs-vsctl show' and see:

    Bridge br0
        Port dpdk-p0
            Interface dpdk-p0
                type: dpdk
                options: {dpdk-devargs="0000:01:00.0"}
                error: "could not open network device dpdk-p0 (Address family not supported by protocol)"
        Port br0
            Interface br0
                type: internal

ovs-vsctl -f csv list Interface | grep 'not supported'

provides a response that could also be alerted on as an active configuration issue rather than alerting on presence of the log entry.

$ sudo ovs-vsctl -f csv list Interface |grep 'not supported'
556792cf-733a-48fd-aeb1-9423c68e354e,[],{},{},[],[],[],[],[],[],[],[],"""could not open network device dpdk-p0 (Address family not supported by protocol)""",{},[],0,0,[],[],[],[],{},[],[],[],[],dpdk-p0,-1,[],"{dpdk-devargs=""0000:01:00.0""}",{},{},{},dpdk

[Drew Freiberger (afreiberger)]

Adding OVS related charms which should be instrumented with additional NRPE check to alert on incompatible interfaces configured in the switch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/787448

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-neutron-gateway/+/787829

[Drew Freiberger (afreiberger)]

Added PR for layer:ovn which will need to later be re-synced into charm-ovn-chassis.

https://github.com/openstack-charmers/charm-layer-ovn/pull/47

[Drew Freiberger (afreiberger)]

Added monitoring elements to charmhelpers here:
https://github.com/juju/charm-helpers/pull/601

[OpenStack Infra (hudson-openstack)]

Change abandoned by "James Page <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/charm-neutron-openvswitch/+/787448
Reason: This review is > 12 weeks without comment, and failed testing the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.