package does not use released charms
Bug #1576412 reported by
Adam Stokes
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
openstack (Ubuntu) |
Fix Released
|
Critical
|
Adam Stokes | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
All users wanting to deploy a production grade OpenStack via Juju bundles.
[Test Case]
This basically uses the vetted 16.04 charms from charmstore so just running 'conjure-up openstack' and seeing the services start and booting an instance is enough.
[Regression Potential]
This would would actually reduce regression risks as we were pulling from the charmers next branch where at any given time could break.
[Additional Info]
openstack package should use the released charms from the charmstore rather than openstack-
Changed in openstack (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Critical |
assignee: | nobody → Adam Stokes (adam-stokes) |
description: | updated |
Changed in openstack (Ubuntu): | |
status: | In Progress → Fix Released |
To post a comment you must log in.
The debian/rules diff looks weird, and the changelog does not explicitly mention it:
%: dh_installinit: on-upgrade dh_systemd_ start:
- dh $@
+ dh $@ --with systemd
+
+override_
+ dh_systemd_enable -popenstack --name=openstack openstack.service
+ dh_installinit -popenstack --no-start --noscripts
+ dh_systemd_start -popenstack --no-restart-
+
+override_
+ echo "Not running dh_systemd_start"
This second-guesses debhelper's automatic ordering of which dh_* commands to call at what time (although this order here is correct). But it's still bad/brittle/ confusing style to have an explicit override to disable dh_systemd_start and then call it in a *different* rule. Also, like that dh_systemd_enable will be called twice, once in dh_installinit and another one through the auto-generated one via "dh --with systemd". Finally, the dh_installinit call looks like a no-op, what does that do?
What does not work if you drop both overrides and simply do "dh $@ --with systemd"?