django_compressor missing version in pip-requires

Bug #1184653 reported by sash-kan
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Jiri Tomasek
openstack-dashboard (Ubuntu)
New
Undecided
Unassigned

Bug Description

drop-down lists have stopped working.

for example:
list for selecting current project on http://my_server/project/
list for more actions on http://my_server/project/images_and_snapshots/
and the like

after commenting out line
<script src="{{ STATIC_URL }}horizon/lib/d3.v3.min.js" type="text/javascript" charset="utf-8"></script>
in file horizon/templates/horizon/_scripts.html lists are beginning to work.

tested in firefox and google/chrome

p.s. d3.v3.min.js added in commit ccb11b709

Revision history for this message
Julie Pichon (jpichon) wrote :

Could you confirm which version of django-compressor you are currently using? The d3 version we ship is known to require django-compressor >= 1.3 for the compression to work correctly.

$ sudo pip install -U django-compressor # if using devstack

Changed in horizon:
status: New → Incomplete
Revision history for this message
sash-kan (alex-barakin) wrote :

Julie Pichon
i have found information about this problem in maling list.
unfortunately, before executing the specified command, I have not looked at the current version of django-compressor.
i can only attach the output of the command:
$ sudo pip install --upgrade django_compressor
Downloading/unpacking django-compressor
  Downloading django_compressor-1.3.tar.gz (91Kb): 91Kb downloaded
  Running setup.py egg_info for package django-compressor

    warning: no files found matching '*.js' under directory 'compressor/tests/media'
    warning: no files found matching '*.css' under directory 'compressor/tests/media'
    warning: no files found matching '*.png' under directory 'compressor/tests/media'
    warning: no files found matching '*.coffee' under directory 'compressor/tests/media'
Downloading/unpacking django-appconf>=0.4 (from django-compressor)
  Downloading django-appconf-0.6.tar.gz
  Running setup.py egg_info for package django-appconf

Downloading/unpacking six (from django-appconf>=0.4->django-compressor)
  Downloading six-1.3.0.tar.gz
  Running setup.py egg_info for package six

Installing collected packages: django-compressor, django-appconf, six
  Found existing installation: django-compressor 1.2
    Uninstalling django-compressor:
      Successfully uninstalled django-compressor
  Running setup.py install for django-compressor

    warning: no files found matching '*.js' under directory 'compressor/tests/media'
    warning: no files found matching '*.css' under directory 'compressor/tests/media'
    warning: no files found matching '*.png' under directory 'compressor/tests/media'
    warning: no files found matching '*.coffee' under directory 'compressor/tests/media'
  Found existing installation: django-appconf 0.6
    Uninstalling django-appconf:
      Successfully uninstalled django-appconf
  Running setup.py install for django-appconf

  Found existing installation: six 1.2.0
    Uninstalling six:
      Successfully uninstalled six
  Running setup.py install for six

Successfully installed django-compressor django-appconf six
Cleaning up...

Revision history for this message
sash-kan (alex-barakin) wrote :

after executing specified command drop-down lists have started to work normally.
perhaps it makes sense to update horizon dependencies?

Revision history for this message
Julie Pichon (jpichon) wrote :

You're correct, we probably should start versioning the django_compressor library in our pip-requires.

In the output you pasted, it reads: "Found existing installation: django-compressor 1.2" so it did upgrade it.

summary: - d3.v3.min.js broke the drop-down lists
+ django_compressor missing version in pip-requires
Changed in horizon:
status: Incomplete → Confirmed
importance: Undecided → Low
importance: Low → Medium
Jiri Tomasek (jtomasek)
Changed in horizon:
assignee: nobody → Jiri Tomasek (jtomasek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/30871

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/30871
Committed: http://github.com/openstack/horizon/commit/ff608678bea48ea0fb2aafdc52d96ed6b0261a20
Submitter: Jenkins
Branch: master

commit ff608678bea48ea0fb2aafdc52d96ed6b0261a20
Author: Jiri Tomasek <email address hidden>
Date: Tue May 28 13:02:17 2013 +0200

    Specify the django-compressor version to be 1.3 and higher

    The d3 library requires django-compressor version 1.3 and higher

    Fixes: bug #1184653

    Change-Id: I543021c0421290c70585717788535a9f4c36693b

Changed in horizon:
status: In Progress → Fix Committed
David Lyle (david-lyle)
Changed in horizon:
milestone: none → havana-2
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-2 → 2013.2
Revision history for this message
Joe Breu (breu) wrote :

openstack-dashboard havana packages do not have a dep on python-compressor >= 1.3 which causes breakage when upgrading.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.