Activity log for bug #1994165

Date Who What changed Old value New value Message
2022-10-25 18:07:15 Gil Weis bug added bug
2022-10-26 12:44:29 Benjamin Drung description https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300 Handle SMIME_crlf_copy return code Currently the SMIME_crlf_copy result is ignored in all usages. It does return failure when memory allocation fails. This patch handles the SMIME_crlf_copy return code in all occurrences. Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from https://github.com/openssl/openssl/pull/18876) ```
2022-10-26 12:45:08 Benjamin Drung openssl (Ubuntu): status New Triaged
2022-10-26 12:45:13 Benjamin Drung openssl (Ubuntu): importance Undecided Medium
2022-10-26 12:45:26 Benjamin Drung bug added subscriber Ubuntu Foundations Bugs
2022-10-26 12:45:43 Benjamin Drung nominated for series Ubuntu Kinetic
2022-10-26 12:45:43 Benjamin Drung bug task added openssl (Ubuntu Kinetic)
2022-10-26 12:45:43 Benjamin Drung nominated for series Ubuntu Jammy
2022-10-26 12:45:43 Benjamin Drung bug task added openssl (Ubuntu Jammy)
2022-10-26 12:45:55 Benjamin Drung openssl (Ubuntu Jammy): status New Triaged
2022-10-26 12:45:57 Benjamin Drung openssl (Ubuntu Jammy): importance Undecided High
2022-10-26 12:46:03 Benjamin Drung openssl (Ubuntu Jammy): importance High Medium
2022-10-28 18:39:51 William Wilson tags foundations-triage-discuss
2022-11-18 10:47:09 Adrien Nader bug added subscriber Adrien Nader
2022-12-02 15:14:22 Adrien Nader openssl (Ubuntu Jammy): assignee Adrien Nader (adrien-n)
2022-12-02 15:14:24 Adrien Nader openssl (Ubuntu Kinetic): assignee Adrien Nader (adrien-n)
2022-12-02 15:14:27 Adrien Nader openssl (Ubuntu): assignee Adrien Nader (adrien-n)
2022-12-02 15:14:35 Adrien Nader openssl (Ubuntu Jammy): status Triaged Incomplete
2022-12-02 15:14:38 Adrien Nader openssl (Ubuntu Kinetic): status Triaged Incomplete
2022-12-02 15:14:45 Adrien Nader openssl (Ubuntu): status Triaged Incomplete
2023-07-17 20:14:23 Adrien Nader openssl (Ubuntu): status Incomplete Won't Fix
2023-07-17 20:14:25 Adrien Nader openssl (Ubuntu Jammy): status Incomplete Won't Fix
2023-07-17 20:14:27 Adrien Nader openssl (Ubuntu Kinetic): status Incomplete Won't Fix
2023-07-17 20:15:20 Adrien Nader openssl (Ubuntu): status Won't Fix Triaged
2023-07-17 20:15:32 Adrien Nader openssl (Ubuntu Jammy): status Won't Fix Triaged
2023-08-29 12:01:53 Adrien Nader openssl (Ubuntu Jammy): status Triaged In Progress
2023-08-29 12:01:56 Adrien Nader openssl (Ubuntu Jammy): milestone jammy-updates
2023-08-29 12:03:04 Adrien Nader openssl (Ubuntu): status Triaged In Progress
2023-08-29 15:41:55 Adrien Nader nominated for series Ubuntu Lunar
2023-08-29 15:41:55 Adrien Nader bug task added openssl (Ubuntu Lunar)
2023-08-29 15:42:00 Adrien Nader openssl (Ubuntu Lunar): status New Fix Released
2023-08-29 15:42:10 Adrien Nader openssl (Ubuntu): status In Progress Fix Released
2023-09-29 13:27:01 Adrien Nader description https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300 Handle SMIME_crlf_copy return code Currently the SMIME_crlf_copy result is ignored in all usages. It does return failure when memory allocation fails. This patch handles the SMIME_crlf_copy return code in all occurrences. Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from https://github.com/openssl/openssl/pull/18876) ``` === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "penssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ```
2023-09-29 16:37:44 Adrien Nader description === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "penssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ``` === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ```
2023-09-30 07:45:13 Adrien Nader description === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ``` === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ```
2023-09-30 07:55:16 Adrien Nader description === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ``` === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 - https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0001-REGRESSION-CMS_final-do-not-ignore-CMS_dataFinal-res.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 - https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0002-Handle-SMIME_crlf_copy-return-code.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ```
2023-09-30 07:55:26 Adrien Nader description === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 - https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0001-REGRESSION-CMS_final-do-not-ignore-CMS_dataFinal-res.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 - https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0002-Handle-SMIME_crlf_copy-return-code.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ``` === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0001-REGRESSION-CMS_final-do-not-ignore-CMS_dataFinal-res.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0002-Handle-SMIME_crlf_copy-return-code.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ```
2023-10-02 09:10:23 Adrien Nader description === SRU information === [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0001-REGRESSION-CMS_final-do-not-ignore-CMS_dataFinal-res.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0002-Handle-SMIME_crlf_copy-return-code.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ``` === SRU information === [Meta] This bug is part of a series of four bugs for a single SRU. The "central" bug with the global information and debdiff is #2033422 [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0001-REGRESSION-CMS_final-do-not-ignore-CMS_dataFinal-res.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0002-Handle-SMIME_crlf_copy-return-code.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ```
2023-10-02 11:30:09 Adrien Nader description === SRU information === [Meta] This bug is part of a series of four bugs for a single SRU. The "central" bug with the global information and debdiff is #2033422 [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0001-REGRESSION-CMS_final-do-not-ignore-CMS_dataFinal-res.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0002-Handle-SMIME_crlf_copy-return-code.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ``` === SRU information === [Meta] This bug is part of a series of four bugs for a single SRU. The "central" bug with the global information and debdiff is http://pad.lv/2033422 [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0001-REGRESSION-CMS_final-do-not-ignore-CMS_dataFinal-res.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0002-Handle-SMIME_crlf_copy-return-code.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ```
2023-10-03 12:53:33 Adrien Nader bug added subscriber Ubuntu Sponsors
2023-10-05 19:15:50 Sergio Durigan Junior removed subscriber Ubuntu Sponsors
2023-10-19 20:51:04 Adrien Nader removed subscriber Ubuntu Foundations Bugs
2023-10-27 15:47:47 Ubuntu Archive Robot bug added subscriber Simon Chopin
2023-10-31 13:13:27 Adrien Nader description === SRU information === [Meta] This bug is part of a series of four bugs for a single SRU. The "central" bug with the global information and debdiff is http://pad.lv/2033422 [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0001-REGRESSION-CMS_final-do-not-ignore-CMS_dataFinal-res.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0002-Handle-SMIME_crlf_copy-return-code.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ``` === SRU information === [Meta] This bug is part of a series of three bugs for a single SRU. The "central" bug with the global information and debdiff is http://pad.lv/2033422 [Impact] S/MIME signature can fail silently The commit by upstream propagates the return code of some functions rather than ignore it. [Test plan] This issue is not very simple to reproduce because "openssl cms" cannot be used to do so. This has to be done with the openssl API instead. At least the bug reportere here and the one on openssl's bug tracker have confirmed the patch solves the issue. Additionally, the bug reporter here has tested the PPA that contains the patche and validated it. Finally, I read through the patch attentively. [Where problems could occur] At this point it is unlikely an error would appear. The openssl bug tracker mentions nothing related to this patch which landed more than a year ago. The patch is simple and doesn't change the code logic. [Patches] The patches come directly from upstream and apply cleanly. https://github.com/openssl/openssl/pull/18876 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0001-REGRESSION-CMS_final-do-not-ignore-CMS_dataFinal-res.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 * https://git.launchpad.net/~adrien-n/ubuntu/+source/openssl/tree/debian/patches/jammy-sru-0002-Handle-SMIME_crlf_copy-return-code.patch?h=jammy-sru&id=04ef023920ab08fba214817523fba897527dfff0 === Original description === https://github.com/openssl/openssl/pull/18876 The CMS_dataFinal result is important as signature may fail, however, it is ignored while returning success from CMS_final. Please add this fix to The openssl 3.0.2 "Jammy Jellyfish (supported)" Thanks Upstream commit: ``` commit 67c0460b89cc1b0644a1a59af78284dfd8d720af Author: Alon Bar-Lev <alon.barlev@gmail.com> Date: Tue Jul 26 15:17:06 2022 +0300     Handle SMIME_crlf_copy return code     Currently the SMIME_crlf_copy result is ignored in all usages. It does     return failure when memory allocation fails.     This patch handles the SMIME_crlf_copy return code in all occurrences.     Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>     Reviewed-by: Tomas Mraz <tomas@openssl.org>     Reviewed-by: Paul Dale <pauli@openssl.org>     Reviewed-by: Hugo Landau <hlandau@openssl.org>     (Merged from https://github.com/openssl/openssl/pull/18876) ```
2023-12-14 11:40:24 Mauricio Faria de Oliveira bug added subscriber Mauricio Faria de Oliveira
2024-01-19 23:32:23 Steve Langasek openssl (Ubuntu Jammy): status In Progress Fix Committed
2024-01-19 23:32:25 Steve Langasek bug added subscriber Ubuntu Stable Release Updates Team
2024-01-19 23:32:27 Steve Langasek bug added subscriber SRU Verification
2024-01-19 23:32:31 Steve Langasek tags foundations-triage-discuss foundations-triage-discuss verification-needed verification-needed-jammy
2024-01-25 09:03:49 Adrien Nader tags foundations-triage-discuss verification-needed verification-needed-jammy foundations-triage-discuss verification-done verification-done-jammy
2024-01-25 09:04:18 Adrien Nader tags foundations-triage-discuss verification-done verification-done-jammy verification-done verification-done-jammy
2024-01-25 11:28:47 Launchpad Janitor openssl (Ubuntu Jammy): status Fix Committed Fix Released
2024-01-25 11:28:54 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team