Activity log for bug #531912

Date Who What changed Old value New value Message
2010-03-04 13:51:56 Mark Schouten bug added bug
2010-03-04 13:54:35 Colin Watson openssh (Ubuntu): importance Undecided Medium
2010-03-04 13:54:35 Colin Watson openssh (Ubuntu): status New Triaged
2010-06-30 12:40:05 Patrick Cervicek attachment added ssh_conf.diff http://launchpadlibrarian.net/51173516/ssh_conf.diff
2010-06-30 22:57:32 Brian Murray bug added subscriber Ubuntu Review Team
2010-06-30 22:57:34 Brian Murray tags patch
2010-08-28 02:19:30 Simon Déziel bug added subscriber Simon Déziel
2010-10-31 20:30:50 lamprakis bug added subscriber lamprakis
2011-01-31 22:10:51 Launchpad Janitor branch linked lp:~clint-fewbar/ubuntu/natty/openssh/init.d-chroot-aware
2011-01-31 22:14:55 Clint Byrum summary [LUCID] /etc/init.d/ssh seems to work, but actually upstart is used. /etc/init.d/ssh seems to work, but actually upstart is used.
2011-01-31 22:21:12 Clint Byrum nominated for series Ubuntu Lucid
2011-01-31 22:21:12 Clint Byrum nominated for series Ubuntu Maverick
2011-02-01 18:35:19 Brian Murray bug added subscriber Brian Murray
2011-02-01 21:13:03 Clint Byrum openssh (Ubuntu): assignee Clint Byrum (clint-fewbar)
2011-02-01 21:13:06 Clint Byrum openssh (Ubuntu): status Triaged In Progress
2011-02-01 22:02:54 ingo bug added subscriber ingo
2011-02-14 21:15:04 Søren Holm bug added subscriber Søren Holm
2011-03-03 14:56:57 Colin Watson openssh (Ubuntu): status In Progress Fix Committed
2011-03-03 14:57:01 Colin Watson bug task added openssh (Ubuntu Lucid)
2011-03-03 14:57:08 Colin Watson bug task added openssh (Ubuntu Maverick)
2011-03-03 14:57:18 Colin Watson openssh (Ubuntu Lucid): status New Triaged
2011-03-03 14:57:20 Colin Watson openssh (Ubuntu Maverick): status New Triaged
2011-03-03 14:57:23 Colin Watson openssh (Ubuntu Lucid): importance Undecided Medium
2011-03-03 14:57:25 Colin Watson openssh (Ubuntu Maverick): importance Undecided Medium
2011-03-03 14:57:37 Colin Watson openssh (Ubuntu Lucid): assignee Clint Byrum (clint-fewbar)
2011-03-03 14:57:45 Colin Watson openssh (Ubuntu Maverick): assignee Clint Byrum (clint-fewbar)
2011-03-03 16:25:11 Launchpad Janitor openssh (Ubuntu): status Fix Committed Fix Released
2011-03-09 13:18:32 Launchpad Janitor branch linked lp:~clint-fewbar/ubuntu/maverick/openssh/init.d-upstart-aware
2011-03-09 13:37:29 Launchpad Janitor branch linked lp:~clint-fewbar/ubuntu/lucid/openssh/init.d-upstart-aware
2011-06-11 14:54:44 Clint Byrum description While trying to get x-forwarding on Lucid to work, I edited /etc/default/ssh to add the -4 flag, as offered as a work-around in various bugreports. When trying to restart ssh using /etc/init.d/ssh, all seems to work but my flags around passed to sshd. It seems that ssh is actually managed by upstart, which is great, but you cannot really tell. For other services, there are symlinks to /lib/init, for ssh there isn't. So I assumed that ssh is still managed using /etc/init.d/ Please clarify the use of upstart (for ssh) for users, so they don't spend hours trying to debug what shouldn't be debugged. :) While trying to get x-forwarding on Lucid to work, I edited /etc/default/ssh to add the -4 flag, as offered as a work-around in various bugreports. When trying to restart ssh using /etc/init.d/ssh, all seems to work but my flags around passed to sshd. It seems that ssh is actually managed by upstart, which is great, but you cannot really tell. For other services, there are symlinks to /lib/init, for ssh there isn't. So I assumed that ssh is still managed using /etc/init.d/ Please clarify the use of upstart (for ssh) for users, so they don't spend hours trying to debug what shouldn't be debugged. :) == SRU Justification == Impact: this bug causes quite a bit of confusion for users, which is particularly troubling considering SSH is often the only way headless systems can be accessed post-installation. The change will avoid the half-in half-out situation that some people are dealing with where they mix /etc/init.d/ssh with using the 'service' command or upstart start/stop/initctl commands. Dev fix: A check has been added to the included init.d script which checks to see if it is being run in a chroot, and if not, it runs /lib/init/upstart-job in much the same way it is usually run when symlinked from /etc/init.d. TEST CASE: 1. start a system with openssh-server installed 2. run 'sudo status ssh' to verify that ssh has been started by upstart. 3. run 'sudo stop ssh' to stop the upstart job. 4. run 'sudo /etc/init.d/ssh start'. It should start sshd without upstart. 5. run 'sudo status ssh' to verify that the ssh upstart job is not running 6. run 'sudo /etc/int.d/ssh stop' to stop the incorrectly managed sshd. 7. install new package with patched init.d script 8. repeat steps 2 through 4. now it should display a disclaimer like this: Rather than invoking init scripts through /etc/init.d, use the service(8) utility, e.g. service ssh start Since the script you are attempting to invoke has been converted to an Upstart job, you may also use the start(8) utility, e.g. start ssh Regression Potential: There may be users who are expecting this script to work outside of chroots. They would have to achieve this by modifying the start on or removing the /etc/init/ssh.conf. The latter case is handled directly in the code by checking for its existence. The former will also be handled on reboot, but not on upgrades. The upgrade will cause the script to be unable to stop any sshd that is running via the old method.
2011-06-17 05:45:15 Martin Pitt openssh (Ubuntu Lucid): status Triaged Fix Committed
2011-06-17 05:45:17 Martin Pitt bug added subscriber Ubuntu Stable Release Updates Team
2011-06-17 05:45:19 Martin Pitt bug added subscriber SRU Verification
2011-06-17 05:45:20 Martin Pitt tags patch patch verification-needed
2011-06-17 06:07:01 Martin Pitt openssh (Ubuntu Maverick): status Triaged Fix Committed
2011-07-16 13:58:59 Rolf Leggewie tags patch verification-needed patch verification-done
2011-07-16 19:17:54 Launchpad Janitor openssh (Ubuntu Lucid): status Fix Committed Fix Released
2011-07-16 19:18:10 Launchpad Janitor openssh (Ubuntu Maverick): status Fix Committed Fix Released