Recommends: ssh-import-id missing in openssh 1:7.9p1-1

[Steve Langasek]

ssh-import-id shows on http://people.canonical.com/~ubuntu-archive/component-mismatches as wanting demotion to universe. This is because openssh-server in disco has dropped its Recommends on this package, which appears to be a misbuild.

From the build log, I see:

dh_gencontrol -- -V'openssh-server:Recommends='

(https://launchpad.net/ubuntu/+source/openssh/1:7.9p1-1/+build/15632765)

But debian/rules has:

ifeq ($(UBUNTU),yes)
server_recommends := ssh-import-id
else
server_recommends :=
endif

[...]
override_dh_gencontrol:
        dh_gencontrol -- -V'openssh-server:Recommends=$(server_recommends)'

So this is supposed to be set but isn't.

[Steve Langasek (vorlon)]

The build log also shows that the Ubuntu default path is not being set:

--with-default-path=/usr/local/bin:/usr/bin:/bin:/usr/games

[Steve Langasek (vorlon)]

printf debugging of debian/rules shows that $(UBUNTU) is set to the literal string:

  dpkg-vendor --derives-from && echo yes || echo no

That seems unexpected. It seems /usr/share/dpkg/vendor.mk is incorrect about the usage of dpkg_vendor_derives_from and that this has never worked as advertised, but that openssh in disco has switched to using this function for the first time, introducing the regression.

[Andreas Hasenack (ahasenack)]

https://bugs.debian.org/913816 filed by Colin

[Jeremy Bícha (jbicha)]

This bug was fixed in the package openssh - 1:7.9p1-4

---------------
openssh (1:7.9p1-4) unstable; urgency=medium

  * Fix Ubuntu detection in debian/rules, since the documentation comment
    for dpkg_vendor_derives_from is wrong (thanks, Jeremy Bicha; see
    #913816).

 -- Colin Watson <email address hidden> Fri, 16 Nov 2018 11:27:28 +0000

openssh (1:7.9p1-3) unstable; urgency=medium

  * Be more specific about what files to install in openssh-tests, to avoid
    installing a symlink into the build tree.
  * Re-export debian/upstream/signing-key.asc without extra signatures.
  * Restore direct test dependencies on openssl, putty-tools, and
    python-twisted-conch; these are really only indirect dependencies via
    openssh-tests, but including them means that this package will be
    retested when they change.

 -- Colin Watson <email address hidden> Thu, 15 Nov 2018 01:30:56 +0000

openssh (1:7.9p1-2) unstable; urgency=medium

  * Add GitLab CI configuration.
  * Make the autopkgtest create /run/sshd if it doesn't already exist.
  * Drop "set -x" verbosity from the autopkgtest; I think we can do without
    this in most cases nowadays.
  * Add an openssh-tests binary package containing enough files to run the
    upstream regression tests. This allows autopkgtest to run more
    efficiently, as it doesn't have to build part of the source tree again.

 -- Colin Watson <email address hidden> Wed, 14 Nov 2018 15:55:48 +0000