when slapd upgrade fails, later upgrade attempts overwrite saved backups of pre-upgrade configuration files
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
openldap (Debian) |
Fix Released
|
Unknown
|
|||
openldap (Ubuntu) |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
When called in "upgrade" mode, the slapd.postinst script starts out by making a backup of the $SLAPD_CONF directory into /var/backups/
However, if the upgrade fails (e.g. because of bug #571057), then later attempts to run the upgrade script will still be called with the same old-package-
I see there is some logic in the compute_backup_path function to check if the backup target already exists, and to abort the upgrade run if it does. Doing the same sort of check-and-abort in backup_config_once would be better than the current scenario, though it might be even nicer if the program could pick a new backup directory (e.g. /var/backups/
summary: |
- when slapd upgrade fails, later upgrade attempts overwrite saved copies + when slapd upgrade fails, later upgrade attempts overwrite saved backups of pre-upgrade configuration files |
Changed in openldap (Ubuntu): | |
assignee: | nobody → Ryan Tandy (rtandy) |
Changed in openldap (Debian): | |
status: | Unknown → New |
Changed in openldap (Debian): | |
status: | New → Confirmed |
Changed in openldap (Debian): | |
status: | Confirmed → Fix Released |
Makes sense, so marking confirmed/WishList. Nathan, would you care to prepare a patch?