| 2021-01-21 20:20:18 |
Lucas Kanashiro |
bug |
|
|
added bug |
| 2021-01-21 20:33:58 |
Lucas Kanashiro |
attachment added |
|
debdiff https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+attachment/5455306/+files/debdiff |
|
| 2021-01-22 00:34:00 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2021-01-22 03:12:33 |
Launchpad Janitor |
opengcs (Ubuntu): status |
New |
Fix Released |
|
| 2021-03-22 14:31:27 |
Lucas Kanashiro |
nominated for series |
|
Ubuntu Bionic |
|
| 2021-03-22 14:31:27 |
Lucas Kanashiro |
bug task added |
|
opengcs (Ubuntu Bionic) |
|
| 2021-03-22 14:31:27 |
Lucas Kanashiro |
nominated for series |
|
Ubuntu Groovy |
|
| 2021-03-22 14:31:27 |
Lucas Kanashiro |
bug task added |
|
opengcs (Ubuntu Groovy) |
|
| 2021-03-22 14:31:27 |
Lucas Kanashiro |
nominated for series |
|
Ubuntu Focal |
|
| 2021-03-22 14:31:27 |
Lucas Kanashiro |
bug task added |
|
opengcs (Ubuntu Focal) |
|
| 2021-03-22 14:32:54 |
Lucas Kanashiro |
summary |
autopkgtest failure blocking runc migration |
[SRU] Support runc/1.0.0~rc93-0ubuntu1 |
|
| 2021-03-22 14:54:14 |
Lucas Kanashiro |
description |
opencgs test is failing and blocking runc/1.0.0~rc92-0ubuntu1 from migrating to hirsute:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute/hirsute/amd64/o/opengcs/20210118_162901_84e57@/log.gz
This is the important bits:
# vendor/github.com/docker/containerd/sys
src/vendor/github.com/docker/containerd/sys/proc.go:17:34: undefined: system.GetClockTicks
The new runc version does not provide GetClockTicks anymore:
https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817
We should do the same in opengcs. |
[Impact]
Due to our current policy we keep updating the container stack in all supported releases with new upstream versions. runc is part of this stack, and currently versions of opengcs in Bionic, Focal and Groovy do not support runc / 1.0.0 ~ rc93-0ubuntu1.
opengcs tries to make use of system.GetClockTicks which would require a dependency on cgo. runc upstream decided to stop using it here:
https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817
In Hirsute, a similar approach was implemented in opengcs to allow runc migration. Now, in order to unblock the runc SRUs we need to backport the Hirsute patch.
[Test Plan]
The upstream test suite seems to be enough to caught any potential issue in this case.
[Where problems could occur]
We are replacing a system call which would require cgo with a constant. According to this comment this is safe enough:
https://github.com/containerd/cgroups/pull/12#issuecomment-311322400
But the scenario where someone compile its own kernel and change the value of this constant will be inconsistent. However, this is not a big deal IMO, someone changing its own kernel needs to handle the consequences.
[Original Message]
opencgs test is failing and blocking runc/1.0.0~rc92-0ubuntu1 from migrating to hirsute:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute/hirsute/amd64/o/opengcs/20210118_162901_84e57@/log.gz
This is the important bits:
# vendor/github.com/docker/containerd/sys
src/vendor/github.com/docker/containerd/sys/proc.go:17:34: undefined: system.GetClockTicks
The new runc version does not provide GetClockTicks anymore:
https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817
We should do the same in opengcs. |
|
| 2021-03-22 15:57:32 |
Lucas Kanashiro |
attachment added |
|
debdiff-groovy https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+attachment/5479206/+files/debdiff-groovy |
|
| 2021-03-22 15:57:55 |
Lucas Kanashiro |
attachment added |
|
debdiff-focal https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+attachment/5479207/+files/debdiff-focal |
|
| 2021-03-22 15:58:17 |
Lucas Kanashiro |
attachment added |
|
debdiff-bionic https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1912691/+attachment/5479208/+files/debdiff-bionic |
|
| 2021-03-22 20:47:30 |
Lucas Kanashiro |
description |
[Impact]
Due to our current policy we keep updating the container stack in all supported releases with new upstream versions. runc is part of this stack, and currently versions of opengcs in Bionic, Focal and Groovy do not support runc / 1.0.0 ~ rc93-0ubuntu1.
opengcs tries to make use of system.GetClockTicks which would require a dependency on cgo. runc upstream decided to stop using it here:
https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817
In Hirsute, a similar approach was implemented in opengcs to allow runc migration. Now, in order to unblock the runc SRUs we need to backport the Hirsute patch.
[Test Plan]
The upstream test suite seems to be enough to caught any potential issue in this case.
[Where problems could occur]
We are replacing a system call which would require cgo with a constant. According to this comment this is safe enough:
https://github.com/containerd/cgroups/pull/12#issuecomment-311322400
But the scenario where someone compile its own kernel and change the value of this constant will be inconsistent. However, this is not a big deal IMO, someone changing its own kernel needs to handle the consequences.
[Original Message]
opencgs test is failing and blocking runc/1.0.0~rc92-0ubuntu1 from migrating to hirsute:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute/hirsute/amd64/o/opengcs/20210118_162901_84e57@/log.gz
This is the important bits:
# vendor/github.com/docker/containerd/sys
src/vendor/github.com/docker/containerd/sys/proc.go:17:34: undefined: system.GetClockTicks
The new runc version does not provide GetClockTicks anymore:
https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817
We should do the same in opengcs. |
[Impact]
Due to our current policy we keep updating the container stack in all supported releases with new upstream versions. runc is part of this stack, and currently versions of opengcs in Bionic, Focal and Groovy do not support runc / 1.0.0 ~ rc93-0ubuntu1.
opengcs tries to make use of system.GetClockTicks which would require a dependency on cgo. runc upstream decided to stop using it here:
https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817
In Hirsute, a similar approach was implemented in opengcs to allow runc migration. Now, in order to unblock the runc SRUs we need to backport the Hirsute patch.
[Test Plan]
The upstream test suite seems to be enough to catch any potential issue in this case.
[Where problems could occur]
We are replacing a system call which would require cgo with a known constant to avoid this dependency. This approach was adopted by runc upstream maintainers, and according to this comment this is safe enough:
https://github.com/containerd/cgroups/pull/12#issuecomment-311322400
But the scenario where someone compile its own kernel and change the value of this constant will be inconsistent. However, this is not a big deal IMO, someone changing its own kernel needs to handle the consequences.
[Original Message]
opencgs test is failing and blocking runc/1.0.0~rc92-0ubuntu1 from migrating to hirsute:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute/hirsute/amd64/o/opengcs/20210118_162901_84e57@/log.gz
This is the important bits:
# vendor/github.com/docker/containerd/sys
src/vendor/github.com/docker/containerd/sys/proc.go:17:34: undefined: system.GetClockTicks
The new runc version does not provide GetClockTicks anymore:
https://github.com/opencontainers/runc/commit/402d645c5c642a4965439a156181cff3fc2f3817
We should do the same in opengcs. |
|
| 2021-03-22 20:51:06 |
Lucas Kanashiro |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2021-03-30 21:17:42 |
Robie Basak |
opengcs (Ubuntu Groovy): status |
New |
Fix Committed |
|
| 2021-03-30 21:17:44 |
Robie Basak |
bug |
|
|
added subscriber SRU Verification |
| 2021-03-30 21:17:47 |
Robie Basak |
tags |
patch |
patch verification-needed verification-needed-groovy |
|
| 2021-03-30 21:18:04 |
Robie Basak |
opengcs (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2021-03-30 21:18:11 |
Robie Basak |
tags |
patch verification-needed verification-needed-groovy |
patch verification-needed verification-needed-focal verification-needed-groovy |
|
| 2021-03-30 21:18:24 |
Robie Basak |
opengcs (Ubuntu Bionic): status |
New |
Fix Committed |
|
| 2021-03-30 21:18:28 |
Robie Basak |
tags |
patch verification-needed verification-needed-focal verification-needed-groovy |
patch verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy |
|
| 2021-04-07 14:53:08 |
Lucas Kanashiro |
tags |
patch verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy |
patch verification-done verification-done-bionic verification-done-focal verification-done-groovy |
|
| 2021-04-08 08:26:27 |
Launchpad Janitor |
opengcs (Ubuntu Groovy): status |
Fix Committed |
Fix Released |
|
| 2021-04-08 08:26:32 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-04-08 08:49:27 |
Launchpad Janitor |
opengcs (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2021-04-08 08:57:25 |
Launchpad Janitor |
opengcs (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
