Comment 21 for bug 311188

Revision history for this message
kecsap (csaba-kertesz) wrote :

General comment for the newest patches:

I am an OpenCV developer and I would like to release my own software for Ubuntu and then I faced to this issue: the current OpenCV version is soooo old in the repositories that the ffmpeg part of the library is quite broken. I fixed several issues on this specific part of the library and decided to push upstream fixes for you.

1. I downloaded virtual images of Ubuntu 8.04, 8.10, 9.04 and 9.10.
2. I generated a patch of the upstream fixes (it is a well-separated part of the library, only one file -> no need for several patches).
3. It does not effect other parts of the library.
4. Does not break/modify the API of the module, the changes are done internally.

Basicly, the current patches attached to this bug report contain the same upstream fixes to OpenCV 1.0, but there are small differences of the OpenCV in these distribution versions because of the different patched state of the OpenCV and the differences in the ffmpeg versions. Here is a summary:

Ubuntu 9.10:

- My two patches replaces the 400_xxx.diff and 410_xxx.diff in the debian/patches directory.
- A dependency to libswscale-dev is needed to be added at debian/control.
(- changelog update is needed -> will be added when I upload the new versions of the packages?)

Ubuntu 9.04:

- Two patches 400_xxx.diff and 410_xxx.diff should be added in the debian/patches directory.
- A dependency to libswscale-dev is needed to be added at debian/control.
(- changelog update is needed -> will be added when I upload the new versions of the packages?)

Ubuntu 8.10:

- Only one patch must be added: 410_xxx.diff in the debian/patches directory.
(- changelog update is needed -> will be added when I upload the new versions of the packages?)

Ubuntu 8.04:

- Only one patch must be added: 410_xxx.diff in the debian/patches directory.
(- changelog update is needed -> will be added when I upload the new versions of the packages?)

Tests performed:
1. Execute my own software's unit tests which use reading/writing functions of the OpenCV's ffmpeg module and they were broken before the patch.
2. Execute the sample applications of OpenCV to find any regression.
3. Execute the (unit) tests of the OpenCV to find any regression.