openafs 1.8.2-1ubuntu0.1 ADT test failure with linux 5.3.0-0.1

[Seth Forshee]

[Impact]
openafs fails to build on linux-hwe-edge 5.3 kernel on bionic.

[Test case]
Test that the dkms package builds fine on 5.3 and older kernels.

[Regression potential]
DKMS fails to build on older kernels, which is tested.
User fails to mount or has failures when programs use afs mounted files.
Those same failures would probably happen on eoan, as we use patches that were applied there.

====================================================================

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/amd64/o/openafs/20190724_130118_026d2@/log.gz
    arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/arm64/o/openafs/20190724_134716_026d2@/log.gz
    armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/armhf/o/openafs/20190724_141639_026d2@/log.gz
    s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan-canonical-kernel-team-bootstrap/eoan/s390x/o/openafs/20190724_131542_026d2@/log.gz

[Paolo Pisati (p-pisati)]

Wrong patch, use this one instead:

[Tyler Hicks (tyhicks)]

Hey Paolo - I don't think that the force_sig() change is correct since it will kill the current process instead of the rxk_ListenerTask.

While looking at the code, I noticed that upstream has a more complete fix for both build failures:

 http://git.openafs.org/?p=openafs.git;a=commitdiff;h=2b7af1243f46496c0b5973b3fa2a6396243f7613
 http://git.openafs.org/?p=openafs.git;a=commitdiff;h=02d82275c17284d04629282aa374bb39f511c989

Finally, the version of openafs in Eoan changed since you initially prepared this debdiff.

[Launchpad Janitor (janitor)]

This bug was fixed in the package openafs - 1.8.4~pre1-1ubuntu1

---------------
openafs (1.8.4~pre1-1ubuntu1) eoan; urgency=medium

  * 0005-LINUX-5.3.0-Check-for-recurse-arg-in-keyring_search.patch,
    0006-LINUX-5.3.0-Use-send_sig-instead-of-force_sig.patch: Apply patches
    from upstream to fix build failures with the 5.3 kernel (LP: #1837893)

 -- Tyler Hicks <email address hidden> Fri, 30 Aug 2019 06:32:07 +0000

[Timo Aaltonen (tjaalton)]

Hello Seth, or anyone else affected,

Accepted openafs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openafs/1.8.0~pre5-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Thadeu Lima de Souza Cascardo (cascardo)]

Unpacking openafs-modules-dkms (1.8.0~pre5-1ubuntu1.2) over (1.8.0~pre5-1ubuntu1.1) ...
Setting up openafs-client (1.8.0~pre5-1ubuntu1.2) ...
modprobe: FATAL: Module openafs not found in directory /lib/modules/5.3.0-23-generic
Failed to load openafs.ko. Does it need to be built?
Setting up openafs-modules-dkms (1.8.0~pre5-1ubuntu1.2) ...
Loading new openafs-1.8.0pre5 DKMS files...
Building for 5.3.0-23-generic
Building initial module for 5.3.0-23-generic
Can't load /var/lib/shim-signed/mok/.rnd into RNG
140313257689536:error:2406F079:random number generator:RAND_load_file:Cannot open file:../crypto/rand/randfile.c:88:Filename=/var/lib/shim-signed/mok/.rnd
Generating a RSA private key
.........+++++
...........+++++
writing new private key to '/var/lib/shim-signed/mok/MOK.priv'
-----
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

openafs:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.3.0-23-generic/updates/dkms/

depmod...

DKMS: install completed.

[Thadeu Lima de Souza Cascardo (cascardo)]

$ sudo dkms build openafs/1.8.0pre5 -k 4.15.0-70-generic

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area...(bad exit status: 2)
(./configure --disable-linux-syscall-probing --with-linux-kernel-packaging --with-linux-kernel-headers=/lib/modules/4.15.0-70-generic/build && make && mv src/libafs/MODLOAD-*/openafs.ko .)........................................................................................................................................................
Signing module:
 - /var/lib/dkms/openafs/1.8.0pre5/4.15.0-70-generic/x86_64/module/openafs.ko
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
cleaning build area...

DKMS: build completed.
$

[Launchpad Janitor (janitor)]

This bug was fixed in the package openafs - 1.8.0~pre5-1ubuntu1.2

---------------
openafs (1.8.0~pre5-1ubuntu1.2) bionic; urgency=medium

  [ Tyler Hicks ]
  * 0005-LINUX-5.3.0-Check-for-recurse-arg-in-keyring_search.patch,
    0006-LINUX-5.3.0-Use-send_sig-instead-of-force_sig.patch: Apply patches
    from upstream to fix build failures with the 5.3 kernel (LP: #1837893)

 -- Thadeu Lima de Souza Cascardo <email address hidden> Fri, 22 Nov 2019 10:29:27 -0300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for openafs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.