openafs 1.6.20-2ubuntu2 ADT test failure with linux 4.12.0-12.13

[Seth Forshee]

Testing failed on:
    s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful/artful/s390x/o/openafs/20170818_122306_2985b@/log.gz

[Seth Forshee (sforshee)]

In file included from /var/lib/dkms/openafs/1.6.20/build/src/afs/LINUX/osi_machdep.h:129:0,
                 from /var/lib/dkms/openafs/1.6.20/build/src/afs/afs_osi.h:440,
                 from /var/lib/dkms/openafs/1.6.20/build/src/libafs/MODLOAD-4.12.0-11-generic-SP/afs_dir.c:70:
./arch/s390/include/asm/uaccess.h: In function ‘set_fs’:
./arch/s390/include/asm/uaccess.h:41:6: error: implicit declaration of function ‘uaccess_kernel’; did you mean ‘getname_kernel’? [-Werror=implicit-function-declaration]
  if (uaccess_kernel()) {
      ^~~~~~~~~~~~~~
      getname_kernel

It looks like this would be fixed by including uaccess.h instead of asm/uaccess.h, need to determine whether there's some kernel version limitation on this change though.

[Seth Forshee (sforshee)]

Sorry that should be linux/uaccess.h. Looks like it was introduced in 2.6.18.

[Seth Forshee (sforshee)]

This patch ought to fix the issue.

[Seth Forshee (sforshee)]

Note that the patch is against upstream git, it requires some context adjustments for the Debian/Ubuntu packages.

[Seth Forshee (sforshee)]

I applied this patch to a 1.6.21-2ubuntu1 package that I've uploaded to the canonical-kernel-team/unstable ppa and started ADT against that package. s390x passed:

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-canonical-kernel-team-unstable/artful/s390x/o/openafs/20170823_163112_7793c@/log.gz

i386 also passed, still waiting armhf and amd64 to complete.

[Anders Kaseorg (andersk)]

Do you want to submit this upstream (https://gerrit.openafs.org/), or do you want me to do it?

[Seth Forshee (sforshee)]

Submitted upstream - https://gerrit.openafs.org/#/c/12714/

[Seth Forshee (sforshee)]

Attaching debdiff for openafs 1.6.21-2ubuntu1 to fix this in Ubuntu until the fix is available in Debian.

[Nish Aravamudan (nacc)]

Sponsored to artful, thanks Seth!

[Launchpad Janitor (janitor)]

This bug was fixed in the package openafs - 1.6.21-2ubuntu1

---------------
openafs (1.6.21-2ubuntu1) artful; urgency=medium

  * debian/patches:
    - Linux-Include-linux-uaccess.h-rather-than-asm-uacces.patch (LP: #1711835)

 -- Seth Forshee <email address hidden> Thu, 24 Aug 2017 11:00:58 -0700