| 2019-12-09 09:55:05 |
Christian Ehrhardt |
bug |
|
|
added bug |
| 2019-12-09 09:55:23 |
Christian Ehrhardt |
nominated for series |
|
Ubuntu Bionic |
|
| 2019-12-09 09:55:23 |
Christian Ehrhardt |
bug task added |
|
open-vm-tools (Ubuntu Bionic) |
|
| 2019-12-09 09:55:23 |
Christian Ehrhardt |
nominated for series |
|
Ubuntu Focal |
|
| 2019-12-09 09:55:23 |
Christian Ehrhardt |
bug task added |
|
open-vm-tools (Ubuntu Focal) |
|
| 2019-12-09 09:55:23 |
Christian Ehrhardt |
nominated for series |
|
Ubuntu Eoan |
|
| 2019-12-09 09:55:23 |
Christian Ehrhardt |
bug task added |
|
open-vm-tools (Ubuntu Eoan) |
|
| 2019-12-09 09:55:23 |
Christian Ehrhardt |
nominated for series |
|
Ubuntu Disco |
|
| 2019-12-09 09:55:23 |
Christian Ehrhardt |
bug task added |
|
open-vm-tools (Ubuntu Disco) |
|
| 2019-12-09 09:55:29 |
Christian Ehrhardt |
open-vm-tools (Ubuntu Bionic): status |
New |
Triaged |
|
| 2019-12-09 09:55:31 |
Christian Ehrhardt |
open-vm-tools (Ubuntu Disco): status |
New |
Triaged |
|
| 2019-12-09 09:55:33 |
Christian Ehrhardt |
open-vm-tools (Ubuntu Eoan): status |
New |
Triaged |
|
| 2019-12-09 09:55:35 |
Christian Ehrhardt |
open-vm-tools (Ubuntu Focal): status |
New |
Triaged |
|
| 2019-12-09 10:13:01 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/open-vm-tools/+git/open-vm-tools/+merge/376508 |
|
| 2019-12-09 10:13:27 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/open-vm-tools/+git/open-vm-tools/+merge/376509 |
|
| 2019-12-09 10:13:51 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/open-vm-tools/+git/open-vm-tools/+merge/376510 |
|
| 2019-12-09 10:14:16 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/open-vm-tools/+git/open-vm-tools/+merge/376511 |
|
| 2019-12-09 10:16:01 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/open-vm-tools/+git/open-vm-tools/+merge/376512 |
|
| 2019-12-09 10:21:41 |
Christian Ehrhardt |
description |
[Impact]
* The bump to version 11 exposed an issue of a crash with lsb_output being broken.
* The fix avoids the segfault by validating the pointer before usage
[Test Case]
* Take a system that runs under VMWare (otherwise it will fast-path skip and exit before the bug)
* Modify /usr/bin/lsb_release to remove e.g. the "-i" option (that would trigger the bug)
* (re)start the vmtoolsd service/program which will crash without the fix
[Regression Potential]
* The change makes a check before accessing a (potentially bad) pointer. That makes it every so
slightly slower but it isn't a fast path anyway. The regression risk should therefore be rather
low. I have discussed with upstream if there also should be a strlen check, but that was denied and we are following them on that.
[Other Info]
* We stopped releasing v11 (bug 1844834), I'll generate the uploads in a way to have the bug 1844834 included as from a users POV it will be the first time v11 hits -updates. Only on Eoan where it is already released the changes file to upload will only cover the new bug.
* Removed some whitespace damage from the upstream change |
[Impact]
* The bump to version 11 exposed an issue of a crash with lsb_output being broken.
* The fix avoids the segfault by validating the pointer before usage
[Test Case]
* Take a system that runs under VMWare (otherwise it will fast-path skip and exit before the bug)
* Modify /usr/bin/lsb_release to remove e.g. the "-i" option (that would trigger the bug, see below for a diff)
* (re)start the vmtoolsd service/program which will crash without the fix
[Regression Potential]
* The change makes a check before accessing a (potentially bad) pointer. That makes it every so
slightly slower but it isn't a fast path anyway. The regression risk should therefore be rather
low. I have discussed with upstream if there also should be a strlen check, but that was denied and we are following them on that.
[Other Info]
* We stopped releasing v11 (bug 1844834), I'll generate the uploads in a way to have the bug 1844834 included as from a users POV it will be the first time v11 hits -updates. Only on Eoan where it is already released the changes file to upload will only cover the new bug.
* Removed some whitespace damage from the upstream change
Diff to remove the -i option:
--- /usr/bin/lsb_release 2017-08-07 21:55:07.000000000 +0000
+++ /usr/bin/lsb_release.new 2019-12-09 10:32:18.335776254 +0000
@@ -29,9 +29,6 @@
parser.add_option('-v', '--version', dest='version', action='store_true',
default=False,
help="show LSB modules this system supports")
- parser.add_option('-i', '--id', dest='id', action='store_true',
- default=False,
- help="show distributor ID")
parser.add_option('-d', '--description', dest='description',
default=False, action='store_true',
help="show description of this distribution")
@@ -53,7 +50,7 @@
parser.error("No arguments are permitted")
short = (options.short)
- none = not (options.all or options.version or options.id or
+ none = not (options.all or options.version or
options.description or options.codename or options.release)
distinfo = lsb_release.get_distro_information()
@@ -67,7 +64,7 @@
else:
print('LSB Version:\t' + ':'.join(verinfo))
- if options.id or options.all:
+ if options.all:
if short:
print(distinfo.get('ID', 'n/a'))
else: |
|
| 2019-12-09 10:32:50 |
Christian Ehrhardt |
description |
[Impact]
* The bump to version 11 exposed an issue of a crash with lsb_output being broken.
* The fix avoids the segfault by validating the pointer before usage
[Test Case]
* Take a system that runs under VMWare (otherwise it will fast-path skip and exit before the bug)
* Modify /usr/bin/lsb_release to remove e.g. the "-i" option (that would trigger the bug, see below for a diff)
* (re)start the vmtoolsd service/program which will crash without the fix
[Regression Potential]
* The change makes a check before accessing a (potentially bad) pointer. That makes it every so
slightly slower but it isn't a fast path anyway. The regression risk should therefore be rather
low. I have discussed with upstream if there also should be a strlen check, but that was denied and we are following them on that.
[Other Info]
* We stopped releasing v11 (bug 1844834), I'll generate the uploads in a way to have the bug 1844834 included as from a users POV it will be the first time v11 hits -updates. Only on Eoan where it is already released the changes file to upload will only cover the new bug.
* Removed some whitespace damage from the upstream change
Diff to remove the -i option:
--- /usr/bin/lsb_release 2017-08-07 21:55:07.000000000 +0000
+++ /usr/bin/lsb_release.new 2019-12-09 10:32:18.335776254 +0000
@@ -29,9 +29,6 @@
parser.add_option('-v', '--version', dest='version', action='store_true',
default=False,
help="show LSB modules this system supports")
- parser.add_option('-i', '--id', dest='id', action='store_true',
- default=False,
- help="show distributor ID")
parser.add_option('-d', '--description', dest='description',
default=False, action='store_true',
help="show description of this distribution")
@@ -53,7 +50,7 @@
parser.error("No arguments are permitted")
short = (options.short)
- none = not (options.all or options.version or options.id or
+ none = not (options.all or options.version or
options.description or options.codename or options.release)
distinfo = lsb_release.get_distro_information()
@@ -67,7 +64,7 @@
else:
print('LSB Version:\t' + ':'.join(verinfo))
- if options.id or options.all:
+ if options.all:
if short:
print(distinfo.get('ID', 'n/a'))
else: |
[Impact]
* The bump to version 11 exposed an issue of a crash with lsb_output being broken.
* The fix avoids the segfault by validating the pointer before usage
[Test Case]
* Take a system that runs under VMWare (otherwise it will fast-path skip and exit before the bug)
* Modify /usr/bin/lsb_release to remove e.g. the "-i" option (that would trigger the bug, see below for a diff)
* (re)start the vmtoolsd service/program which will crash without the fix
* This can be done via the service or directly calling the daemon
* Please do note that the crash on my test system takes ~30 seconds so give it some time.
$ sudo time /usr/bin/vmtoolsd
Command terminated by signal 11
0.19user 0.05system 0:30.47elapsed 0%CPU (0avgtext+0avgdata 11532maxresident)k
0inputs+16outputs (0major+3794minor)pagefaults 0swaps
[Regression Potential]
* The change makes a check before accessing a (potentially bad) pointer. That makes it every so
slightly slower but it isn't a fast path anyway. The regression risk should therefore be rather
low. I have discussed with upstream if there also should be a strlen check, but that was denied and we are following them on that.
[Other Info]
* We stopped releasing v11 (bug 1844834), I'll generate the uploads in a way to have the bug 1844834 included as from a users POV it will be the first time v11 hits -updates. Only on Eoan where it is already released the changes file to upload will only cover the new bug.
* Removed some whitespace damage from the upstream change
Diff to remove the -i option:
--- /usr/bin/lsb_release 2017-08-07 21:55:07.000000000 +0000
+++ /usr/bin/lsb_release.new 2019-12-09 10:32:18.335776254 +0000
@@ -29,9 +29,6 @@
parser.add_option('-v', '--version', dest='version', action='store_true',
default=False,
help="show LSB modules this system supports")
- parser.add_option('-i', '--id', dest='id', action='store_true',
- default=False,
- help="show distributor ID")
parser.add_option('-d', '--description', dest='description',
default=False, action='store_true',
help="show description of this distribution")
@@ -53,7 +50,7 @@
parser.error("No arguments are permitted")
short = (options.short)
- none = not (options.all or options.version or options.id or
+ none = not (options.all or options.version or
options.description or options.codename or options.release)
distinfo = lsb_release.get_distro_information()
@@ -67,7 +64,7 @@
else:
print('LSB Version:\t' + ':'.join(verinfo))
- if options.id or options.all:
+ if options.all:
if short:
print(distinfo.get('ID', 'n/a'))
else: |
|
| 2019-12-11 16:15:35 |
Launchpad Janitor |
open-vm-tools (Ubuntu Focal): status |
Triaged |
Fix Released |
|
| 2019-12-12 10:42:00 |
Robie Basak |
open-vm-tools (Ubuntu Eoan): status |
Triaged |
Fix Committed |
|
| 2019-12-12 10:42:03 |
Robie Basak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-12-12 10:42:06 |
Robie Basak |
bug |
|
|
added subscriber SRU Verification |
| 2019-12-12 10:42:09 |
Robie Basak |
tags |
|
verification-needed verification-needed-eoan |
|
| 2019-12-12 10:43:05 |
Robie Basak |
open-vm-tools (Ubuntu Disco): status |
Triaged |
Fix Committed |
|
| 2019-12-12 10:43:10 |
Robie Basak |
tags |
verification-needed verification-needed-eoan |
verification-needed verification-needed-disco verification-needed-eoan |
|
| 2019-12-12 10:43:48 |
Robie Basak |
open-vm-tools (Ubuntu Bionic): status |
Triaged |
Fix Committed |
|
| 2019-12-12 10:43:54 |
Robie Basak |
tags |
verification-needed verification-needed-disco verification-needed-eoan |
verification-needed verification-needed-bionic verification-needed-disco verification-needed-eoan |
|
| 2019-12-12 14:08:23 |
Christian Ehrhardt |
tags |
verification-needed verification-needed-bionic verification-needed-disco verification-needed-eoan |
verification-done verification-done-bionic verification-done-disco verification-done-eoan |
|
| 2019-12-19 10:05:50 |
Launchpad Janitor |
open-vm-tools (Ubuntu Eoan): status |
Fix Committed |
Fix Released |
|
| 2019-12-19 10:05:54 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2019-12-19 10:21:18 |
Launchpad Janitor |
open-vm-tools (Ubuntu Disco): status |
Fix Committed |
Fix Released |
|
| 2019-12-19 10:21:18 |
Launchpad Janitor |
bug watch added |
|
https://github.com/vmware/open-vm-tools/issues/378 |
|
| 2019-12-19 10:21:18 |
Launchpad Janitor |
bug watch added |
|
https://gitlab.com/apparmor/apparmor/issues/13 |
|
| 2019-12-19 10:22:57 |
Launchpad Janitor |
open-vm-tools (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
