open-iscsi - check upgrade paths for failures

[Rafael David Tinoco]

17:27 <andreas> rafaeldtinoco: I was upgrading my irc proxy and saw this:
17:27 <andreas> Setting up open-iscsi (2.0.874-7.1ubuntu6.1) ...
17:27 <andreas> Installing new version of config file /etc/iscsi/iscsid.conf ...
17:27 <andreas> grep: /lib/modules-load.d/open-iscsi.conf: No such file or directory
17:27 <andreas> it didn't fail the upgrade, though
17:27 <andreas> that was on focal
17:30 <andreas> looks like that grep has been there since 2015

----

Since I'm merging new open-iscsi version from Debian I thought about giving a look in previous versions and see if there is anything worth SRUing, like the issue pointed out by @ahasenack.

[Rafael David Tinoco (rafaeldtinoco)]

So, this is Fix Released for Groovy:

commit 2a24c96
Author: Rafael David Tinoco <email address hidden>
Date: Wed Aug 12 22:45:33 2020

    * debian/open-iscsi.kmod drop: (LP: #1833586)
      no static module list is needed if we let iscsid load modules itself.

with:

- # We switched over to modules-load.d logic, this is needed
- MODULES_FILE=/lib/modules-load.d/open-iscsi.conf
- if [ -f /etc/modules-load.d/open-iscsi.conf ] ; then
- MODULES_FILE=/etc/modules-load.d/open-iscsi.conf
- fi
- grep '^[^#]' $MODULES_FILE | while read module args ; do
- [ "$module" ] || continue
- modprobe $module $args >/dev/null 2>&1 || true
- done
-

[Rafael David Tinoco (rafaeldtinoco)]

This upgrade path:

  configure)
        # We switched over to modules-load.d logic, so we have to take
        # care of this in postinst now.
        MODULES_FILE=/lib/modules-load.d/open-iscsi.conf
        if [ -f /etc/modules-load.d/open-iscsi.conf ] ; then
            MODULES_FILE=/etc/modules-load.d/open-iscsi.conf
        fi
        grep '^[^#]' $MODULES_FILE | while read module args ; do
            [ "$module" ] || continue
            modprobe $module $args >/dev/null 2>&1 || true
        done

should make sure MODULES_FILE exists before trying to grep things out of it.

Unfortunately I'm not entirely convinced this worths a SRU.

I'll mark this as a duplicate of: LP: #1833586

[Rafael David Tinoco (rafaeldtinoco)]

Marked as a duplicate because it is the same root cause (having open-iscsi trying to load nfs related kernel modules), different the original approach of letting iscsid to deal with the module loading.