| 2019-03-21 22:14:28 |
Cody Shepherd |
bug |
|
|
added bug |
| 2019-03-21 23:09:26 |
Steve Langasek |
open-iscsi (Ubuntu): importance |
Undecided |
High |
|
| 2019-03-21 23:09:26 |
Steve Langasek |
open-iscsi (Ubuntu): status |
New |
Triaged |
|
| 2019-03-21 23:09:56 |
Steve Langasek |
nominated for series |
|
Ubuntu Bionic |
|
| 2019-03-21 23:09:56 |
Steve Langasek |
bug task added |
|
open-iscsi (Ubuntu Bionic) |
|
| 2019-03-21 23:10:20 |
Steve Langasek |
open-iscsi (Ubuntu Bionic): status |
New |
Triaged |
|
| 2019-03-21 23:10:22 |
Steve Langasek |
open-iscsi (Ubuntu Bionic): importance |
Undecided |
High |
|
| 2019-03-26 19:21:40 |
Dan Streetman |
bug |
|
|
added subscriber Dan Streetman |
| 2019-03-28 19:12:30 |
Heitor Alves de Siqueira |
description |
Iscsid restart fails when killed with a SIGTERM.
Conditions:
Iscsid restart policy set to "Always" via a .conf file in /etc/systemd/system/iscsid.service.d/, with the contents:
[Service]
Restart=always
Steps to Reproduce:
1. Confirm iscsid is running, e.g.
$ ps aux | grep iscsid
or
$ pgrep iscsid
2. Kill the pid(s) with SIGTERM, e.g.
$ sudo kill -15 <pid>
or
$ sudo pkill iscsid
3. Confirm that iscsid has not restarted
$ systemctl status iscsid
This bug affects 18.04, but not 16.04. This hasn't been tested on 18.10 or later. |
[Impact]
iscsid restart fails when killed with SIGTERM
[Description]
If systemd tries to execute a command that talks to iscsid via iscsid.socket, it
can hang if iscsid is not running (or is in the process of being stopped). This can
happen due to the current ExecStop= directive, which calls iscsiadm to kill
iscsid, and prevents the service from being restarted even when we set
Restart=always in the iscsid unit file.
The solution is to let systemd terminate iscsid by itself. The default action
when omitting the ExecStop directive is to send SIGTERM to the process group,
which is equivalent to invoking "iscsiadm -k" (the current ExecStop command).
[Test Case]
1) Deploy a Disco VM e.g. with uvt-kvm
$ uvt-kvm create disco release=disco
2) Run the deploy-tgt.sh script in the VM to setup an iSCSI target in the
localhost. The script will install tgt and open-iscsi, configure a 1G
file-backed iSCSI target, login and restart iscsid.service
ubuntu@disco:~$ ./deploy-tgt.sh
3) Kill iscsid with SIGTERM
ubuntu@disco:~$ sudo pkill iscsid
4) Try to stop iscsid.service and check whether it hangs
ubuntu@disco:~$ sudo systemctl stop iscsid
If we remove the ExecStop= directive, it works as expected:
ubuntu@disco:~$ sudo systemctl stop iscsid
ubuntu@disco:~$
This also causes Restart=always to work as expected.
[Regression Potential]
This shouldn't introduce any regressions, since iscsiadm -k just sends SIGTERM
to iscsid's process group and that's equivalent to the default systemd ExecStop
action. Nonetheless, changes will be tested with autopkgtests and different
iscsi scenarios. |
|
| 2019-03-28 19:12:43 |
Heitor Alves de Siqueira |
nominated for series |
|
Ubuntu Disco |
|
| 2019-03-28 19:12:43 |
Heitor Alves de Siqueira |
bug task added |
|
open-iscsi (Ubuntu Disco) |
|
| 2019-03-28 19:12:43 |
Heitor Alves de Siqueira |
nominated for series |
|
Ubuntu Cosmic |
|
| 2019-03-28 19:12:43 |
Heitor Alves de Siqueira |
bug task added |
|
open-iscsi (Ubuntu Cosmic) |
|
| 2019-03-28 19:13:17 |
Heitor Alves de Siqueira |
open-iscsi (Ubuntu Bionic): status |
Triaged |
Confirmed |
|
| 2019-03-28 19:13:20 |
Heitor Alves de Siqueira |
open-iscsi (Ubuntu Cosmic): status |
New |
Confirmed |
|
| 2019-03-28 19:13:22 |
Heitor Alves de Siqueira |
open-iscsi (Ubuntu Disco): status |
Triaged |
Confirmed |
|
| 2019-03-28 19:13:27 |
Heitor Alves de Siqueira |
open-iscsi (Ubuntu Cosmic): importance |
Undecided |
High |
|
| 2019-03-28 19:13:35 |
Heitor Alves de Siqueira |
open-iscsi (Ubuntu Disco): assignee |
|
Heitor R. Alves de Siqueira (halves) |
|
| 2019-03-28 19:13:38 |
Heitor Alves de Siqueira |
open-iscsi (Ubuntu Cosmic): assignee |
|
Heitor R. Alves de Siqueira (halves) |
|
| 2019-03-28 19:13:40 |
Heitor Alves de Siqueira |
open-iscsi (Ubuntu Bionic): assignee |
|
Heitor R. Alves de Siqueira (halves) |
|
| 2019-03-28 19:14:32 |
Heitor Alves de Siqueira |
attachment added |
|
deploy-tgt.sh https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1821255/+attachment/5250279/+files/deploy-tgt.sh |
|
| 2019-03-28 19:15:40 |
Heitor Alves de Siqueira |
description |
[Impact]
iscsid restart fails when killed with SIGTERM
[Description]
If systemd tries to execute a command that talks to iscsid via iscsid.socket, it
can hang if iscsid is not running (or is in the process of being stopped). This can
happen due to the current ExecStop= directive, which calls iscsiadm to kill
iscsid, and prevents the service from being restarted even when we set
Restart=always in the iscsid unit file.
The solution is to let systemd terminate iscsid by itself. The default action
when omitting the ExecStop directive is to send SIGTERM to the process group,
which is equivalent to invoking "iscsiadm -k" (the current ExecStop command).
[Test Case]
1) Deploy a Disco VM e.g. with uvt-kvm
$ uvt-kvm create disco release=disco
2) Run the deploy-tgt.sh script in the VM to setup an iSCSI target in the
localhost. The script will install tgt and open-iscsi, configure a 1G
file-backed iSCSI target, login and restart iscsid.service
ubuntu@disco:~$ ./deploy-tgt.sh
3) Kill iscsid with SIGTERM
ubuntu@disco:~$ sudo pkill iscsid
4) Try to stop iscsid.service and check whether it hangs
ubuntu@disco:~$ sudo systemctl stop iscsid
If we remove the ExecStop= directive, it works as expected:
ubuntu@disco:~$ sudo systemctl stop iscsid
ubuntu@disco:~$
This also causes Restart=always to work as expected.
[Regression Potential]
This shouldn't introduce any regressions, since iscsiadm -k just sends SIGTERM
to iscsid's process group and that's equivalent to the default systemd ExecStop
action. Nonetheless, changes will be tested with autopkgtests and different
iscsi scenarios. |
[Impact]
iscsid restart fails when killed with SIGTERM
[Description]
If systemd tries to execute a command that talks to iscsid via iscsid.socket, it can hang if iscsid is not running (or is in the process of being stopped). This can happen due to the current ExecStop= directive, which calls iscsiadm to kill iscsid, and prevents the service from being restarted even when we set Restart=always in the iscsid unit file.
The solution is to let systemd terminate iscsid by itself. The default action
when omitting the ExecStop directive is to send SIGTERM to the process group,
which is equivalent to invoking "iscsiadm -k" (the current ExecStop command).
[Test Case]
1) Deploy a Disco VM e.g. with uvt-kvm
$ uvt-kvm create disco release=disco
2) Run the deploy-tgt.sh script in the VM to setup an iSCSI target in the
localhost. The script will install tgt and open-iscsi, configure a 1G
file-backed iSCSI target, login and restart iscsid.service
ubuntu@disco:~$ ./deploy-tgt.sh
3) Kill iscsid with SIGTERM
ubuntu@disco:~$ sudo pkill iscsid
4) Try to stop iscsid.service and check whether it hangs
ubuntu@disco:~$ sudo systemctl stop iscsid
If we remove the ExecStop= directive, it works as expected:
ubuntu@disco:~$ sudo systemctl stop iscsid
ubuntu@disco:~$
This also causes Restart=always to work as expected.
[Regression Potential]
This shouldn't introduce any regressions, since iscsiadm -k just sends SIGTERM to iscsid's process group and that's equivalent to the default systemd ExecStop action. Nonetheless, changes will be tested with autopkgtests and different iscsi scenarios. |
|
| 2019-03-28 19:25:09 |
Heitor Alves de Siqueira |
tags |
|
sts |
|
| 2019-03-28 19:27:10 |
Heitor Alves de Siqueira |
attachment added |
|
lp1821255-bionic.debdiff https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1821255/+attachment/5250281/+files/lp1821255-bionic.debdiff |
|
| 2019-03-28 19:27:26 |
Heitor Alves de Siqueira |
attachment added |
|
lp1821255-cosmic.debdiff https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1821255/+attachment/5250282/+files/lp1821255-cosmic.debdiff |
|
| 2019-03-28 19:27:38 |
Heitor Alves de Siqueira |
attachment added |
|
lp1821255-disco.debdiff https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1821255/+attachment/5250283/+files/lp1821255-disco.debdiff |
|
| 2019-03-28 19:32:56 |
Heitor Alves de Siqueira |
tags |
sts |
sts sts-sponsor |
|
| 2019-03-28 19:33:23 |
Heitor Alves de Siqueira |
bug |
|
|
added subscriber STS Sponsors |
| 2019-03-28 19:53:12 |
Eric Desrochers |
open-iscsi (Ubuntu Disco): status |
Confirmed |
In Progress |
|
| 2019-03-28 20:19:45 |
Heitor Alves de Siqueira |
bug watch added |
|
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900397 |
|
| 2019-03-28 20:22:57 |
Ubuntu Foundations Team Bug Bot |
tags |
sts sts-sponsor |
patch sts sts-sponsor |
|
| 2019-03-28 20:23:07 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2019-04-01 17:45:55 |
Eric Desrochers |
open-iscsi (Ubuntu Disco): status |
In Progress |
Fix Committed |
|
| 2019-04-01 18:08:25 |
Paul Graydon |
bug |
|
|
added subscriber Paul Graydon |
| 2019-04-01 22:04:59 |
Launchpad Janitor |
open-iscsi (Ubuntu Disco): status |
Fix Committed |
Fix Released |
|
| 2019-04-02 13:37:27 |
Eric Desrochers |
open-iscsi (Ubuntu Cosmic): status |
Confirmed |
In Progress |
|
| 2019-04-02 13:37:29 |
Eric Desrochers |
open-iscsi (Ubuntu Bionic): status |
Confirmed |
In Progress |
|
| 2019-04-02 15:57:07 |
Eric Desrochers |
removed subscriber STS Sponsors |
|
|
|
| 2019-04-02 15:57:10 |
Eric Desrochers |
bug |
|
|
added subscriber Eric Desrochers |
| 2019-04-02 18:40:47 |
Brian Murray |
open-iscsi (Ubuntu Cosmic): status |
In Progress |
Fix Committed |
|
| 2019-04-02 18:40:51 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-04-02 18:40:54 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2019-04-02 18:40:59 |
Brian Murray |
tags |
patch sts sts-sponsor |
patch sts sts-sponsor verification-needed verification-needed-cosmic |
|
| 2019-04-02 18:42:07 |
Brian Murray |
open-iscsi (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2019-04-02 18:42:13 |
Brian Murray |
tags |
patch sts sts-sponsor verification-needed verification-needed-cosmic |
patch sts sts-sponsor verification-needed verification-needed-bionic verification-needed-cosmic |
|
| 2019-04-02 18:42:20 |
Brian Murray |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2019-04-02 19:58:23 |
Heitor Alves de Siqueira |
tags |
patch sts sts-sponsor verification-needed verification-needed-bionic verification-needed-cosmic |
patch sts sts-sponsor verification-done-bionic verification-needed verification-needed-cosmic |
|
| 2019-04-02 20:00:58 |
Heitor Alves de Siqueira |
tags |
patch sts sts-sponsor verification-done-bionic verification-needed verification-needed-cosmic |
patch sts sts-sponsor verification-done-bionic verification-done-cosmic |
|
| 2019-04-10 15:49:29 |
Dan Streetman |
tags |
patch sts sts-sponsor verification-done-bionic verification-done-cosmic |
patch sts verification-done-bionic verification-done-cosmic |
|
| 2019-04-11 07:36:43 |
Launchpad Janitor |
open-iscsi (Ubuntu Cosmic): status |
Fix Committed |
Fix Released |
|
| 2019-04-11 07:36:48 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2019-04-11 08:10:12 |
Launchpad Janitor |
open-iscsi (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
