Activity log for bug #1785108

Date Who What changed Old value New value Message
2018-08-02 17:51:35 Scott Moser bug added bug
2018-08-02 17:51:51 Scott Moser open-iscsi (Ubuntu): status New Confirmed
2018-08-02 17:51:58 Scott Moser open-iscsi (Ubuntu): importance Undecided Medium
2018-08-02 18:11:39 Scott Moser description === Begin SRU Template === [Impact] Incorrect handling of udev events by open-iscsi's net-interface-handler results in nameserver and dns search entries being removed from /etc/resolv.conf and thus potentially breaking dns on a system. This problem is limited to iscsi-root systems, but is easily tripped by common use of linux networking. This was first discovered on Oracle Public Cloud, which utilizes iscsi-root for its systems. [Test Case] 1. Start a system with iscsi root. One such easily obtained environment is Oracle Public Cloud. 2. Collect resolvconf and ifupdown state mkdir before cp -a /run/resolvconf before/run-resolvconf cp /etc/resolv.conf before/etc-resolv.conf cp -a /run/network before/run-network 3. Create a tun/tap device sudo ip tuntap add mode tap user root mytap0 4. Remove the tun/tap device. sudo ip tuntap del mode tap mytap0 5. Collect resolvconf and ifupdown state and compare against '2'. The creation and removal of a tuntap device should not have affected resolvconf or ifupdown state. mkdir after cp -a /run/resolvconf after/run-resolvconf cp /etc/resolv.conf after/etc-resolv.conf cp -a /run/network after/run-network diff -Naur before/ after/ [Regression Potential] The codepath executed was and is entirely limited to systems with iscsi-root. So regressions should also be limited as such. The most likely regression would seem to be the failure to add or remove entries to resolvconf for the iscsi-root interface. Before this was happening to often. A bad fix could result in it happening not enough. [Other Info] net-interface-handler is currently executing 'resolvconf -a' on all new network interfaces and 'resolvconf -d' on removal of all network interfaces. The problem with that is that an add and remove of any new interface will have the result of effectively marking the iscsi-root interface down. That includes removing the resolvconf entries for that interface. This add/remove can happen for any number of reasons. Two such examples: a.) docker container create/delete - sudo apt-get install -qy docker.io - sudo docker run --rm busybox date b.) add/remove of a tuntap device. - sudo ip tuntap add mode tap user root mytap0 - sudo ip tuntap del mode tap mytap0 === End SRU Template === ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: open-iscsi 2.0.873+git0.3b4b4500-14ubuntu3.4 [modified: lib/open-iscsi/net-interface-handler] ProcVersionSignature: User Name 4.4.0-130.156-generic 4.4.134 Uname: Linux 4.4.0-130-generic x86_64 ApportVersion: 2.20.1-0ubuntu2.18 Architecture: amd64 Date: Thu Aug 2 17:18:06 2018 ProcEnviron: TERM=xterm-256color PATH=(custom, no user) XDG_RUNTIME_DIR=<set> LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: open-iscsi UpgradeStatus: No upgrade log present (probably fresh install) modified.conffile..etc.iscsi.iscsid.conf: [inaccessible: [Errno 13] Permission denied: '/etc/iscsi/iscsid.conf'] === Begin SRU Template === [Impact] Incorrect handling of udev events by open-iscsi's net-interface-handler results in nameserver and dns search entries being removed from /etc/resolv.conf and thus potentially breaking dns on a system. This problem is limited to iscsi-root systems, but is easily tripped by common use of linux networking. This was first discovered on Oracle Public Cloud, which utilizes iscsi-root for its systems. [Test Case] 1. Start a system with iscsi root. One such easily obtained environment is Oracle Public Cloud. 2. Collect resolvconf and ifupdown state name="before"    mkdir $name    cp -r /run/resolvconf $name/run-resolvconf    cp /etc/resolv.conf $name/etc-resolv.conf    cp -r /run/network $name/run-network 3. Create a tun/tap device    sudo ip tuntap add mode tap user root mytap0 4. Remove the tun/tap device.    sudo ip tuntap del mode tap mytap0 5. Collect resolvconf and ifupdown state and compare against '2'. The creation and removal of a tuntap device should not have affected resolvconf or ifupdown state. The 'diff' at the end should not show any differences. name="after"    mkdir $name    cp -r /run/resolvconf $name/run-resolvconf    cp /etc/resolv.conf $name/etc-resolv.conf    cp -r /run/network $name/run-network    diff -Naur before/ after/ [Regression Potential] The codepath executed was and is entirely limited to systems with iscsi-root. So regressions should also be limited as such. The most likely regression would seem to be the failure to add or remove entries to resolvconf for the iscsi-root interface. Before this was happening to often. A bad fix could result in it happening not enough. [Other Info] net-interface-handler is currently executing 'resolvconf -a' on all new network interfaces and 'resolvconf -d' on removal of all network interfaces. The problem with that is that an add and remove of any new interface will have the result of effectively marking the iscsi-root interface down. That includes removing the resolvconf entries for that interface. This add/remove can happen for any number of reasons. Two such examples:  a.) docker container create/delete      - sudo apt-get install -qy docker.io      - sudo docker run --rm busybox date  b.) add/remove of a tuntap device.      - sudo ip tuntap add mode tap user root mytap0      - sudo ip tuntap del mode tap mytap0 === End SRU Template === ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: open-iscsi 2.0.873+git0.3b4b4500-14ubuntu3.4 [modified: lib/open-iscsi/net-interface-handler] ProcVersionSignature: User Name 4.4.0-130.156-generic 4.4.134 Uname: Linux 4.4.0-130-generic x86_64 ApportVersion: 2.20.1-0ubuntu2.18 Architecture: amd64 Date: Thu Aug 2 17:18:06 2018 ProcEnviron:  TERM=xterm-256color  PATH=(custom, no user)  XDG_RUNTIME_DIR=<set>  LANG=en_US.UTF-8  SHELL=/bin/bash SourcePackage: open-iscsi UpgradeStatus: No upgrade log present (probably fresh install) modified.conffile..etc.iscsi.iscsid.conf: [inaccessible: [Errno 13] Permission denied: '/etc/iscsi/iscsid.conf']
2018-08-02 18:25:27 Scott Moser bug added subscriber Francis Ginther
2018-08-02 18:32:51 Launchpad Janitor merge proposal linked https://code.launchpad.net/~smoser/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/352215
2018-08-02 18:51:36 Launchpad Janitor merge proposal linked https://code.launchpad.net/~smoser/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/352216
2018-08-02 20:53:27 Scott Moser nominated for series Ubuntu Cosmic
2018-08-02 20:53:27 Scott Moser bug task added open-iscsi (Ubuntu Cosmic)
2018-08-02 20:53:27 Scott Moser nominated for series Ubuntu Xenial
2018-08-02 20:53:27 Scott Moser bug task added open-iscsi (Ubuntu Xenial)
2018-08-02 20:53:27 Scott Moser nominated for series Ubuntu Bionic
2018-08-02 20:53:27 Scott Moser bug task added open-iscsi (Ubuntu Bionic)
2018-08-02 20:53:39 Scott Moser open-iscsi (Ubuntu Cosmic): importance Medium Low
2018-08-02 20:53:42 Scott Moser open-iscsi (Ubuntu Bionic): importance Undecided Low
2018-08-02 20:53:47 Scott Moser open-iscsi (Ubuntu Bionic): status New Confirmed
2018-08-02 20:53:51 Scott Moser open-iscsi (Ubuntu Xenial): status New Confirmed
2018-08-02 20:53:55 Scott Moser open-iscsi (Ubuntu Xenial): importance Undecided High
2018-08-07 22:50:56 Launchpad Janitor open-iscsi (Ubuntu Cosmic): status Confirmed Fix Released
2018-08-08 11:59:29 Scott Moser description === Begin SRU Template === [Impact] Incorrect handling of udev events by open-iscsi's net-interface-handler results in nameserver and dns search entries being removed from /etc/resolv.conf and thus potentially breaking dns on a system. This problem is limited to iscsi-root systems, but is easily tripped by common use of linux networking. This was first discovered on Oracle Public Cloud, which utilizes iscsi-root for its systems. [Test Case] 1. Start a system with iscsi root. One such easily obtained environment is Oracle Public Cloud. 2. Collect resolvconf and ifupdown state name="before"    mkdir $name    cp -r /run/resolvconf $name/run-resolvconf    cp /etc/resolv.conf $name/etc-resolv.conf    cp -r /run/network $name/run-network 3. Create a tun/tap device    sudo ip tuntap add mode tap user root mytap0 4. Remove the tun/tap device.    sudo ip tuntap del mode tap mytap0 5. Collect resolvconf and ifupdown state and compare against '2'. The creation and removal of a tuntap device should not have affected resolvconf or ifupdown state. The 'diff' at the end should not show any differences. name="after"    mkdir $name    cp -r /run/resolvconf $name/run-resolvconf    cp /etc/resolv.conf $name/etc-resolv.conf    cp -r /run/network $name/run-network    diff -Naur before/ after/ [Regression Potential] The codepath executed was and is entirely limited to systems with iscsi-root. So regressions should also be limited as such. The most likely regression would seem to be the failure to add or remove entries to resolvconf for the iscsi-root interface. Before this was happening to often. A bad fix could result in it happening not enough. [Other Info] net-interface-handler is currently executing 'resolvconf -a' on all new network interfaces and 'resolvconf -d' on removal of all network interfaces. The problem with that is that an add and remove of any new interface will have the result of effectively marking the iscsi-root interface down. That includes removing the resolvconf entries for that interface. This add/remove can happen for any number of reasons. Two such examples:  a.) docker container create/delete      - sudo apt-get install -qy docker.io      - sudo docker run --rm busybox date  b.) add/remove of a tuntap device.      - sudo ip tuntap add mode tap user root mytap0      - sudo ip tuntap del mode tap mytap0 === End SRU Template === ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: open-iscsi 2.0.873+git0.3b4b4500-14ubuntu3.4 [modified: lib/open-iscsi/net-interface-handler] ProcVersionSignature: User Name 4.4.0-130.156-generic 4.4.134 Uname: Linux 4.4.0-130-generic x86_64 ApportVersion: 2.20.1-0ubuntu2.18 Architecture: amd64 Date: Thu Aug 2 17:18:06 2018 ProcEnviron:  TERM=xterm-256color  PATH=(custom, no user)  XDG_RUNTIME_DIR=<set>  LANG=en_US.UTF-8  SHELL=/bin/bash SourcePackage: open-iscsi UpgradeStatus: No upgrade log present (probably fresh install) modified.conffile..etc.iscsi.iscsid.conf: [inaccessible: [Errno 13] Permission denied: '/etc/iscsi/iscsid.conf'] === Begin SRU Template === [Impact] Incorrect handling of udev events by open-iscsi's net-interface-handler results in nameserver and dns search entries being removed from /etc/resolv.conf and thus potentially breaking dns on a system. This problem is limited to iscsi-root systems, but is easily tripped by common use of linux networking. This was first discovered on Oracle Public Cloud, which utilizes iscsi-root for its systems. [Test Case] dep8 tests have been backported from cosmic with a functional reproducer. When run without the tests will fail. So passing of dep8 actually indicates that the fix is working. As a manual test case: 1. Start a system with iscsi root. One such easily obtained environment is Oracle Public Cloud. 2. Collect resolvconf and ifupdown state    name="before"    mkdir $name    cp -r /run/resolvconf $name/run-resolvconf    cp /etc/resolv.conf $name/etc-resolv.conf    cp -r /run/network $name/run-network 3. Create a tun/tap device    sudo ip tuntap add mode tap user root mytap0 4. Remove the tun/tap device.    sudo ip tuntap del mode tap mytap0 5. Collect resolvconf and ifupdown state and compare against '2'. The creation and removal of a tuntap device should not have affected resolvconf or ifupdown state. The 'diff' at the end should not show any differences.    name="after"    mkdir $name    cp -r /run/resolvconf $name/run-resolvconf    cp /etc/resolv.conf $name/etc-resolv.conf    cp -r /run/network $name/run-network    diff -Naur before/ after/ [Regression Potential] The codepath executed was and is entirely limited to systems with iscsi-root. So regressions should also be limited as such. The most likely regression would seem to be the failure to add or remove entries to resolvconf for the iscsi-root interface. Before this was happening to often. A bad fix could result in it happening not enough. [Other Info] net-interface-handler is currently executing 'resolvconf -a' on all new network interfaces and 'resolvconf -d' on removal of all network interfaces. The problem with that is that an add and remove of any new interface will have the result of effectively marking the iscsi-root interface down. That includes removing the resolvconf entries for that interface. This add/remove can happen for any number of reasons. Two such examples:  a.) docker container create/delete      - sudo apt-get install -qy docker.io      - sudo docker run --rm busybox date  b.) add/remove of a tuntap device.      - sudo ip tuntap add mode tap user root mytap0      - sudo ip tuntap del mode tap mytap0 === End SRU Template === ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: open-iscsi 2.0.873+git0.3b4b4500-14ubuntu3.4 [modified: lib/open-iscsi/net-interface-handler] ProcVersionSignature: User Name 4.4.0-130.156-generic 4.4.134 Uname: Linux 4.4.0-130-generic x86_64 ApportVersion: 2.20.1-0ubuntu2.18 Architecture: amd64 Date: Thu Aug 2 17:18:06 2018 ProcEnviron:  TERM=xterm-256color  PATH=(custom, no user)  XDG_RUNTIME_DIR=<set>  LANG=en_US.UTF-8  SHELL=/bin/bash SourcePackage: open-iscsi UpgradeStatus: No upgrade log present (probably fresh install) modified.conffile..etc.iscsi.iscsid.conf: [inaccessible: [Errno 13] Permission denied: '/etc/iscsi/iscsid.conf']
2018-08-08 13:57:33 Launchpad Janitor merge proposal linked https://code.launchpad.net/~smoser/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/352757
2018-08-09 22:39:41 Brian Murray open-iscsi (Ubuntu Bionic): status Confirmed Fix Committed
2018-08-09 22:39:43 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2018-08-09 22:39:46 Brian Murray bug added subscriber SRU Verification
2018-08-09 22:39:50 Brian Murray tags amd64 apport-bug uec-images xenial amd64 apport-bug uec-images verification-needed verification-needed-bionic xenial
2018-08-09 22:42:23 Brian Murray open-iscsi (Ubuntu Xenial): status Confirmed Fix Committed
2018-08-09 22:42:28 Brian Murray tags amd64 apport-bug uec-images verification-needed verification-needed-bionic xenial amd64 apport-bug uec-images verification-needed verification-needed-bionic verification-needed-xenial xenial
2018-08-13 15:10:05 Scott Moser attachment added autopkgtest-2.0.873+git0.3b4b4500-14ubuntu3.5.log.gz https://bugs.launchpad.net/bugs/1785108/+attachment/5174768/+files/autopkgtest-2.0.873+git0.3b4b4500-14ubuntu3.5.log.gz
2018-08-13 15:10:09 Scott Moser attachment added autopkgtest-2.0.874-5ubuntu7.log.gz https://bugs.launchpad.net/bugs/1785108/+attachment/5174769/+files/autopkgtest-2.0.874-5ubuntu7.log.gz
2018-08-13 15:10:13 Scott Moser attachment added autopkgtest-2.0.874-5ubuntu2.1.log.gz https://bugs.launchpad.net/bugs/1785108/+attachment/5174770/+files/autopkgtest-2.0.874-5ubuntu2.1.log.gz
2018-08-18 12:38:08 Francis Ginther tags amd64 apport-bug uec-images verification-needed verification-needed-bionic verification-needed-xenial xenial amd64 apport-bug id-5b76d0fbc67b5470c265f714 uec-images verification-needed verification-needed-bionic verification-needed-xenial xenial
2018-08-18 12:50:19 Francis Ginther tags amd64 apport-bug id-5b76d0fbc67b5470c265f714 uec-images verification-needed verification-needed-bionic verification-needed-xenial xenial amd64 apport-bug uec-images verification-done-xenial verification-needed verification-needed-bionic xenial
2018-08-19 12:35:15 Francis Ginther tags amd64 apport-bug uec-images verification-done-xenial verification-needed verification-needed-bionic xenial amd64 apport-bug id-5b76d0fbc67b5470c265f714 uec-images verification-done-xenial verification-needed verification-needed-bionic xenial
2018-08-19 18:17:21 Francis Ginther tags amd64 apport-bug id-5b76d0fbc67b5470c265f714 uec-images verification-done-xenial verification-needed verification-needed-bionic xenial amd64 apport-bug id-5b76d0fbc67b5470c265f714 uec-images verification-done-bionic verification-done-xenial verification-needed xenial
2018-08-19 18:17:41 Francis Ginther tags amd64 apport-bug id-5b76d0fbc67b5470c265f714 uec-images verification-done-bionic verification-done-xenial verification-needed xenial amd64 apport-bug id-5b76d0fbc67b5470c265f714 uec-images verification-done verification-done-bionic verification-done-xenial xenial
2018-08-20 11:12:51 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2018-08-20 11:22:54 Launchpad Janitor open-iscsi (Ubuntu Bionic): status Fix Committed Fix Released
2018-08-20 11:38:37 Launchpad Janitor open-iscsi (Ubuntu Xenial): status Fix Committed Fix Released