sync with debian testing (2.0.873+git0.3b4b4500-13)

[Scott Moser]

We'd like to catch up with debian for open-iscsi.

I've pushed to my ppa (~smoser/+archive/ppa) a merge.
I'll attach debian-to-ubuntu.diff . The ubuntu-to-ubuntu is very large due to upstream changes.

Please see my 'working' branch at https://git.launchpad.net/~smoser/ubuntu/+source/open-iscsi?h=working where I split the ubuntu delta into logical changes.

Then in the 'merge' branch there I merged and almost everything is now up in debian.

My one question is really with regard to dropping of the transitional package (open-iscsi-utils). I belive that is acceptable now.

[Martin Pitt (pitti)]

Uploaded, thanks! Would be nice to drop the ifupdown state hackery at some point by not having an "auto" interface for the iscsi file system any more -- that is just wrong.

[Christian Seiler (christian-w)]

I've just noticed via the Debian Package tracker that you merged with the latest Debian package.

Since I'd like to get the differences between Debian and Ubuntu to a minimum, two questions:

1. Why did you merge back the old Ubuntu test suite? There was a bug open in Debian [1] to merge it into the Debian package. Since I wanted to implement that correctly, I talked to Martin about it, and we came to the conclusion that the whole python testlib.py stuff is not optimal, so we thus decided to drop it. I implemented much simpler autopkgtests.

The only thing that new old Ubuntu test suite could do that the current Debian autopkgtests can't do is that in in principle can test for iSCSI functionality - but only if you manually edit the tests. (remote_server = '', which is in test-open-iscsi.py, disables that by default, because there's no target available by default) I still have an item on the TODO list to automatically test iSCSI functionality by creating a target (see related Debian bug [2], where I really should send a new patch). But if you just look at what is actually tested automatically right now, the "install" test already covers all of that.

But even if you want to merge back in the old test suite, please don't do it in that way: there's a good reason why Depends: is empty for the install tests: because the test wants to ensure that the installation succeeds under different init systems, so it first needs to be able to install a different init system before actually installing the package. Now, Ubuntu only supports systemd nowadays (which is why the Debian upstream test suite skips the sysvinit test on Ubuntu, see debian/tests/sysvinit.inc), so it may not be a huge issue, but to be consistent, please don't merge the Tests: lines and just have them separate, even if you want to keep the old test suite:

Tests: install sysvinit-install
Restrictions: needs-root isolation-machine breaks-testbed
Depends:

Tests: daemon testsuite
Depends: open-iscsi, python
Restrictions: needs-root

2. Why is there actually a need for the network interface handling stuff? So in Debian we don't have that (never had), but I've successfully used root on iSCSI on Debian without having to do such hacks. The reason is that if you look at partman-iscsi (used by debian-installer), it automatically sets the interface to manual when iSCSI is used. And README.Debian clearly documents that you need to use inet manual, so people setting that up for themselves (without the installer, which is possible, but more complicated) have it documented properly.

(Actually, I think 'manual' is technically a bit wrong, because if you are indeed using DHCP and not a static IP configuration, you still need something that renews the DHCP lease, otherwise the address might get reused by the DHCP server. Of course, if the DHCP server gives you a new address, you're screwed, so that shouldn't happen, but renewing the existing address is something that actually should be done. OTOH, if static configuration is used, DHCP shouldn't be done and it should indeed be manual. I know for example that dracut's dhclient script sets a finite valid lifetime for the IPv4 address when using DHCP in...

[Christian Seiler (christian-w)]

I also should note, just looking over the bug reports in Ubuntu, the following should be fixed with the newest version:

https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1123192
   (we don't rmmod at all anymore, and use modules-load.d instead of modprobe in init script)
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1207760
   (we don't stop open-iscsi on package updates anymore, just iscsid, so the sessions should be kept open;
   at shutdown qemu should obviously be terminated before remote filesystems are unmounted)
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1465196
   (this was fixed with ordering, open-iscsi is now early-boot, instead of after remote_fs, which was wrong before)
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1446410
   (iscsistart should be correctly called in current open-iscsi)
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1170284
   (this was fixed in Debian)
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1170284
   (the Debian l18n team reworked the description completely)
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/306693
   (open-iscsi is now separated into open-iscsi and iscsid, the latter is restarted at upgrades)

Well, and then I stopped looking at that point, because that's quite a lot of them.

Obviously, I haven't confirmed that all of these are fixed under current Ubuntu, but I think you could probably close >90% of the bugs in the Ubuntu bugtracker about open-iscsi now.

[Launchpad Janitor (janitor)]

This bug was fixed in the package open-iscsi - 2.0.873+git0.3b4b4500-13ubuntu3

---------------
open-iscsi (2.0.873+git0.3b4b4500-13ubuntu3) xenial; urgency=medium

  * debian/tests/test-open-iscsi.py, debian/tests/testlib.py: fix test suite
    to run correctly in the context of systemd controlling iscsid; teach
    testlib to deal with daemons using 'system $daemon $command', which should
    work both with systemd and sysvinit.

 -- Mathieu Trudel-Lapierre <email address hidden> Tue, 01 Mar 2016 21:16:44 -0500