When setting VoiceUnconditional, change events for unset properties (e.g. VoiceBusy) are not reported

[Jonas G. Drange]

current build number: 68
device name: krillin
channel: ubuntu-touch/rc-proposed/bq-aquaris.en
last update: 2015-07-16 14:50:21
version version: 68
version ubuntu: 20150716
version device: 20150529-8e13c5f
version custom: 20150709-814-29-21-vivid

Reproduce:
1. Unset all call forwarding rules
2. Set VoiceBusy to a non-empty string
3. Set VoiceUnconditional to a non-empty string

What happens:
From 2 I get that "VoiceBusy" changed and from 3 I get that only VoiceConditional changed

What should happen:
I should get that both VoiceConditional changed as well as VoiceBusy changed.

Monitor-ofono:
{CallForwarding} [/ril_0] VoiceBusy = [phone]
{CallForwarding} [/ril_0] VoiceUnconditional = [phone]

[ril_0]
    [ org.ofono.CallForwarding ]
        VoiceNotReachable =
        ForwardingFlagOnSim = 0
        VoiceBusy =
        VoiceNoReply =
        VoiceNoReplyTimeout = 20
        VoiceUnconditional = [phone]

Why is there no change event for VoiceBusy when list-modems report that it is unset?

[Tony Espy (awe)]

@Jonas

We don't use the problem tracker in github. Could you please close it out? Also, your sample command-line has instructed ofono to *not* load the rildev plugin, which we use to determine which ofono modem device plugin to load, so this will definitely cause issues on krillin, vegata, or arale.

Can you please re-test and provide device/image details if you still can reproduce?

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

Apparently the conditional forwardings should report empty numbers when unconditional is se, see this ofono upstream commits:

https://git.kernel.org/cgit/network/ofono/ofono.git/commit/?id=e4488eef1a186e9b715721f0f7e5a20525567bcf
https://git.kernel.org/cgit/network/ofono/ofono.git/commit/?id=0dc3515af468e23bfc0e934ed94c7ca23c06fde9
https://git.kernel.org/cgit/network/ofono/ofono.git/commit/?id=69453afe9eeb2eba2024cd1792d25b5da61a439f

So the bug here is not reporting empty numbers when setting unconditional forwarding (I just leave this as reference, the bug report is good).