latest version obfuscates data in test scripts

[Martin Pitt]

https://launchpad.net/ubuntu/+source/ofono/1.12.bzr6896+15.10.20150521-0ubuntu1 changed the behaviour of the test scripts to obfuscate stuff. E. g. /usr/share/ofono/scripts/list-modems now says "LocationAreaCode = XXX" which is entirely useless.

These are test scripts, not something which you should ever call from a production program, so why was this change done? This is quite a dramatic change from upstream which makes these scripts incompatible with everything that uses it. It also broke e. g. python-dbusmock's tests which check that the mocked ofono is compatible with what the ofono package expects.

[Martin Pitt (pitti)]

Test log link:

https://jenkins.qa.ubuntu.com/job/wily-adt-python-dbusmock/3/ARCH=amd64,label=adt/console

[Tony Espy (awe)]

As mentioned in our discussion on IRC, this was changed because I got tired of asking end-users to self-obfuscate the output of list-modems.

Yes, I know it's contrary to upstream, but I cared more about the impact on end-users. I understand that this kind of thing could be accomplished by apport, but frankly apport is seldom used to report bugs on the phone, and is no help when debugging problems in real-time.

As for why I didn't catch the test failures, we used to run the dialer and messaging app autopilot tests for each ofono upload, however as they were quite unstable on the phone, I eventually gave up.

That said, based upon our discussion on IRC, I've reverted the meaning of the -p/--priv option for the command so that it causes the output to obfuscated, thus the test scripts should work again once this change has landed in the archive and PPA. I'm using the original bug to track, and thus this bug will be made a duplicate.