add "Preferred" property to ConnectionContext interface

[Antti Kaijanmäki]

To implement system-settings APN editor reliably there has to be a Tag field with is an arbitrary non user-visible string that can be set for any Context.

We also need org.ofono.ConnectionManager.AddContext which takes a variant map with prepopulated values for the context to be created, so we can have a function in QOfono QOfonoConnectionManager::addContextWithTag(QString tag).

[Tony Espy (awe)]

We've gone this path before... and met with incredible resistance from upstream ( and so did Jolla ) to this idea, so we went with the smarts for which context is "preferred" delegated to Network Manager and nuntium.

If you still feel strongly about this, we can revisit during the sprint.

[Tony Espy (awe)]

Moved status to Invalid as this isn't something I'm convinced we need.

[Tony Espy (awe)]

Changed back to Incomplete, as this came up again during a meeting this morning to discuss the current state of the APN editor.

I think what's needed is some way to indicate that an APN/context is the preferred APN for a Internet and/or MMS.

I'm not quite sure why a generic tag was proposed, as I think a simple boolean 'Preferred' property would suffice. Doing this also means we wouldn't need to add a new method either.

Note, NetworkManager currently reads the ofono gprs contexts directly from ofono's settings file ( /var/lib/ofono/<IMSI/gprs ), which isn't ideal. I'll create a backlog task for NM, as this really should be done via DBus.

Also, if we were to implement this, NM's ofono code would need to change to honor the 'Preferred' APN, and ignore the other APNs. Nuntium would also have to change to honor this new property as well.

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

This brach

https://github.com/rilmodem/ofono/pull/173

implements a per-context "Preferred" property that can be used freely by the ofono clients to express preference on context activation.

[Jonas G. Drange (jonas-drange)]

Can we use this tag for MMS as well? Since we cannot query nuntium directly (as per [1]).

[1] https://bugs.launchpad.net/ubuntu/+source/nuntium/+bug/1370660/comments/7

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

@Jonas, yes, it can be used for MMS too. There is in fact no restriction on how this flag is used on the ofono side. Whatever needs to be enforced is something between system-settings and NetworkManager. For ofono, it is just a property that can be read and written from outside, and it is not used internally.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ofono - 1.12.bzr6892+15.04.20150407-0ubuntu1

---------------
ofono (1.12.bzr6892+15.04.20150407-0ubuntu1) vivid; urgency=medium

  [ Alfonso Sanchez-Beato ]
  * ubuntu-apndb.c, src/common.c, test-common.c: provision IA APNs
    LTE modems may require a new IA APN for non-GPRS operation,
    this change allows a new IA APN type to be provisioned along
    with Internet and MMS APNs.
  * gril/grilunsol.c: LTE signal strength fix (LP: #1433867)
  * ubuntu-apndb.c: load APNS w/out explict type (LP: #1437200)
  * mtkodem, plugins/mtk.c, unit/tesk-mtkunsol.c: Dynamic MTK firwmare switching
    This change causes the firmware on specific MTK-based phone to be
    dynamically switched/reset based on SIM type and roaming conditions.
  * include, plugins/mtk.c, src/modem.c, gprs.c: set data for just one slot (LP: #1413672)
    Make sure ConnectionManager.Powered property is set for only one slot in
    case the modem is of type dual SIM stand-by.
  * doc, gprs: add 'Preferred' property to GPRS contexts (LP: #1361864)
 -- CI Train Bot <email address hidden> Tue, 07 Apr 2015 06:50:28 +0000

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

Changes for nuntium in

https://github.com/ubuntu-phonedations/nuntium/pull/18

[Tony Espy (awe)]

At a meeting this week, we decided that all of the components that may activate and/or use a context, should set the 'Preferred' flag for the context if it's successfully activated and/or used ( eg. a context is used by ofono for the INITIAL_ATTACH APN request; if this succeeds, ofono will set the context as 'Preferred' ).

As such, I've re-opened the bug tasks for the affected packages ( network-manager, nuntium, and ofono itself ), and made sure we have Ubuntu (RTM) tasks for the same to track their release as updates.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ofono - 1.12.bzr6900+15.10.20150702.3-0ubuntu1

---------------
ofono (1.12.bzr6900+15.10.20150702.3-0ubuntu1) wily; urgency=medium

  [Tony Espy]
  * test/rilmodem/sim: fix testing scripts for arale (LP: #1457775)
  * test: reverse meaning of list-modems -p (LP: #1438715)

  [ Alfonso Sanchez-Beato ]
  * gril: cleanup traces
  * src/gprs.c: set preferred for the used IA APN (LP: #1361864)
  * rilmodem, mtkmodem, plugins/ril.c, plugins/mtk.c: retry when a
    context deactivation request has finished with an error
  * build, include, plugins/c-ares-dns-client.c, src/dns-client.c,
    src/gprs.c: resolve MMS proxy/MMSC host name (LP: #1417976)

  [ Ratchanan Srirattanamet ]
  * build, rilmodem, qcommsimmodem, plugins/ril.c,
    src/radio-settings.c: add multi-sim support for qcommsimmodem

 -- CI Train Bot <email address hidden> Thu, 02 Jul 2015 17:04:18 +0000

[Łukasz Zemczak (sil2100)]

This bug was fixed in the package ofono 1.12.bzr6900+15.04.20150702.3-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ofono (1.12.bzr6900+15.04.20150702.3-0ubuntu1) vivid; urgency=medium

  [Tony Espy]
  * test/rilmodem/sim: fix testing scripts for arale (LP: #1457775)
  * test: reverse meaning of list-modems -p (LP: #1438715)

  [ Alfonso Sanchez-Beato ]
  * gril: cleanup traces
  * src/gprs.c: set preferred for the used IA APN (LP: #1361864)
  * rilmodem, mtkmodem, plugins/ril.c, plugins/mtk.c: retry when a
    context deactivation request has finished with an error
  * build, include, plugins/c-ares-dns-client.c, src/dns-client.c,
    src/gprs.c: resolve MMS proxy/MMSC host name (LP: #1417976)

  [ Ratchanan Srirattanamet ]
  * build, rilmodem, qcommsimmodem, plugins/ril.c,
    src/radio-settings.c: add multi-sim support for qcommsimmodem

 -- CI Train Bot <email address hidden> Thu, 02 Jul 2015 17:04:18 +0000

[Tony Espy (awe)]

network-manager version 0.9.10.0-4ubuntu15.1.6 released to overlay PPA

[Łukasz Zemczak (sil2100)]

This bug was fixed in the package ubuntu-system-settings 0.3+15.04.20150731-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-system-settings (0.3+15.04.20150731-0ubuntu1) vivid; urgency=medium

  [ Ken VanDine ]
  * [cellular/apn] new APN panel made for the new 'Preferred' property,
    as well as the 'ResetContext' method. (LP: #1435360, #1361864,
    #1376714, #1457676, #1424149, #1442646, #1388222)

ubuntu-system-settings (0.3+15.10.20150729.1-0ubuntu2~gcc5.1) wily; urgency=medium

  * No change upload, build with GCC 5.

ubuntu-system-settings (0.3+15.10.20150729.1-0ubuntu1) wily; urgency=medium

  [ Christopher Lee ]
  * Update AP helper so it doesn't attempt to use an unreachable value
    when scrolling.

  [ Ken VanDine ]
  * Added a sleep to give set_forward_on_busy time to finish
  * Use wait_select_single in the wifi dialog and bump the sleep to 1
    second
  * We need to explicitly stop dbus in tearDownClass, fixes lingering
    dbus processes

ubuntu-system-settings (0.3+15.10.20150724-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Manuel de la Pena ]
  * Recompile with the new udm to avoid ABI issues.

ubuntu-system-settings (0.3+15.10.20150722-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * Resync trunk.

  [ Ken VanDine ]
  * Use TextField.write to properly use the OSK Added helper to dismiss
    OSK

  [ jonas-drange ]
  * [tests] avoids setting Interfaces property after the
    Cellular/Phone/About plugins have loaded.

ubuntu-system-settings (0.3+15.10.20150716-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * Resync trunk.

  [ Ken VanDine ]
  * [wifi] Fixed handling of loading extended attributes from the
    MenuModel (LP: #1472505)

  [ handsome_feng<email address hidden> ]
  * Add flickable in time/date page. (LP: #1469076)

  [ jonas-drange ]
  * [phone] make services insensitive when there are no services as well
    as adding autopilot tests for sim services. (LP: #1470779)

ubuntu-system-settings (0.3+15.10.20150708-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ jonas-drange ]
  * Lets the Wi-Fi panel respond to an SSID provided by dispatcher by
    launching a "Connect to" dialogue. (LP: #1241986)

ubuntu-system-settings (0.3+15.10.20150703-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Joerg Berroth ]
  * Added support for 802-1x wireless network configurations. (LP:
    #1241986)

ubuntu-system-settings (0.3+15.10.20150702.3-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Ken VanDine ]
  * Test searching for WiFi instead of Sound, online-accounts now has a
    soundcloud account type (LP: #1468029)

  [ Matthew Paul Thomas ]
  * Changes "Install & Restart" to "Restart & Install" and "Not Now" to
    "Cancel". lp:1359344 (LP: #1359344)

  [ jonas-drange ]
  * implement CFB, CFNRy and CFNRc as well as autopilot tests (LP:
    #1463828)

ubuntu-system-settings (0.3+15.10.20150622-0ubuntu2) wily; urgency=medium

  * debian/control:
    - don't have an alternative depends on system-image-snappy-cli,
      it's d...

[Launchpad Janitor (janitor)]

This bug was fixed in the package network-manager - 0.9.10.0-4ubuntu19

---------------
network-manager (0.9.10.0-4ubuntu19) wily; urgency=medium

  [ Tony Espy ]
  * debian/patches/add_ofono_settings_support.patch: remove code
    that added APN, USERNAME and PASSWORD to NM_SETTING_GSM object.
    NM doesn't actually need access to these settings, and USERNAME/
    PASSWORD can cause issues with NM's secrets needed logic.
  * debian/patches/0001-wwan-add-support-for-using-oFono-as-a-modem-manager.patch,
    debian/patches/lp1461593-add-nm-settings-connection-reset-retries-methods.patch,
    debian/patches/add_ofono_settings_support.patch,
    debian/patches/lp1461593-add-modem-reconnect-delay-to-policy.patch: More changes
    to NMModemOfono's modem_state handling. Added get/set_reset_retries_timeout
    methods to NMSettingsConnection, and use the set method to lower the timeout for
    ofono connections to 30s. Finally added a 5s delay to NM_POLICY's activation
    logic triggered when a modem device is disconnected. This allows modem time to
    settle and NM to process the resulting DBus state changes. (LP: #1461593)
  * debian/patches/0001-wwan-add-support-for-using-oFono-as-a-modem-manager.patch,
    debian/patches/lp1445080-modify-device-modem-avail.patch,
    debian/patches/lp1445080-nm-modem-check-for-set-mm-enabled-func.patch,
    debian/patches/lp1461593-add-modem-reconnect-delay-to-policy.patch: These
    changes collectively fix flight-mode on arale ( and other devices ), due to
    some fundemental race conditions in the ofono logic. (LP: #1445080, #1440917)
  * debian/patches/0001-wwan-add-support-for-using-oFono-as-a-modem-manager.patch,
    debian/patches/add_ofono_settings_support.patch: Add support for the ofono
    gprs-context 'Preferred' property. (LP: #1361864)

  [ Mathieu Trudel-Lapierre ]
  * d/p/0002-wifi-cull-the-scan-list-before-signalling-ScanDone-b.patch:
    Re-add schedule_scan() call after we get the ScanDone signal from the
    supplicant. Otherwise we'd do one scan on startup and never scan again.
    (LP: #1445134)

 -- Mathieu Trudel-Lapierre <email address hidden> Wed, 05 Aug 2015 12:17:28 -0400

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.3+15.10.20150814-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.10.20150814-0ubuntu1) wily; urgency=medium

  [ Ken VanDine ]
  * dismiss_osk after entering text

 -- CI Train Bot <email address hidden> Fri, 14 Aug 2015 19:59:01 +0000