rilmodem/test-sim-online hard-codes 'Serial' match

[Tony Espy]

Although the rilmodem-specific test-sim-online script has a parameter to indicate it's being run in the emulator, and also match parameters for mnc and mcc ( network code / country code ), it hard-codes the modem 'Serial' ( IMEI ) check against the string "000000000000000".

This was found while testing the silo for the following MR:

https://code.launchpad.net/~phablet-team/ofono/low-power-mode-et-al/+merge/224347

If -e or --eumulator are specified, matching against a pre-defined string is OK. In all other cases -i or --imei should be required.

Also, the wiki-based ofono test plan SIM page should be updated to reflect usage of this script for automation:

https://wiki.ubuntu.com/Process/Merges/TestPlans/ofono/SIM

[Martti Piirainen (piiramar)]

This regression (test-sim-online script failing in real HW) will be fixed by oFono pull request https://github.com/rilmodem/ofono/pull/98 .

Additionally, the x86 emulator needs a fix to have the test-sim-online script actually pass with the '--emulator' argument given, see https://code-review.phablet.ubuntu.com/#/c/286/ .

I will update the wiki, too.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ofono - 1.12.bzr6870+14.10.20140721-0ubuntu1

---------------
ofono (1.12.bzr6870+14.10.20140721-0ubuntu1) utopic; urgency=medium

  [ Martti Piirainen ]
  * drivers/rilmodem/sim.c: notify on SIM removal (LP: #1332306)
  * unit/rilmodem/test-sim-online: fix serial number check (LP: #1334867)

  [ Alfonso Sanchez-Beato ]
  * plugins/mtk.c: fix race condition when onlining modem
  * build, drivers/infeonmodem, drivers/rilmodem, gril,
    plugins/infeon.c, plugins/ril.*, unit: add Infeon OEM hooks

  [ Tony Espy ]
  * build, plugins/ubuntu-provision.c, ubuntu-apndb.*: re-named
    provisioning plugin code from android-* to ubuntu-*. Also removed
    code that queries mobile-broadband-provider-info's db, and finally
    implemented a /custom hook for custom apn dbs (LP: #1315509).
 -- Ubuntu daily release <email address hidden> Mon, 21 Jul 2014 18:59:17 +0000