[mako] Crash when setting modem offline

[Tony Espy]

ofono version: 1.12+bzr6848-0ubuntu1
device: *mako* only

This bug was reproduced while testing a new change to the modem power-on sequence logic. In order to reproduce, it's first necessary to stop both NetworkManager and disable the associated Telepathy mission-control account in order to prevent them from interfering with the test scenario. NM can be stopped via upstart. To disable the mission-control account, as the phablet user, run the following command:

$ mc-tool disable ofono/ofono/account0

To reproduce the crash ( as root ):

1. export PATH=/usr/share/ofono/scripts:$PATH
2. restart ofono
3. online-modem; offline-modem ( repeat until ofono crashes )

Ofono crashes in the function gril/gril.c:handle_response(), due to the following assert:

g_assert(count > 0);

This assert is ensuring that there's at least one pending response on the command_queue for which the incoming reply can be compared.

The reason this assert fires, is that there's a bug in the gril.c function ril_cancel_group(), which incorrectly frees a command associated with the given group, when in fact the command has already been sent. This was fixed in the nemo mobile code:

https://github.com/nemomobile-packages/ofono/commit/1266c212271e44db59aab2ef5d773b0afa015e48

[Tony Espy (awe)]

A pull request based on a nemomobile fix has been created which fixes this bug:

https://github.com/tonyespy/ofono/tree/lp1262340

[Launchpad Janitor (janitor)]

This bug was fixed in the package ofono - 1.12+bzr6853-0ubuntu1

---------------
ofono (1.12+bzr6853-0ubuntu1) trusty; urgency=low

  [ Tony Espy ]
  * unit: fix fail-to-build on powerpc
    The previously released version enabled -Wall,
    which triggered build failures due to unused
    functions on powerpc. This is due to the fact
    that the unit tests only run on LITTLE_ENDIAN
    systems via an ifdef, which leaves unused functions
    and data. This change exends the ifdef to cover
    the unused functions and test data.
 -- Ricardo Salveti de Araujo <email address hidden> Tue, 21 Jan 2014 19:43:10 -0200