[PATCH] Integrate auto-login as an option in the UI

[Michael Terry]

Binary package hint: oem-config

It looks like there is some sort of support for auto-login, though it confusingly seems to be always-enabled in 07oem-config-user, then always-disabled in oem-config.

I've attached a first pass at a patch to integrate it more completely. It adds a checkbox to the GTK+ UI and adds support to user-setup-ask/apply to use a new debconf variable passwd/auto-login. I'm pretty sure I haven't 100% correctly added the debconf var, but it works. I'd appreciate any feedback.

I also modify code in d-i/source/ which, if this work gets signed-off-on should actually be done in the original package (user-setup).

[Colin Watson (cjwatson)]

The current auto-login support is there so that the temporary 'oem' user gets automatically logged in, and so that the autologin configuration is removed once the oem user is no longer needed. It looks like this patch breaks that support.

What happened to the KDE support?

It's not very important for this to be asked in d-i. As such, it would probably be better to make the debconf template non-translatable (remove the _ before Description:). The reason this matters is that changes in translatable templates result in very large diffs against Debian which are hard to maintain later, so I try to avoid them wherever possible. To placate lintian, it would probably be best to follow the style of things like passwd/user-uid (comment above explaining purpose, and "Description: for internal use only").

It looks not too bad aside from that; I'll open a user-setup task for the work on that side.

[Michael Terry (mterry)]

OK, this version of the patch doesn't mark the question for translation, doesn't ask it in user-setup-ask, and adds back the KDE stuff (accidentally dropped in previous patch).

It also doesn't touch the one-time oem user setup auto-login, except to move the gdm.conf renaming to before the wizard is run (so it doesn't trample our changes).

It's still missing the UI bits for the KDE frontend. But that can be added separately.

[Michael Terry (mterry)]

Uh, I meant to clean up the diff to not include the test changelog entry. Obviously ignore that piece.

[Colin Watson (cjwatson)]

I'd suggest only changing those files in user-setup if passwd/auto-login was true (it should be able to assume a vanilla setup to start with). I'll make that change when applying this patch. Otherwise this looks good, thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package user-setup - 1.20ubuntu4

---------------
user-setup (1.20ubuntu4) intrepid; urgency=low

  [ Michael Terry ]
  * Add preseedable passwd/auto-login question; if set to true, configure
    gdm and kdm for automatic login (LP: #241372).

 -- Colin Watson <email address hidden> Fri, 25 Jul 2008 09:35:57 +0100

[Colin Watson (cjwatson)]

I've made a few more changes to the oem-config side. Firstly, I made the checkbox unchecked by default. Secondly, I added an oem-config/text/auto_login template to debian/oem-config.templates (and ran debconf-updatepo) to make the new string translatable. Finally, I borrowed the preseed_bool abstraction from ubiquity to simplify the change to lib/components/user.py.

Otherwise, committed - thanks again!

[Launchpad Janitor (janitor)]

This bug was fixed in the package oem-config - 1.45

---------------
oem-config (1.45) intrepid; urgency=low

  [ Colin Watson ]
  * Restore lost change from 1.38:
    - Don't fail to set the locale if the mirror/country question doesn't
      exist.
  * Add oem to /usr/lib/oem-config/user/reserved-usernames (see LP #251056).
  * Add sensible --version output and output our version to oem-config.log.
  * Automatic update of included source packages: localechooser 2.03ubuntu2,
    user-setup 1.20ubuntu4.

  [ Michael Terry ]
  * Set LANG in /etc/default/locale even if it isn't there already
    (LP: #249550).
  * Ensure that some widget is focused after changing page (LP: #241367).
  * Add an auto-login option, currently GTK-only (LP: #241372).

  [ Evan Dandrea ]
  * Do not try to set localechooser/alreadyrun. It is no longer used.
  * Also remove the langlevel file if it exists before we start
    localechooser.

 -- Colin Watson <email address hidden> Fri, 22 Aug 2008 13:00:18 +0100