package is unbackportable to old i386 systems

Bug #1923272 reported by Jason Gross
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ocaml (Ubuntu)
New
Undecided
Unassigned

Bug Description

The patch file 0006-Disable-DT_TEXTREL-warnings-on-Linux-i386.patch is inadequate because it updates configure.ac without updating configure. It should instead read something like
```
diff --git a/configure b/configure
index 74657d2..c1215b4 100755
--- a/configure
+++ b/configure
@@ -13899,6 +13899,18 @@ case $arch in #(
 esac ;;
 esac

+# Disable DT_TEXTREL warnings on Linux i386
+# See https://github.com/ocaml/ocaml/issues/9800
+
+case $host in #(
+ i?86-*-linux-*) :
+ common_cflags="-Wl,-z,notext $common_cflags"
+ mksharedlib="$mksharedlib -Wl,-z,notext"
+ mkmaindll="$mkmaindll -Wl,-z,notext" ;; #(
+ *) :
+ ;;
+esac
+
 # Assembler

 if test -n "$host_alias"; then :
diff --git a/configure.ac b/configure.ac
index aa5f26f..f43eaa4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1015,6 +1015,16 @@ AS_CASE([$arch],
        [common_cflags="-no-pie $common_cflags"],
     [])])

+# Disable DT_TEXTREL warnings on Linux i386
+# See https://github.com/ocaml/ocaml/issues/9800
+
+AS_CASE([$host],
+ [i?86-*-linux-*],
+ [common_cflags="-Wl,-z,notext $common_cflags"
+ mksharedlib="$mksharedlib -Wl,-z,notext"
+ mkmaindll="$mkmaindll -Wl,-z,notext"],
+ [])
+
 # Assembler

 AS_IF([test -n "$host_alias"], [toolpref="${host_alias}-"], [toolpref=""])
```

Revision history for this message
Jason Gross (jgross-h) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.