Wrong includes in /usr/include/obs/obs-frontend-api.h

[Eriberto]

In libobs-dev all headers are in /usr/include/obs/, however the /usr/include/obs/obs-frontend-api.h has two includes pointing to /usr/include/. The fix for this is:

--- obs-frontend-api.h.orig 2021-09-06 23:17:30.132174882 -0300
+++ obs-frontend-api.h 2021-09-06 23:17:04.324371729 -0300
@@ -1,7 +1,7 @@
 #pragma once

-#include <obs.h>
-#include <util/darray.h>
+#include <obs/obs.h>
+#include <obs/util/darray.h>

 #ifdef __cplusplus
 extern "C" {

I already opened this bug in Debian (#993791), but I am specially concerned with Ubuntu 20.04, used by GitHub for CI tests.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "fix-headers.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[IOhannes m zmoelnig (umlaeute)]

is this still relevant?

libobs-dev ships with both `pkg-config` and `cmake` snippets, which afaict instruct the build system (that uses them) that they should (also) look for headers in `/usr/include/obs`.

so if any consumer of the headers uses these snippets, there shouldn't be any problem.

also i notice that https://bugs.debian.org/975504 was closed as completed, even without the fix applied.

[IOhannes m zmoelnig (umlaeute)]

closing this, as libobs-dev contains pkg-config and cmake-snippets that report the correct include-path

[Eriberto (eriberto)]

Sorry, I didn't saw your message from 2022-09-20. Yes, I agree. Fix released.