menu entry for nvtv has no icon

[jcfp]

Binary package hint: nvtv

On Kubuntu feisty with nvtv 0.4.7-5, nvtv's menu entry (under "Multimedia") does not have an icon.

No icon file is provided in the package; the program's .desktop and menu files (/usr/share/applications/nvtv.desktop and /usr/share/menu/nvtv, respectively) don't seem to have any of the usual entries related to icons either.

[Vincent Legout (vlegout)]

I confirm the bug.

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

This debdiff should fix this bug report

[Siegfried Gevatter (rainct)]

Thanks for your patch, Rospo.

Please attach it again without writing the extension on the icon name and then subscribe ubuntu-universe-sponsors to this bug.

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

Ok, maybe this is ok.

[Daniel Holbach (dholbach)]

Anthony: can you check this one and sponsor if it's ok?

[Cesare Tirabassi (norsetto)]

I felt it necessary to add my comment.
The patch applies cleanly, the package builds and install ok, and the debdiff is very good work.
However, the icon appears to be based on the "old" nvidia logo design (with NVTV written on the bottom half).
The logo and NVIDIA trademarks are clearly visible.
I'm not a lawyer but I would not be surprised if the usage of the nvidia logo and trademark without permission is against copyright laws. Can you please check and clarify Mario?

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

I think you're right, what about using nvidia-settings's icon, which seems to be released under GPL ?
This is the copyright of the package http://changelogs.ubuntu.com/changelogs/pool/restricted/n/nvidia-settings/nvidia-settings_1.0+20060516-3ubuntu1/nvidia-settings.copyright

[Cesare Tirabassi (norsetto)]

Yes, I think you can use the images in the nvidia-settings as bases for your icon.
There is just a little step to be done as they are embedded as GdkPixdata structures in header files in the /src/image_data directory (personally I would use these directly and not capture the images from screen).

[Cesare Tirabassi (norsetto)]

Perhaps it is obvious, but it is better to say it: if you use any images as they are or you derive your icon from them, you have to quote them in the copyright file, with info on the origin, copyright year, copyright author and license.

[Anthony Mercatante (tonio)]

strange that this was assigned to me....
I don't even have an nvidia card to test the app !
Btw, looks like the provided patch uses a non-free version of the nvidia logo, I agree on that point and I agree on the idea of using the nvidia-settings image.

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

Instead of using nvidia-settings's one, I used a icon from Envy package from Alberto Milone, which is released under GPL; I hope this is ok. I updated debian/copyright as well, but I don't know if it is ok.

[Cesare Tirabassi (norsetto)]

From your debian/copyright file:

The program icon is taken from the Envy package,
available at http://albertomilone.com/nvidia_scripts1.html .
Copyright: (C) 2006-2007 Alberto Milone

I would reword it as:

The icon nvtv.xpm is based on the nvidia-settings.gif icon, distributed with the envy package, downloaded from: http://albertomilone.com/nvidia_scripts1.html.
The original artwork is Copyright (c) 2006-2007 Alberto Milone <email address hidden> and is licensed under the GP license version 2.

Also note that the freedesktop.org specification recommends a size of 48x48 pixels for .desktop entry icons.

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

Done, thank you for your comments.

[Daniel Holbach (dholbach)]

It'd be good to get this upstream or at least into Debian - do you think you could take care of that? If this does not get upstream, we will not get translated changelog entries easily. Also it's a diff we have to carry with us.

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

nvtv (0.4.7-5ubuntu1) gutsy; urgency=low

  * Provided an icon (LP: #127739)
  * Updated mantainer field

 -- Mario Bonino <email address hidden> Tue, 28 Aug 2007 17:19:42 +0200

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

I've submit this patch to Debian, as you can see above. Thank you all for your comments :)