nvme-cli drops bash completion file in wrong location

[Dan Streetman]

[impact]

The nvme-cli tool includes a bash completion script, but it drops it in the wrong location. This prevents it from actually being sourced and so the nvme tool doesn't do param autocompletion.

[test case]

install the nvme-cli package and try to auto-complete any of its params. They do not auto-complete.

check if the bash auto-completion script is correctly located at:
/usr/share/bash-completion/completions/nvme

[regression potential]

moving where this bash autocompletion file is only has the potential to break nvme's autocompletion.

[scope]

fixed upstream in commit df3a06243da0433d8737cdbfa0e3ac101a3a330e

that is included starting in version 1.7, so Eoan and later are already fixed. This package does not provide any bash completion script in Xenial. So only Bionic needs fixing.

[other info]

[Dan Streetman (ddstreet)]

Xenial nvme-cli doesn't provide any bash completion script; this is needed only in bionic/cosmic.

[Brian Murray (brian-murray)]

Hello Dan, or anyone else affected,

Accepted nvme-cli into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvme-cli/1.5-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Heitor Alves de Siqueira (halves)]

Validated package from -proposed according to test case from description. Tab completion works correctly, and the bash completion script is found under the correct location:

$ dpkg -l | grep nvme-cli
ii nvme-cli 1.5-1ubuntu1.2 amd64 userspace tooling to control NVMe drives

$ nvme <TAB>
admin-passthru delete-ns flush get-ns-id io-passthru memblaze resv-report smart-log-add
attach-ns detach-ns format get_feature list read security-recv subsystem-reset
compare disconnect fw-activate help list-ctrl reset security-send version
connect discover fw-download id-ctrl list-ns resv-acquire set-feature write
connect-all dsm fw-log id-ns list-subsys resv-register show-regs write-uncor
create-ns error-log get-log intel lnvm resv-release smart-log write-zeroes

$ file /usr/share/bash-completion/completions/nvme
/usr/share/bash-completion/completions/nvme: ASCII text

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvme-cli - 1.5-1ubuntu1.2

---------------
nvme-cli (1.5-1ubuntu1.2) bionic; urgency=medium

  * d/p/Fix-bash-completion.patch:
    - Move bash completion files to correct location (LP: #1800544)

 -- Heitor Alves de Siqueira <email address hidden> Wed, 24 Nov 2021 12:37:26 +0000

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for nvme-cli has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.