Unused strings

Bug #1052714 reported by Michi Henning
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nux
Status tracked in 4.0
4.0
In Progress
Low
Unassigned
nux (Ubuntu)
In Progress
Low
Unassigned

Bug Description

In NuxGraphics/RenderingPipeAsm.cpp, on lines 1272 and 1376 are definitions for AsmFrgRect. However, they are not used in the scope where they are defined. It's not clear to me whether they should be used but, accidentally, were not, or whether the definitions should be deleted.

Related branches

Changed in nux:
assignee: nobody → Jay Taoko (jaytaoko)
Revision history for this message
Eleni Maria Stea (hikiko) wrote :

The AsmFrgRect shader prog and I think all the Asm rendering pipe shouldn't be used at all because all the modern GPUs have GLSL support and can compile/run the GLSL equivalent shaders. It's very rear to find a GPU that can only use ARB shaders and I think those GPUs don't have support for vertex shaders either and they can't run nux anyway... (not 100% sure on that though!!!) Maybe we want Unity to run in some very old GPUs and that's why ARB support was not removed?

Revision history for this message
Michi Henning (michihenning) wrote :

In that case I'd check with duflu to see whether there is any realistic scenario under which this might still be needed. If not, I'd ditch the lot. Code that doesn't exist can't harbour any bugs…

Stephen M. Webb (bregma)
no longer affects: nux/3.0
Changed in nux (Ubuntu):
status: New → In Progress
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.