netplan should not try to unbind brcmfmac (like brcmfmac-sdio)

Bug #1712224 reported by Oliver Grawert on 2017-08-22
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nplan (Ubuntu)
High
Mathieu Trudel-Lapierre
Xenial
High
Mathieu Trudel-Lapierre
Zesty
Undecided
Unassigned

Bug Description

[Impact]
Users who need the brcmfmac driver (in one form or another, specifically those not covered by brcmfmac-sdio) to make their wireless network function.

[Test case]
1) Install updated nplan package on nanopi-air
2) Verify that when running 'netplan apply', the network is not brought down by a rebind event on the network interface.

[Regression potential]
Network failures due to rebinding or failing to rebind the network interface, as well as incorrectly applying the settings in a netplan config on the network interfaces, would be possible regressions from this update.

---

while bug #1696162 fixes the breakage on unbind for brcmfmac-sdio it does not fix it for the plain brcmfmac driver like used on the nanopi-air.

Oliver Grawert (ogra) wrote :

debdiff to also prevent plain brcmfmac from unbinding

Oliver Grawert (ogra) on 2017-08-22
summary: - netplan should not try to unbind brcmfmac
+ netplan should not try to unbind brcmfmac (like brcmfmac-sdio)
tags: added: patch
Oliver Grawert (ogra) wrote :
Changed in nplan (Ubuntu):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
status: New → In Progress
importance: Undecided → High
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nplan - 0.26

---------------
nplan (0.26) artful; urgency=medium

  * Bonding:
    - Add support for specifying a primary slave. (LP: #1709135)
  * Rebind:
    - Fix brcmfmac harder. Treat any 'brcmfmac' driver as not supporting
      rebind. (LP: #1712224)
  * Autopkgtests:
    - Add allow-stderr. Systemd now bleats about a the networkd socket still
      being around and enabled when we restart the service; but we don't need
      to care since we're /restarting/ the service to load the new config.
    - Fix the autostart package to be more sensible: we don't really care if
      networkd autostarts or not, but we need to make sure that our generator
      will run at boot, so instead check the state, but only assert it once
      we've added a config file and before checking the state of our dummy
      device.
    - Do a bit more to make sure "mix" tests which stack virtual devices are
      as reliable as possible; by setting saner defaults.

 -- Mathieu Trudel-Lapierre <email address hidden> Wed, 23 Aug 2017 19:32:33 -0400

Changed in nplan (Ubuntu):
status: In Progress → Fix Released
Oliver Grawert (ogra) wrote :

Thanks ! though sorry, I forgot to open a xenial task for the SRU (since we need the fix in Ubuntu Core), i did that now...

Changed in nplan (Ubuntu Xenial):
status: New → In Progress
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
importance: Undecided → High
description: updated

Hello Oliver, or anyone else affected,

Accepted nplan into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nplan/0.29~17.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in nplan (Ubuntu Zesty):
status: New → Fix Committed
tags: added: verification-needed verification-needed-zesty
Brian Murray (brian-murray) wrote :

Hello Oliver, or anyone else affected,

Accepted nplan into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nplan/0.29~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in nplan (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed-xenial
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers