novnc package is missing important launch.sh script, present in the source package

Bug #1492351 reported by Simon Bazley on 2015-09-04
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
novnc (Ubuntu)
Undecided
Unassigned

Bug Description

Summarising from https://answers.launchpad.net/ubuntu/+source/novnc/+question/271057

utils/launch.sh (present in the novnc source package) is a fairly essential part of this application. Without it a user really needs to know how to start up websockify manually, and all the documentation I found online, simply says start utils/launch.sh

Simply extracting the file, isn't enough, as it assumes a websockify executable is in the same folder as the script. Applying this diff, changes the call to make the call as long as websockify is on the path, this makes it work perfectly happily along with the existing websockify package (wherein the websockify executable is installed into /usr/bin).

30a31,32
> #WEBSOCKIFY=${HERE}/websockify
> WEBSOCKIFY=websockify
105c107
< ${HERE}/websockify --web ${WEB} ${CERT:+--cert ${CERT}} ${PORT} ${VNC_DEST} &
---
> ${WEBSOCKIFY} --web ${WEB} ${CERT:+--cert ${CERT}} ${PORT} ${VNC_DEST} &

Simon Bazley (sibaz) on 2015-09-07
description: updated
Simon Bazley (sibaz) wrote :

This is a file, in the format to place it in debian/patches in the source tree

Simon Bazley (sibaz) wrote :

This patches the debian folder in the source package, to alter the dpkg-buildpackage and install scripts, to ensure the new launch.sh patch (see earlier patch) is run, and that utils/launch.sh is included in the novnc package.

The original debian/rules file, wiped the whole novnc/utils folder before packaging, I've now altered the script to simply remove the utils/Makefile which is not needed after the initial build step.

The attachment "Patch to fix utils/launch.sh" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers